Differential D51909

libsa/zfs: remove unused variable
ClosedPublic
Actions

Authored by glebius on Aug 15 2025, 5:42 AM.

Tags

None

Referenced Files

	F139241854: D51909.diff
	Tue, Dec 9, 9:49 PM

	Unknown Object (File)
	Tue, Dec 2, 7:31 AM

	Unknown Object (File)
	Thu, Nov 27, 6:05 AM

	Unknown Object (File)
	Fri, Nov 21, 10:59 PM

	Unknown Object (File)
	Nov 5 2025, 11:31 PM

	Unknown Object (File)
	Oct 16 2025, 2:17 AM

	Unknown Object (File)
	Oct 11 2025, 8:07 AM

	Unknown Object (File)
	Oct 11 2025, 8:07 AM

View All 41 Files

Subscribers

dab

delphij

Details

Reviewers

mav
imp
tsoome
manu

Commits

rG5d5d03356e21: libsa/zfs: remove unused variable

Summary

In vdev_init_from_label() we obtain the pool guid but don't use it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Aug 15 2025, 5:42 AM

Herald added a reviewer: manu. · View Herald TranscriptAug 15 2025, 5:42 AM

Herald added subscribers: dab, delphij. · View Herald Transcript

glebius requested review of this revision.Aug 15 2025, 5:42 AM

Harbormaster completed remote builds in B66252: Diff 160383.Aug 15 2025, 5:42 AM

glebius added a child revision: D51910: libsa/zfs: ignore labels with zero txg.Aug 15 2025, 5:42 AM

imp accepted this revision.Aug 15 2025, 9:26 PM

This revision is now accepted and ready to land.Aug 15 2025, 9:26 PM

mav accepted this revision.Aug 18 2025, 2:45 PM

I think, it was used there just to verify the fact.

Closed by commit rG5d5d03356e21: libsa/zfs: remove unused variable (authored by glebius). · Explain WhyAug 20 2025, 2:53 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG5d5d03356e21: libsa/zfs: remove unused variable.

Revision Contents
Changeset List

Path

Size

stand/

libsa/

zfs/

zfsimpl.c

6 lines

Diff 160671

View Options

libsa/zfs: remove unused variableClosedPublicActions