Differential D51911

libsa/zfs: simplify vdev_find_previous()
ClosedPublic
Actions

Authored by glebius on Aug 15 2025, 5:42 AM.

Details

Reviewers

mav
imp
tsoome
manu

Commits

rG8ef5016f73b9: libsa/zfs: simplify vdev_find_previous()

Summary

An empty list case is properly covered by the cycle.
Don't pass pointer to vdev being looked up, pass just id.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Aug 15 2025, 5:42 AM

Herald added a reviewer: manu. · View Herald TranscriptAug 15 2025, 5:42 AM

Herald added subscribers: dab, delphij. · View Herald Transcript

glebius requested review of this revision.Aug 15 2025, 5:42 AM

Harbormaster completed remote builds in B66254: Diff 160385.Aug 15 2025, 5:42 AM

glebius added a parent revision: D51910: libsa/zfs: ignore labels with zero txg.Aug 15 2025, 5:42 AM

glebius added a child revision: D51912: libsa/zfs: refactor vdev tree for better resiliency against stale disks.

mav accepted this revision.Aug 18 2025, 2:54 PM

This revision is now accepted and ready to land.Aug 18 2025, 2:54 PM

imp accepted this revision.Aug 18 2025, 6:28 PM

Closed by commit rG8ef5016f73b9: libsa/zfs: simplify vdev_find_previous() (authored by glebius). · Explain WhyAug 20 2025, 2:54 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG8ef5016f73b9: libsa/zfs: simplify vdev_find_previous().

Revision Contents
Changeset List

Path

Size

stand/

libsa/

zfs/

zfsimpl.c

13 lines

Diff 160673

View Options

libsa/zfs: simplify vdev_find_previous()ClosedPublicActions