libsa/zfs: ignore labels with zero txg
ClosedPublic
Actions

Authored by glebius on Aug 15 2025, 5:42 AM.

Details

Reviewers

mav
imp
tsoome
manu

Commits

rGde055556a0d1: libsa/zfs: ignore labels with zero txg

Summary

Zero txg means this vdev has been correctly removed from the pool. For
reference see module/zfs/vdev_removal.c in OpenZFS. It calls
vdev_label_init(vd, 0, VDEV_LABEL_REMOVE), and second argument there is
the txg to write.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Aug 15 2025, 5:42 AM

Herald added a reviewer: manu. · View Herald TranscriptAug 15 2025, 5:42 AM

Herald added subscribers: dab, delphij. · View Herald Transcript

Harbormaster completed remote builds in B66253: Diff 160384.Aug 15 2025, 5:42 AM

glebius requested review of this revision.Aug 15 2025, 5:42 AM

glebius added a parent revision: D51909: libsa/zfs: remove unused variable.

glebius added a child revision: D51911: libsa/zfs: simplify vdev_find_previous().

imp accepted this revision.Aug 15 2025, 9:27 PM

This revision is now accepted and ready to land.Aug 15 2025, 9:27 PM

Searching for ZPOOL_CONFIG_POOL_TXG in OpenZFS I indeed see plenty of similar txg == 0 checks.

thanks!

Closed by commit rGde055556a0d1: libsa/zfs: ignore labels with zero txg (authored by glebius). · Explain WhyAug 20 2025, 2:54 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGde055556a0d1: libsa/zfs: ignore labels with zero txg.

Revision Contents
Changeset List

Path

Size

stand/

libsa/

zfs/

zfsimpl.c

3 lines

Diff 160672

View Options

libsa/zfs: ignore labels with zero txgClosedPublicActions