stand/efi: Use EFI_PAGE_SIZE here, it's more appropriate
ClosedPublic
Actions

Authored by imp on May 28 2025, 9:48 PM.

Details

Reviewers

chs
kevans
jhibbits
tsoome
manu

Commits

rG700a2c08dcea: stand/efi: Use EFI_PAGE_SIZE here, it's more appropriate

Summary

No functional change: We're allocating a page from EFI, which is always
4k on amd64. So, this should always be 4k. PAGE_SIZE usually is this,
but might not be in some cases. For the end of the stack pointer in the
ist1, it should point the architecture's phyiscal page past where we've
allocated. EFI_PAGE_SIZE more faithfully reflects that here since
PAGE_SIZE might not be exactly that in the future (if we had a larger
logical page than physical page). Since the AllocPage interface is in
EFI_PAGE_SIZE pages always, this seems safer. No functional change since
they are both 2096 today.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.May 28 2025, 9:48 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 28 2025, 9:49 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

imp requested review of this revision.May 28 2025, 9:49 PM

Harbormaster completed remote builds in B64515: Diff 156231.May 28 2025, 9:49 PM

imp added a child revision: D50585: stand: Introduce md_align.May 28 2025, 9:49 PM

tsoome accepted this revision.May 28 2025, 9:53 PM

This revision is now accepted and ready to land.May 28 2025, 9:53 PM

The code change is fine, but the commit comment has several typos (appropraite vs. appropriate, phyiscal vs. physical, 2096 vs. 4096).

imp retitled this revision from stand/efi: Use EFI_PAGE_SIZE here, it's more appropraite to stand/efi: Use EFI_PAGE_SIZE here, it's more appropriate.May 29 2025, 6:04 PM

Update per review

This revision now requires review to proceed.May 29 2025, 6:17 PM

Harbormaster completed remote builds in B64533: Diff 156262.May 29 2025, 6:17 PM

tsoome accepted this revision.May 29 2025, 9:16 PM

This revision is now accepted and ready to land.May 29 2025, 9:16 PM

Closed by commit rG700a2c08dcea: stand/efi: Use EFI_PAGE_SIZE here, it's more appropriate (authored by imp). · Explain WhyMay 30 2025, 3:57 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG700a2c08dcea: stand/efi: Use EFI_PAGE_SIZE here, it's more appropriate.