Page MenuHomeFreeBSD
Differential D54843

loader.conf.5: "console" setting does not document multi-value possiblity
ClosedPublic
Actions

Authored by michaelo on Fri, Jan 23, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 18, 8:13 AM
Unknown Object (File)
Wed, Feb 18, 8:13 AM
Unknown Object (File)
Wed, Feb 18, 8:12 AM
Unknown Object (File)
Wed, Feb 18, 3:41 AM
Unknown Object (File)
Tue, Feb 17, 11:33 PM
Unknown Object (File)
Tue, Feb 17, 1:02 AM
Unknown Object (File)
Mon, Feb 16, 9:13 AM
Unknown Object (File)
Fri, Feb 13, 1:31 PM
View All 27 Files
Subscribers
dab
imp
kevans
tsoome

Details

Reviewers
ziaee
manu
dab
imp
loader
tsoome
Commits
rGc0053a940e27: loader.conf.5: "console" setting does not document multi-value possiblity
rGe58f90157c9b: loader.conf.5: "console" setting does not document multi-value possiblity
rG39812c74519c: loader.conf.5: "console" setting does not document multi-value possiblity
rG240c614d48cb: loader.conf.5: "console" setting does not document multi-value possiblity
Summary

PR: 292595
Approved by: ziaee
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo created this revision.Fri, Jan 23, 8:28 PM
Herald added a reviewer: manu. · View Herald TranscriptFri, Jan 23, 8:28 PM
Herald added subscribers: dab, imp. · View Herald Transcript
Harbormaster completed remote builds in B70081: Diff 170286.Fri, Jan 23, 8:28 PM
michaelo requested review of this revision.Fri, Jan 23, 8:28 PM
imp added a comment.Fri, Jan 23, 11:19 PM

Comma separated is preferred. Spaces happen to work.

michaelo updated this revision to Diff 170340.Sat, Jan 24, 6:46 PM

@imp as requested...

Harbormaster completed remote builds in B70110: Diff 170340.Sat, Jan 24, 6:46 PM
ziaee accepted this revision.Sat, Jan 24, 7:27 PM
ziaee added subscribers: tsoome, kevans.

This is fine with me, but I would wait for @imp or even anyone someone else from Loader like @kevans or @tsoome. It sounds like he might not want to declare that space works and then they're committed to supporting that, or making things consistent towards that.

This revision is now accepted and ready to land.Sat, Jan 24, 7:27 PM
michaelo added a comment.Sat, Jan 24, 7:29 PM
In D54843#1254166, @ziaee wrote:

This is fine with me, but I would wait for @imp or even anyone someone else from Loader like @kevans or @tsoome. It sounds like he might not want to declare that space works and then they're committed to supporting that, or making things consistent towards that.

I am fine with that as long as docs and code are consistent.

dab requested changes to this revision.Sun, Jan 25, 10:48 PM
dab added inline comments.
stand/defaults/loader.conf.5
332

s/seperated/separated/

This revision now requires changes to proceed.Sun, Jan 25, 10:48 PM
michaelo updated this revision to Diff 170439.Mon, Jan 26, 6:22 AM

Fix typo

Harbormaster completed remote builds in B70140: Diff 170439.Mon, Jan 26, 6:22 AM
michaelo added reviewers: imp, loader.Tue, Jan 27, 3:20 PM
dab accepted this revision.Wed, Jan 28, 3:22 AM
This revision is now accepted and ready to land.Wed, Jan 28, 3:22 AM
imp accepted this revision.Wed, Jan 28, 3:51 AM

Comma is preferred.

ziaee accepted this revision.Wed, Jan 28, 3:58 AM
tsoome accepted this revision.Wed, Jan 28, 5:06 AM
michaelo added a comment.Wed, Jan 28, 8:42 AM
In D54843#1255708, @imp wrote:

Comma is preferred.

I will create a separate PR for these cases as described in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292595#c0.

Closed by commit rG240c614d48cb: loader.conf.5: "console" setting does not document multi-value possiblity (authored by michaelo). · Explain WhyWed, Jan 28, 8:54 AM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: rG240c614d48cb: loader.conf.5: "console" setting does not document multi-value possiblity.
michaelo mentioned this in D54923: loader: Prefer comma-separated list of values for "console".Wed, Jan 28, 9:05 AM
michaelo added a commit: rG39812c74519c: loader.conf.5: "console" setting does not document multi-value possiblity.Sat, Jan 31, 5:30 PM
michaelo added a commit: rGe58f90157c9b: loader.conf.5: "console" setting does not document multi-value possiblity.
michaelo added a commit: rGc0053a940e27: loader.conf.5: "console" setting does not document multi-value possiblity.Sat, Jan 31, 5:35 PM

Revision Contents
Changeset List

PathSize
stand/
defaults/
2 lines
1 line

Diff 170630

View Options

stand/defaults/loader.conf

Loading...
View Options

stand/defaults/loader.conf.5

Loading...