loader.efi: only use firmware provided Blt on GOP
ClosedPublic
Actions

Authored by vexeduxr on Wed, Dec 31, 4:32 AM.

Details

Reviewers

imp
kevans
tsoome
manu

Commits

rG8591ee986b22: loader.efi: only use firmware provided Blt on GOP
rG6741fb1bd4f4: loader.efi: only use firmware provided Blt on GOP
rGd3902baca506: loader.efi: only use firmware provided Blt on GOP
rG9595055ae749: loader.efi: only use firmware provided Blt on GOP

Summary

gfx_state.tg_private points to a EFI_GRAPHICS_OUTPUT_PROTOCOL only when
using GOP.

The firmware provided Blt functions on UGA platforms have been observed
to not work on old MacBooks, and are likley hit or miss anyways as UGA
has been deprecated since 2006.

MFC after: 1 week
PR: 291935

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vexeduxr created this revision.Wed, Dec 31, 4:32 AM

Herald added a reviewer: manu. · View Herald TranscriptWed, Dec 31, 4:32 AM

Herald added a subscriber: dab. · View Herald Transcript

vexeduxr requested review of this revision.Wed, Dec 31, 4:32 AM

Harbormaster completed remote builds in B69542: Diff 168794.Wed, Dec 31, 4:32 AM

vexeduxr added a parent revision: D54431: loader.efi: probe for UGA if GOP isn't found.Wed, Dec 31, 4:32 AM

jlduran added a subscriber: jlduran.Wed, Dec 31, 5:43 PM

tsoome requested changes to this revision.Sat, Jan 3, 4:28 PM

tsoome added inline comments.

stand/common/gfx_fb.c
860	I think, Instead of adding another condition into if statement, the proper implementation would be to have conditional assignment for gop. As tg_private may now point to gop or uga, we should not blindly cast the pointer there. if (gfx_state.tg_fb_type == FB_GOP) gop = gfx_state.tg_private; else gop = NULL; and the if statement will do its thing below...

This revision now requires changes to proceed.Sat, Jan 3, 4:28 PM

vexeduxr added inline comments.Sat, Jan 3, 6:12 PM

stand/common/gfx_fb.c
860	Agreed, `gop` shouldn't be unconditionally assigned like that. I think we can replace `gop != NULL` with `gfx_state.tg_fb_type == FB_GOP`. Since `gfx_state.tg_private` should always be non-NULL in that case.