splash: add shutdown splash
Needs ReviewPublic
Actions

Authored by quentin.thebault_defenso.fr on Fri, Feb 6, 7:39 AM.

Details

Reviewers

kevans
vexeduxr
manu

Summary

This commit adds shutdown_splash options to the kernel configuration and to
loader.conf to let the user enable and customize a splash screen image that will
be displayed at shutdown time.

Signed-off-by: Quentin Thébault <quentin.thebault@defenso.fr>
Sponsored by: Defenso
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70653
Build 67536: arc lint + arc unit

Event Timeline

quentin.thebault_defenso.fr created this revision.Fri, Feb 6, 7:39 AM

Herald added subscribers: ziaee, olce, dab and 2 others. · View Herald TranscriptFri, Feb 6, 7:39 AM

quentin.thebault_defenso.fr requested review of this revision.Fri, Feb 6, 7:39 AM

Harbormaster completed remote builds in B70463: Diff 171319.Fri, Feb 6, 7:39 AM

Awesome.
But I don't think that we should add a new kernel option, just put everything depending on DEV_SPLASH.
Otherwise everything looks ok.

This revision now requires changes to proceed.Sat, Feb 7, 7:48 AM

imp added inline comments.Sat, Feb 7, 3:04 PM

stand/common/gfx_fb.c
3101	Did you build all the bootloaders? I think there is a copy of this in the stube version of this file. tools/boot/universe.sh is a script to build them all fast.

Remove SHUTDOWN_SPLASH option and merge into DEV_SPLASH

Harbormaster completed remote builds in B70579: Diff 171639.Tue, Feb 10, 1:48 PM

quentin.thebault_defenso.fr marked an inline comment as done.Tue, Feb 10, 1:49 PM

quentin.thebault_defenso.fr added inline comments.

stand/common/gfx_fb.c

3101

Yes, done. Everything succeeds.

$ make universe
Building /usr/obj/usr/src/amd64.amd64/stand/universe
Building aarch64 WITHOUT_FORTH=yes ... Success
Building amd64 WITHOUT_FORTH=yes ... Success
Building i386 WITHOUT_FORTH=yes ... Success
Building aarch64 WITHOUT_LOADER_GELI=yes ... Success
Building amd64 WITHOUT_LOADER_GELI=yes ... Success
Building i386 WITHOUT_LOADER_GELI=yes ... Success
Building amd64  ... Success
Building armv7  ... Success
Building aarch64  ... Success
Building i386  ... Success
Building powerpc  ... Success
Building powerpc64  ... Success
Building powerpc64le  ... Success
Building riscv64  ... Success
Building aarch64 MK_LOADER_ZFS=no ... Success
Building amd64 MK_LOADER_ZFS=no ... Success
Building i386 MK_LOADER_ZFS=no ... Success
Building amd64 MK_LOADER_BIOS_TEXTONLY=no ... Success
Building i386 MK_LOADER_BIOS_TEXTONLY=no ... Success