Page MenuHomeFreeBSD

dumbbell (Jean-Sébastien Pédron)
User

Projects

User Details

User Since
May 27 2014, 10:08 AM (639 w, 6 d)

Recent Activity

Sun, Aug 16

dumbbell added a comment to D58753: linux: add dma-buf and sync_file ioctl handlers.

I didn't work on the implementation of dma-buf for FreeBSD. We have this BSD-licensed implementation in drm-kmod right now and we can surely move that to base. I find it receives changes infrequently in Linux, so hopefully, that shouldn't be something that slows down or interferes with making a given version of drm-kmod compatible with multiple versions of FreeBSD.

Sun, Aug 16, 6:12 PM · Linux Emulation, x11
dumbbell accepted D58753: linux: add dma-buf and sync_file ioctl handlers.
Sun, Aug 16, 12:10 PM · Linux Emulation, x11
dumbbell closed D58252: linuxkpi: Fix return type of `kobject_uevent_env()`.
Sun, Aug 16, 10:33 AM
dumbbell accepted D58252: linuxkpi: Fix return type of `kobject_uevent_env()`.
Sun, Aug 16, 10:33 AM
dumbbell closed D58250: linuxkpi: Define `PCI_CLASS_BRIDGE_HOST`.
Sun, Aug 16, 10:33 AM
dumbbell accepted D58250: linuxkpi: Define `PCI_CLASS_BRIDGE_HOST`.
Sun, Aug 16, 10:32 AM

Sat, Aug 15

dumbbell committed rGf4cfc8a7f727: linuxkpi: Include <linux/page-flags.h> from <linux/mm.h> (authored by dumbbell).
linuxkpi: Include <linux/page-flags.h> from <linux/mm.h>
Sat, Aug 15, 6:30 PM
dumbbell committed rGd93aa77e0e9e: linuxkpi: Create empty <linux/sprintf.h> (authored by dumbbell).
linuxkpi: Create empty <linux/sprintf.h>
Sat, Aug 15, 6:29 PM
dumbbell committed rGaf9c64fd6c54: linuxkpi: Fix return type of `kobject_uevent_env()` (authored by dumbbell).
linuxkpi: Fix return type of `kobject_uevent_env()`
Sat, Aug 15, 6:29 PM
dumbbell committed rG4565eeaccddf: linuxkpi: Define `PCI_CLASS_BRIDGE_HOST` (authored by dumbbell).
linuxkpi: Define `PCI_CLASS_BRIDGE_HOST`
Sat, Aug 15, 6:29 PM
dumbbell committed rGd77271ce7a65: linuxkpi: Add `kunit_fail_current_test()` (authored by dumbbell).
linuxkpi: Add `kunit_fail_current_test()`
Sat, Aug 15, 6:29 PM
dumbbell committed rG0fbdaf0c9aac: linuxkpi: Define `__GFP_HIGH` in <linux/gfp.h> (authored by dumbbell).
linuxkpi: Define `__GFP_HIGH` in <linux/gfp.h>
Sat, Aug 15, 6:29 PM
dumbbell closed D58761: linuxkpi: Include <linux/page-flags.h> from <linux/mm.h>.
Sat, Aug 15, 6:29 PM
dumbbell closed D58253: linuxkpi: Create empty <linux/sprintf.h>.
Sat, Aug 15, 6:29 PM
dumbbell closed D58249: linuxkpi: Add `kunit_fail_current_test()`.
Sat, Aug 15, 6:29 PM
dumbbell closed D58760: linuxkpi: Define `__GFP_HIGH` in <linux/gfp.h>.
Sat, Aug 15, 6:29 PM
dumbbell committed rG45e00486d695: linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h> (authored by dumbbell).
linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>
Sat, Aug 15, 6:29 PM
dumbbell closed D57570: linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>.
Sat, Aug 15, 6:29 PM
dumbbell updated the summary of D57701: linuxkpi: Add `kthread_run_worker()`.
Sat, Aug 15, 5:53 PM · linuxkpi

Mon, Aug 10

dumbbell requested review of D58765: linuxkpi: Re-implement <linux/hashtable.h> based on `struct hlist_head`.
Mon, Aug 10, 5:33 PM · linuxkpi
dumbbell requested review of D58764: linuxkpi: Add `shmem_read_folio()`.
Mon, Aug 10, 5:32 PM · linuxkpi
dumbbell requested review of D58763: linuxkpi: Add several folio-related functions.
Mon, Aug 10, 5:32 PM · linuxkpi
dumbbell requested review of D58762: linuxkpi: Add `split_page()`.
Mon, Aug 10, 5:31 PM · linuxkpi
dumbbell requested review of D58761: linuxkpi: Include <linux/page-flags.h> from <linux/mm.h>.
Mon, Aug 10, 5:30 PM
dumbbell requested review of D58760: linuxkpi: Define `__GFP_HIGH` in <linux/gfp.h>.
Mon, Aug 10, 5:29 PM
dumbbell requested review of D58759: linuxkpi: Add the `*_new` fields to `struct bin_attribute`.
Mon, Aug 10, 5:28 PM · linuxkpi
dumbbell requested review of D58758: linuxkpi: Add `timer64_to_tm()`.
Mon, Aug 10, 5:27 PM · linuxkpi
dumbbell updated the summary of D58757: linuxkpi: Add `hrtimer_setup()`.
Mon, Aug 10, 5:27 PM · linuxkpi
dumbbell requested review of D58757: linuxkpi: Add `hrtimer_setup()`.
Mon, Aug 10, 5:26 PM · linuxkpi

Jul 26 2026

dumbbell accepted D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.
Jul 26 2026, 10:45 AM
dumbbell added a comment to D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.
In D58320#1341246, @bz wrote:

Note: I am still confused as to why we do all this checking manually there instead of simply call vm_page_unwire() of which we seem to duplicate the logic?

Jul 26 2026, 10:44 AM

Jul 25 2026

dumbbell added a comment to D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.

this is 6.14? So there's a new case that we didn't know about during the time we fixed master (before/after 6.12?) or had I missed this before?

Jul 25 2026, 5:33 PM
dumbbell requested changes to D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.

Oops, I forgot to mark the review as needing changes.

Jul 25 2026, 4:43 PM
dumbbell added a comment to D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.

I made an inline comment in linux_free_page(): there is a refcounting issue vs. the call to lkpi_page_unset_vm_page().

Jul 25 2026, 4:37 PM
dumbbell added a comment to D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.

The patch looks good to me.

Jul 25 2026, 11:34 AM

Jul 15 2026

dumbbell added a comment to D58254: linuxkpi: Define `for_each_if()`.

Indeed, I kind of remembered something similar but a quick search didn’t return this review. Thank you!

Jul 15 2026, 11:23 AM · linuxkpi
dumbbell requested review of D58254: linuxkpi: Define `for_each_if()`.
Jul 15 2026, 8:19 AM · linuxkpi
dumbbell requested review of D58253: linuxkpi: Create empty <linux/sprintf.h>.
Jul 15 2026, 8:19 AM
dumbbell requested review of D58252: linuxkpi: Fix return type of `kobject_uevent_env()`.
Jul 15 2026, 8:18 AM
dumbbell requested review of D58251: linuxkpi: Add `int_sqrt()`.
Jul 15 2026, 8:17 AM · linuxkpi
dumbbell requested review of D58250: linuxkpi: Define `PCI_CLASS_BRIDGE_HOST`.
Jul 15 2026, 8:16 AM
dumbbell requested review of D58249: linuxkpi: Add `kunit_fail_current_test()`.
Jul 15 2026, 8:15 AM

Jul 14 2026

dumbbell committed rG8909dd214144: linuxkpi: Add `acpi_video_get_edid()` (authored by dumbbell).
linuxkpi: Add `acpi_video_get_edid()`
Jul 14 2026, 10:53 AM
dumbbell closed D57576: linuxkpi: Add `acpi_video_get_edid()`.
Jul 14 2026, 10:53 AM
dumbbell updated the diff for D57570: linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>.

Address comment from @emaste by uncommenting the include of <linux/plist.h> and adding it as a dummy header.

Jul 14 2026, 10:02 AM

Jul 12 2026

dumbbell requested review of D58195: linuxkpi: Update `struct vm_area_struct` when an existing mapping is extended.
Jul 12 2026, 4:35 PM · linuxkpi
dumbbell requested review of D58194: linuxkpi: Fix assertion in `lkpi_vmf_insert_pfn_prot_locked()`.
Jul 12 2026, 4:33 PM · linuxkpi
dumbbell committed R9:5f2775bccd9d: Status/2026Q2/drm-drivers.adoc: Add report about DRM drivers (authored by dumbbell).
Status/2026Q2/drm-drivers.adoc: Add report about DRM drivers
Jul 12 2026, 3:55 PM

Jul 11 2026

dumbbell accepted D57465: LinuxKPI: Create `linux/util_macros.h`.
Jul 11 2026, 8:24 AM · linuxkpi
dumbbell accepted D58076: LinuxKPI: Add compat_ptr_ioctl.
Jul 11 2026, 8:22 AM · linuxkpi

Jul 9 2026

dumbbell accepted D58075: LinuxKPI: Added jiffies64_to_msecs for amdkfd compatibility..
Jul 9 2026, 10:02 PM · linuxkpi
dumbbell requested changes to D58076: LinuxKPI: Add compat_ptr_ioctl.
Jul 9 2026, 9:58 PM · linuxkpi
dumbbell accepted D57730: LinuxKPI: add system_percpu_wq.
Jul 9 2026, 9:53 PM
dumbbell accepted D57429: LinuxKPI: pci detach: implement a proper detach (release) path.

This patch looks good to me. I just noted one comment which is unclear to me.

Jul 9 2026, 9:51 PM
dumbbell accepted D57428: LinuxKPI: fix lkpi_pci_get_device() reference counting on device.
Jul 9 2026, 9:42 PM
dumbbell committed rGe9f21e4f28ce: linuxkpi: Add `usleep_range_state()` (authored by dumbbell).
linuxkpi: Add `usleep_range_state()`
Jul 9 2026, 6:34 PM
dumbbell committed rG6d5f5f730a42: linuxkpi: Add `to_acpi_device_node()` and `ACPI_COMPANION()` (authored by dumbbell).
linuxkpi: Add `to_acpi_device_node()` and `ACPI_COMPANION()`
Jul 9 2026, 6:34 PM
dumbbell closed D57579: linuxkpi: Add `usleep_range_state()`.
Jul 9 2026, 6:34 PM
dumbbell closed D57577: linuxkpi: Add `to_acpi_device_node()` and `ACPI_COMPANION()`.
Jul 9 2026, 6:34 PM

Jul 8 2026

dumbbell updated the diff for D57576: linuxkpi: Add `acpi_video_get_edid()`.

Fix typo, reported by @emaste

Jul 8 2026, 8:47 PM

Jun 24 2026

dumbbell committed rG72a6197df998: linuxkpi: Define `ULL()` (authored by dumbbell).
linuxkpi: Define `ULL()`
Jun 24 2026, 4:48 PM
dumbbell committed rGb55cc81fcf97: linuxkpi: Add <linux/cgroup_dmem.h> (authored by dumbbell).
linuxkpi: Add <linux/cgroup_dmem.h>
Jun 24 2026, 4:48 PM
dumbbell committed rGde51e9ae5f69: linuxkpi: Defined more Intel vendor/family/model constants (authored by dumbbell).
linuxkpi: Defined more Intel vendor/family/model constants
Jun 24 2026, 4:48 PM
dumbbell committed rGa68dcfaf0236: linuxkpi: Define and fill `struct cpuinfo_x86->x86_stepping` (authored by dumbbell).
linuxkpi: Define and fill `struct cpuinfo_x86->x86_stepping`
Jun 24 2026, 4:48 PM
dumbbell closed D57703: linuxkpi: Define `ULL()`.
Jun 24 2026, 4:48 PM
dumbbell committed rG8aa685153bd6: linuxkpi: Add const qualifier to `bitmap_weight()` 1st arg (authored by dumbbell).
linuxkpi: Add const qualifier to `bitmap_weight()` 1st arg
Jun 24 2026, 4:48 PM
dumbbell closed D57702: linuxkpi: Add <linux/cgroup_dmem.h>.
Jun 24 2026, 4:48 PM
dumbbell closed D57698: linuxkpi: Define and fill `struct cpuinfo_x86->x86_stepping`.
Jun 24 2026, 4:48 PM
dumbbell closed D57699: linuxkpi: Defined more Intel vendor/family/model constants.
Jun 24 2026, 4:48 PM
dumbbell committed rG272a12639440: linuxkpi: Define `struct vfsmount` in <linux/mount.h> (authored by dumbbell).
linuxkpi: Define `struct vfsmount` in <linux/mount.h>
Jun 24 2026, 4:48 PM
dumbbell closed D57581: linuxkpi: Add const qualifier to `bitmap_weight()` 1st arg.
Jun 24 2026, 4:48 PM
dumbbell closed D57572: linuxkpi: Define `struct vfsmount` in <linux/mount.h>.
Jun 24 2026, 4:48 PM

Jun 20 2026

dumbbell requested review of D57703: linuxkpi: Define `ULL()`.
Jun 20 2026, 12:04 PM
dumbbell requested review of D57702: linuxkpi: Add <linux/cgroup_dmem.h>.
Jun 20 2026, 12:04 PM
dumbbell requested review of D57701: linuxkpi: Add `kthread_run_worker()`.
Jun 20 2026, 12:03 PM · linuxkpi
dumbbell requested review of D57700: linuxkpi: Add x86 CPU ID matching functions and macros.
Jun 20 2026, 12:02 PM · linuxkpi
dumbbell requested review of D57699: linuxkpi: Defined more Intel vendor/family/model constants.
Jun 20 2026, 12:02 PM
dumbbell requested review of D57698: linuxkpi: Define and fill `struct cpuinfo_x86->x86_stepping`.
Jun 20 2026, 12:01 PM
dumbbell committed rGaf187b20cdb0: linuxkpi: Define `COUNT_ARGS()` and `CONCATENATE()` (authored by dumbbell).
linuxkpi: Define `COUNT_ARGS()` and `CONCATENATE()`
Jun 20 2026, 11:55 AM
dumbbell committed rGc27779e0a954: linuxkpi: Change `strscpy()` and `strscpy_pad()` to make their `len` argument… (authored by dumbbell).
linuxkpi: Change `strscpy()` and `strscpy_pad()` to make their `len` argument…
Jun 20 2026, 11:55 AM
dumbbell closed D57584: linuxkpi: Define `COUNT_ARGS()` and `CONCATENATE()`.
Jun 20 2026, 11:55 AM
dumbbell committed rG50aa145171bc: linuxkpi: Add 'fd_empty()` (authored by dumbbell).
linuxkpi: Add 'fd_empty()`
Jun 20 2026, 11:55 AM
dumbbell closed D57585: linuxkpi: Change `strscpy()` and `strscpy_pad()` to make their `len` argument optional.
Jun 20 2026, 11:55 AM
dumbbell closed D57582: linuxkpi: Add 'fd_empty()`.
Jun 20 2026, 11:55 AM
dumbbell committed rG2e10a6bd5627: linuxkpi: Add `pm_resume_via_firmware()` (authored by dumbbell).
linuxkpi: Add `pm_resume_via_firmware()`
Jun 20 2026, 11:55 AM
dumbbell closed D57580: linuxkpi: Add `pm_resume_via_firmware()`.
Jun 20 2026, 11:55 AM
dumbbell committed rG53baadc2f615: linuxkpi: Define a bunch of constants in <acpi/video.h> (authored by dumbbell).
linuxkpi: Define a bunch of constants in <acpi/video.h>
Jun 20 2026, 11:55 AM
dumbbell closed D57575: linuxkpi: Define a bunch of constants in <acpi/video.h>.
Jun 20 2026, 11:55 AM
dumbbell committed rG294553b022b1: linuxkpi: Define `__ATTR_RO_MODE()` and `__ATTR_RW_MODE()` (authored by dumbbell).
linuxkpi: Define `__ATTR_RO_MODE()` and `__ATTR_RW_MODE()`
Jun 20 2026, 11:55 AM
dumbbell closed D57574: linuxkpi: Define `__ATTR_RO_MODE()` and `__ATTR_RW_MODE()`.
Jun 20 2026, 11:54 AM
dumbbell closed D57578: sys: Add `isgraph()` to <sys/ctype.h>.
Jun 20 2026, 11:54 AM
dumbbell committed rG4831a8d792d4: sys: Add `isgraph()` to <sys/ctype.h> (authored by dumbbell).
sys: Add `isgraph()` to <sys/ctype.h>
Jun 20 2026, 11:54 AM

Jun 15 2026

dumbbell accepted D57590: LinuxKPI: add KERNEL_VERSION() macro.

Thanks for the explanation!

Jun 15 2026, 7:56 AM
dumbbell accepted D57463: LinuxKPI: Create pm_runtime_resume_and_get function, used by new versions of amdgpu.

I agree with @bz about adding printed TODO when called. I’m still accepting this patch because it should be part of another review probably.

Jun 15 2026, 7:54 AM
dumbbell added inline comments to D57463: LinuxKPI: Create pm_runtime_resume_and_get function, used by new versions of amdgpu.
Jun 15 2026, 7:52 AM
dumbbell requested changes to D57465: LinuxKPI: Create `linux/util_macros.h`.
Jun 15 2026, 7:50 AM · linuxkpi
dumbbell accepted D57594: LinuxKPI: scatterlist.h: implement sg_init_marker().
Jun 15 2026, 7:31 AM

Jun 14 2026

dumbbell added a comment to D57590: LinuxKPI: add KERNEL_VERSION() macro.

What are the use cases for this macro?

Jun 14 2026, 7:25 PM
dumbbell abandoned D57571: linuxkpi: Add missing includes leading to <linux/kconfig.h>.

Instead of this hack around <linux/radix-tree.h> and <linux/xarray.h>, I implemented the following solution in drm-kmod:
https://github.com/freebsd/drm-kmod/pull/477

Jun 14 2026, 7:20 PM
dumbbell requested review of D57586: linuxkpi: Alias `sd` field of `struct kobject`.
Jun 14 2026, 9:25 AM · linuxkpi