User Details
User Details
- User Since
- May 27 2014, 10:08 AM (633 w, 6 d)
Wed, Jul 15
Wed, Jul 15
dumbbell added a comment to D58254: linuxkpi: Define `for_each_if()`.
Indeed, I kind of remembered something similar but a quick search didn’t return this review. Thank you!
dumbbell requested review of D58254: linuxkpi: Define `for_each_if()`.
dumbbell requested review of D58253: linuxkpi: Create empty <linux/sprintf.h>.
dumbbell requested review of D58252: linuxkpi: Fix return type of `kobject_uevent_env()`.
dumbbell requested review of D58251: linuxkpi: Add `int_sqrt()`.
dumbbell requested review of D58250: linuxkpi: Define `PCI_CLASS_BRIDGE_HOST`.
dumbbell requested review of D58249: linuxkpi: Add `kunit_fail_current_test()`.
Tue, Jul 14
Tue, Jul 14
linuxkpi: Add `acpi_video_get_edid()`
dumbbell updated the diff for D57570: linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>.
Address comment from @emaste by uncommenting the include of <linux/plist.h> and adding it as a dummy header.
Sun, Jul 12
Sun, Jul 12
dumbbell requested review of D58194: linuxkpi: Fix assertion in `lkpi_vmf_insert_pfn_prot_locked()`.
dumbbell committed R9:5f2775bccd9d: Status/2026Q2/drm-drivers.adoc: Add report about DRM drivers (authored by dumbbell).
Status/2026Q2/drm-drivers.adoc: Add report about DRM drivers
Sat, Jul 11
Sat, Jul 11
Thu, Jul 9
Thu, Jul 9
dumbbell requested changes to D58076: LinuxKPI: Add compat_ptr_ioctl.
This patch looks good to me. I just noted one comment which is unclear to me.
linuxkpi: Add `usleep_range_state()`
dumbbell committed rG6d5f5f730a42: linuxkpi: Add `to_acpi_device_node()` and `ACPI_COMPANION()` (authored by dumbbell).
linuxkpi: Add `to_acpi_device_node()` and `ACPI_COMPANION()`
Wed, Jul 8
Wed, Jul 8
dumbbell updated the diff for D57576: linuxkpi: Add `acpi_video_get_edid()`.
Fix typo, reported by @emaste
Wed, Jun 24
Wed, Jun 24
linuxkpi: Define `ULL()`
linuxkpi: Add <linux/cgroup_dmem.h>
dumbbell committed rGde51e9ae5f69: linuxkpi: Defined more Intel vendor/family/model constants (authored by dumbbell).
linuxkpi: Defined more Intel vendor/family/model constants
dumbbell committed rGa68dcfaf0236: linuxkpi: Define and fill `struct cpuinfo_x86->x86_stepping` (authored by dumbbell).
linuxkpi: Define and fill `struct cpuinfo_x86->x86_stepping`
dumbbell committed rG8aa685153bd6: linuxkpi: Add const qualifier to `bitmap_weight()` 1st arg (authored by dumbbell).
linuxkpi: Add const qualifier to `bitmap_weight()` 1st arg
dumbbell committed rG272a12639440: linuxkpi: Define `struct vfsmount` in <linux/mount.h> (authored by dumbbell).
linuxkpi: Define `struct vfsmount` in <linux/mount.h>
Jun 20 2026
Jun 20 2026
dumbbell requested review of D57703: linuxkpi: Define `ULL()`.
dumbbell requested review of D57702: linuxkpi: Add <linux/cgroup_dmem.h>.
dumbbell requested review of D57701: linuxkpi: Add `kthread_run_worker()`.
dumbbell requested review of D57700: linuxkpi: Add x86 CPU ID matching functions and macros.
dumbbell requested review of D57699: linuxkpi: Defined more Intel vendor/family/model constants.
dumbbell requested review of D57698: linuxkpi: Define and fill `struct cpuinfo_x86->x86_stepping`.
dumbbell committed rGaf187b20cdb0: linuxkpi: Define `COUNT_ARGS()` and `CONCATENATE()` (authored by dumbbell).
linuxkpi: Define `COUNT_ARGS()` and `CONCATENATE()`
dumbbell committed rGc27779e0a954: linuxkpi: Change `strscpy()` and `strscpy_pad()` to make their `len` argument… (authored by dumbbell).
linuxkpi: Change `strscpy()` and `strscpy_pad()` to make their `len` argument…
linuxkpi: Add 'fd_empty()`
linuxkpi: Add `pm_resume_via_firmware()`
dumbbell committed rG53baadc2f615: linuxkpi: Define a bunch of constants in <acpi/video.h> (authored by dumbbell).
linuxkpi: Define a bunch of constants in <acpi/video.h>
dumbbell committed rG294553b022b1: linuxkpi: Define `__ATTR_RO_MODE()` and `__ATTR_RW_MODE()` (authored by dumbbell).
linuxkpi: Define `__ATTR_RO_MODE()` and `__ATTR_RW_MODE()`
sys: Add `isgraph()` to <sys/ctype.h>
Jun 15 2026
Jun 15 2026
Thanks for the explanation!
dumbbell accepted D57463: LinuxKPI: Create pm_runtime_resume_and_get function, used by new versions of amdgpu.
I agree with @bz about adding printed TODO when called. I’m still accepting this patch because it should be part of another review probably.
dumbbell added inline comments to D57463: LinuxKPI: Create pm_runtime_resume_and_get function, used by new versions of amdgpu.
dumbbell requested changes to D57465: LinuxKPI: Create `linux/util_macros.h`.
Jun 14 2026
Jun 14 2026
dumbbell added a comment to D57590: LinuxKPI: add KERNEL_VERSION() macro.
What are the use cases for this macro?
Instead of this hack around <linux/radix-tree.h> and <linux/xarray.h>, I implemented the following solution in drm-kmod:
https://github.com/freebsd/drm-kmod/pull/477
dumbbell requested review of D57586: linuxkpi: Alias `sd` field of `struct kobject`.
dumbbell requested review of D57584: linuxkpi: Define `COUNT_ARGS()` and `CONCATENATE()`.
dumbbell requested review of D57583: linuxkpi: Define `DEFINE_CLASS()` and `CLASS()`.
dumbbell requested review of D57582: linuxkpi: Add 'fd_empty()`.
dumbbell requested review of D57581: linuxkpi: Add const qualifier to `bitmap_weight()` 1st arg.
dumbbell requested review of D57580: linuxkpi: Add `pm_resume_via_firmware()`.
dumbbell requested review of D57579: linuxkpi: Add `usleep_range_state()`.
dumbbell requested review of D57578: sys: Add `isgraph()` to <sys/ctype.h>.
dumbbell requested review of D57577: linuxkpi: Add `to_acpi_device_node()` and `ACPI_COMPANION()`.
dumbbell requested review of D57576: linuxkpi: Add `acpi_video_get_edid()`.
dumbbell added a comment to D57463: LinuxKPI: Create pm_runtime_resume_and_get function, used by new versions of amdgpu.
This patch is required for the update of DRM drivers to Linux 6.13.
dumbbell requested review of D57575: linuxkpi: Define a bunch of constants in <acpi/video.h>.
dumbbell requested review of D57574: linuxkpi: Define `__ATTR_RO_MODE()` and `__ATTR_RW_MODE()`.
dumbbell requested review of D57573: linuxkpi: Add `pci_map_rom()` and `pci_unmap_rom()`.
dumbbell requested review of D57572: linuxkpi: Define `struct vfsmount` in <linux/mount.h>.
dumbbell requested review of D57571: linuxkpi: Add missing includes leading to <linux/kconfig.h>.
dumbbell updated the summary of D57570: linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>.
dumbbell requested changes to D57465: LinuxKPI: Create `linux/util_macros.h`.
for_each_if() already exists in the DRM drivers. It was moved to <linux/util_macros.h> in Linux 6.15 (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b2108fc82a0acda34388bff3e3ee3544013b1623). Therefore it will need to be wrapped with:
Jun 11 2026
Jun 11 2026
dumbbell committed R11:29f35cb88175: graphics/drm-66-kmod: Fix build with llvm 21 (authored by bapt).
graphics/drm-66-kmod: Fix build with llvm 21
dumbbell committed R11:eeb0a6fe4942: graphics/drm-61-kmod: Fix build of intel bits on 15.0-RELEASE (authored by milios_ccsys.com).
graphics/drm-61-kmod: Fix build of intel bits on 15.0-RELEASE
dumbbell committed R11:71148fc853b9: graphics/drm-66-kmod: Fix build of intel bits on 15.0-RELEASE (authored by milios_ccsys.com).
graphics/drm-66-kmod: Fix build of intel bits on 15.0-RELEASE
dumbbell committed R11:e3b840fedf54: graphics/nvidia-drm-*-kmod*: Bump PORTREVISION after… (authored by dumbbell).
graphics/nvidia-drm-*-kmod*: Bump PORTREVISION after…
dumbbell committed R11:265b8b5f5f81: graphics/drm-*-kmod, graphics/nvidia-drm-*-kmod: Update DRM drivers (authored by dumbbell).
graphics/drm-*-kmod, graphics/nvidia-drm-*-kmod: Update DRM drivers
dumbbell committed R11:5519ad95e498: graphics/drm-66-kmod: Update to latest version (authored by manu).
graphics/drm-66-kmod: Update to latest version
dumbbell committed R11:a538ec1909d1: graphics/drm-61-kmod: Update to latest version (authored by manu).
graphics/drm-61-kmod: Update to latest version
graphics/drm-612-kmod: new port
graphics/piglit: Update to 20260521
dumbbell committed R11:5939c6e5b2e0: graphics/nvidia-drm-*-kmod*: Bump PORTREVISION after… (authored by dumbbell).
graphics/nvidia-drm-*-kmod*: Bump PORTREVISION after…
Jun 10 2026
Jun 10 2026
dumbbell committed R11:e50c876e295a: graphics/drm-*-kmod, graphics/nvidia-drm-*-kmod: Update DRM drivers (authored by dumbbell).
graphics/drm-*-kmod, graphics/nvidia-drm-*-kmod: Update DRM drivers