User Details
- User Since
- May 27 2014, 10:08 AM (635 w, 31 m)
Sun, Jul 26
Sat, Jul 25
this is 6.14? So there's a new case that we didn't know about during the time we fixed master (before/after 6.12?) or had I missed this before?
Oops, I forgot to mark the review as needing changes.
I made an inline comment in linux_free_page(): there is a refcounting issue vs. the call to lkpi_page_unset_vm_page().
The patch looks good to me.
Wed, Jul 15
Indeed, I kind of remembered something similar but a quick search didn’t return this review. Thank you!
Tue, Jul 14
Address comment from @emaste by uncommenting the include of <linux/plist.h> and adding it as a dummy header.
Sun, Jul 12
Sat, Jul 11
Thu, Jul 9
This patch looks good to me. I just noted one comment which is unclear to me.
Wed, Jul 8
Fix typo, reported by @emaste
Jun 24 2026
Jun 20 2026
Jun 15 2026
Thanks for the explanation!
I agree with @bz about adding printed TODO when called. I’m still accepting this patch because it should be part of another review probably.
Jun 14 2026
What are the use cases for this macro?
Instead of this hack around <linux/radix-tree.h> and <linux/xarray.h>, I implemented the following solution in drm-kmod:
https://github.com/freebsd/drm-kmod/pull/477
This patch is required for the update of DRM drivers to Linux 6.13.
for_each_if() already exists in the DRM drivers. It was moved to <linux/util_macros.h> in Linux 6.15 (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b2108fc82a0acda34388bff3e3ee3544013b1623). Therefore it will need to be wrapped with:
