User Details
- User Since
- May 27 2014, 10:08 AM (639 w, 6 d)
Sun, Aug 16
I didn't work on the implementation of dma-buf for FreeBSD. We have this BSD-licensed implementation in drm-kmod right now and we can surely move that to base. I find it receives changes infrequently in Linux, so hopefully, that shouldn't be something that slows down or interferes with making a given version of drm-kmod compatible with multiple versions of FreeBSD.
Sat, Aug 15
Mon, Aug 10
Jul 26 2026
Jul 25 2026
this is 6.14? So there's a new case that we didn't know about during the time we fixed master (before/after 6.12?) or had I missed this before?
Oops, I forgot to mark the review as needing changes.
I made an inline comment in linux_free_page(): there is a refcounting issue vs. the call to lkpi_page_unset_vm_page().
The patch looks good to me.
Jul 15 2026
Indeed, I kind of remembered something similar but a quick search didn’t return this review. Thank you!
Jul 14 2026
Address comment from @emaste by uncommenting the include of <linux/plist.h> and adding it as a dummy header.
Jul 12 2026
Jul 11 2026
Jul 9 2026
This patch looks good to me. I just noted one comment which is unclear to me.
Jul 8 2026
Fix typo, reported by @emaste
Jun 24 2026
Jun 20 2026
Jun 15 2026
Thanks for the explanation!
I agree with @bz about adding printed TODO when called. I’m still accepting this patch because it should be part of another review probably.
Jun 14 2026
What are the use cases for this macro?
Instead of this hack around <linux/radix-tree.h> and <linux/xarray.h>, I implemented the following solution in drm-kmod:
https://github.com/freebsd/drm-kmod/pull/477
