Page MenuHomeFreeBSD

linuxkpi: Fix uses of `pmap_change_attr()`
ClosedPublic

Authored by dumbbell on Oct 2 2023, 10:13 PM.
Tags
None
Referenced Files
F135263516: D42053.diff
Sat, Nov 8, 2:39 AM
Unknown Object (File)
Mon, Nov 3, 2:00 AM
Unknown Object (File)
Mon, Nov 3, 2:00 AM
Unknown Object (File)
Mon, Nov 3, 1:59 AM
Unknown Object (File)
Mon, Nov 3, 1:59 AM
Unknown Object (File)
Mon, Oct 20, 1:01 AM
Unknown Object (File)
Mon, Oct 13, 7:11 AM
Unknown Object (File)
Mon, Oct 13, 7:11 AM

Details

Summary

Why

This function takes an offset and a length as argument, not a physical address and a number of pages.

This misuse caused the set_memory_*() and arch_io_reserve_memtype_wc() functions to return EINVAL.

Another problem was the fact that they returned errors as a positive integer, whereas Linux uses negative integers.

How

Physical addresses and number of pages are converted to offset+length in the set_memory_*() functions.

arch_io_reserve_memtype_wc() now calls pmap_change_attr() directly instead of using set_memory_wc().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable