Page MenuHomeFreeBSD

linuxkpi: Fix uses of `pmap_change_attr()`
ClosedPublic

Authored by dumbbell on Oct 2 2023, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 7:11 AM
Unknown Object (File)
Mon, Oct 13, 7:11 AM
Unknown Object (File)
Mon, Oct 13, 7:11 AM
Unknown Object (File)
Sun, Oct 12, 7:00 PM
Unknown Object (File)
Mon, Oct 6, 10:46 AM
Unknown Object (File)
Aug 2 2025, 11:09 AM
Unknown Object (File)
Jul 28 2025, 2:42 PM
Unknown Object (File)
Jul 27 2025, 4:25 AM

Details

Summary

Why

This function takes an offset and a length as argument, not a physical address and a number of pages.

This misuse caused the set_memory_*() and arch_io_reserve_memtype_wc() functions to return EINVAL.

Another problem was the fact that they returned errors as a positive integer, whereas Linux uses negative integers.

How

Physical addresses and number of pages are converted to offset+length in the set_memory_*() functions.

arch_io_reserve_memtype_wc() now calls pmap_change_attr() directly instead of using set_memory_wc().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable