ClosedPublic
Actions

Authored by dumbbell on Dec 13 2023, 11:56 AM.

Details

Reviewers

Commits

rG843107faca66: linuxkpi: Move `invalidate_mapping_pages()` to <linux/pagemap.h>
rG4e0d3f7b3c32: linuxkpi: Move `invalidate_mapping_pages()` to <linux/pagemap.h>

Summary

Why

This is consistent with Linux.

How

The definition is moved from <linux/shmem_fs.h> to <linux/pagemap.h> and the latter is included from the former. This is how it is done on Linux.

Prototypes are also expanded with argument names. I got a build failure in the DRM 5.18 drivers because the compiler considered that the pgoff_t argument was there twice.

This is part of the update of the DRM drivers to Linux 5.18.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dumbbell created this revision.Dec 13 2023, 11:56 AM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptDec 13 2023, 11:56 AM

dumbbell requested review of this revision.Dec 13 2023, 11:56 AM

manu accepted this revision.Dec 13 2023, 1:52 PM

This revision is now accepted and ready to land.Dec 13 2023, 1:52 PM

Closed by commit rG4e0d3f7b3c32: linuxkpi: Move `invalidate_mapping_pages()` to <linux/pagemap.h> (authored by dumbbell). · Explain WhyDec 13 2023, 6:29 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG4e0d3f7b3c32: linuxkpi: Move `invalidate_mapping_pages()` to <linux/pagemap.h>.

wulf added a commit: rG843107faca66: linuxkpi: Move `invalidate_mapping_pages()` to <linux/pagemap.h>.Feb 17 2024, 9:33 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

pagemap.h

6 lines

shmem_fs.h

15 lines

Diff 131337

View Options

sys/compat/linuxkpi/common/include/linux/pagemap.h