Page MenuHomeFreeBSD
Differential D42056

vt(4): Skip vt_flush() for nested panics
ClosedPublic
Actions

Authored by dumbbell on Oct 2 2023, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 2:43 PM
Unknown Object (File)
Wed, May 1, 12:47 AM
Unknown Object (File)
Wed, May 1, 12:47 AM
Unknown Object (File)
Mon, Apr 29, 3:01 AM
Unknown Object (File)
Mon, Apr 29, 12:14 AM
Unknown Object (File)
Thu, Apr 25, 10:29 PM
Unknown Object (File)
Thu, Apr 25, 12:43 AM
Unknown Object (File)
Thu, Apr 25, 12:42 AM
View All 19 Files
Subscribers
imp

Details

Reviewers
manu
Commits
rG608b14876011: vt(4): Skip vt_flush() for nested panics
rG049e3fba04e8: vt(4): Skip vt_flush() for nested panics
Summary

Why

If there is a problem with DRM drivers or in their integration with vt(4) and displaying something on the console triggers a panic, there is a high chance that displaying that panic will trigger another one, recursively.

How

If vt_flush() is called and it detects is is called resursively from another panic, it return immediately, doing nothing, to avoid the risk of triggering another panic.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell created this revision.Oct 2 2023, 10:18 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 2 2023, 10:18 PM
dumbbell requested review of this revision.Oct 2 2023, 10:18 PM
dumbbell edited the summary of this revision. (Show Details)Oct 2 2023, 10:21 PM
manu added inline comments.Oct 4 2023, 5:35 AM
sys/dev/vt/vt_core.c
1489

Extra blank line.

3117

Is this supposed to be part of this patch ?

dumbbell updated this revision to Diff 130514.Nov 24 2023, 4:16 PM
dumbbell mentioned this in D42750: vt(4): Skip vt_window_switch() for nested panics.

Address @manu comments.

dumbbell marked 2 inline comments as done.Nov 24 2023, 4:18 PM
dumbbell added inline comments.
sys/dev/vt/vt_core.c
1489

Removed extra blank line.

3117

Removed lines that were not supposed to be in the patch.

dumbbell marked 2 inline comments as done.Nov 24 2023, 4:18 PM
manu accepted this revision.Nov 24 2023, 4:21 PM
This revision is now accepted and ready to land.Nov 24 2023, 4:21 PM
Closed by commit rG049e3fba04e8: vt(4): Skip vt_flush() for nested panics (authored by dumbbell). · Explain WhyNov 24 2023, 5:32 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rG049e3fba04e8: vt(4): Skip vt_flush() for nested panics.
wulf added a commit: rG608b14876011: vt(4): Skip vt_flush() for nested panics.Feb 17 2024, 9:32 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
15 lines

Diff 130531

View Options

sys/dev/vt/vt_core.c

Loading...