Page MenuHomeFreeBSD
Feed Advanced Search

Mon, Feb 26

tsoome committed rG1b3f4ccb7dd8: loader: we can only env_discard() existing variable (authored by tsoome).
loader: we can only env_discard() existing variable
Mon, Feb 26, 12:59 PM
tsoome closed D44083: loader: we can only env_discard() existing variable.
Mon, Feb 26, 12:59 PM

Sun, Feb 25

tsoome requested review of D44083: loader: we can only env_discard() existing variable.
Sun, Feb 25, 10:41 PM

Sat, Feb 24

tsoome accepted D44057: kboot: Centralize ldscript addition.
Sat, Feb 24, 8:59 PM
tsoome accepted D44058: loader/powerpc: Share ldscript.
Sat, Feb 24, 8:59 PM
tsoome accepted D44059: loader/uboot: Move to foo.ldconfig.
Sat, Feb 24, 8:58 PM
tsoome accepted D44060: loader/kboot: simplify linker set inclusion a little.
Sat, Feb 24, 8:58 PM
tsoome accepted D44056: loader: Move ldscripts to match more standard practices.
Sat, Feb 24, 8:56 PM
tsoome accepted D44061: loader/efi: Linker sets not needed..
Sat, Feb 24, 6:52 PM
tsoome accepted D44062: loader/efi: Use unique linker set for lua.
Sat, Feb 24, 6:51 PM
tsoome accepted D44063: loader/ficl: Rename the ficl compile set to X4th_compile_set.
Sat, Feb 24, 6:51 PM
tsoome accepted D44064: loader/efi: Only include interpreter's linker script.
Sat, Feb 24, 6:50 PM

Wed, Feb 21

tsoome accepted D44008: loader/efi: Make gcc friendlier by move md_dev.
Wed, Feb 21, 7:29 AM
tsoome accepted D44006: loader: Retire CTASSERT.
Wed, Feb 21, 7:27 AM

Thu, Feb 15

tsoome added a comment to D43914: loader: Simplify build a little.
In D43914#1001826, @imp wrote:

alloca or local variable does allocate from stack (which may be in collision with bss), the opther option there to get low memory allocation is to use bio_alloc() and bio_free().

Pnp nodes are like 32 bytes... and must be in the lower MB.

Thu, Feb 15, 2:30 PM
tsoome accepted D43914: loader: Simplify build a little.

alloca or local variable does allocate from stack (which may be in collision with bss), the opther option there to get low memory allocation is to use bio_alloc() and bio_free().

Thu, Feb 15, 8:21 AM

Fri, Feb 9

tsoome accepted D43701: loader: Document the lua loader table..
Fri, Feb 9, 9:37 PM

Feb 3 2024

tsoome accepted D43714: loader: For EFI, if we don't have ConOut, try ConIn.
Feb 3 2024, 6:28 AM

Jan 20 2024

tsoome accepted D43522: firmware: Allow binary files to be loaded by /boot/loader.
Jan 20 2024, 7:07 AM

Nov 25 2023

tsoome added inline comments to D42774: pmbr: Only load the first 545k rather than error out.
Nov 25 2023, 7:07 PM
tsoome accepted D42774: pmbr: Only load the first 545k rather than error out.
Nov 25 2023, 6:59 PM

Jun 2 2023

tsoome added a comment to D40389: stand/boot1.efi: use the bootonce dataset as root dataset.

The trick question there is, the bootonce property is supposed to have generic boot descriptor, it does not have to be just zfs dataset name.... of course, if you have pools, then most likely you only do use zfs datasets.

Jun 2 2023, 11:47 AM
tsoome accepted D40388: stand/loader.efi: read zfs bootonce attribute before checking currdev.
Jun 2 2023, 11:42 AM

Jun 1 2023

tsoome requested review of D40375: loader: BIOS loader should not build framebuffer support by default.
Jun 1 2023, 11:47 AM

May 23 2023

tsoome accepted D40220: stand/efi/eficom: better handling of absent device.
May 23 2023, 7:40 AM
tsoome accepted D40219: stand/efi/smbios: Move detection of smbios earlier..

hm, do we actually need this preprocessor #if statement?

May 23 2023, 7:36 AM

May 13 2023

tsoome committed rGf2b3bf5c4d4a: libefi: add efi_devpath_next_instance() (authored by tsoome).
libefi: add efi_devpath_next_instance()
May 13 2023, 12:21 PM
tsoome closed D40081: libefi: add efi_devpath_next_instance().
May 13 2023, 12:21 PM

May 12 2023

tsoome requested review of D40081: libefi: add efi_devpath_next_instance().
May 12 2023, 4:47 PM

May 9 2023

tsoome accepted D40017: md5: Fix input error check..
May 9 2023, 10:34 AM
tsoome accepted D40009: stand: eficom: Don't preemtively assume flow control.
May 9 2023, 9:04 AM
tsoome accepted D40008: stand: eficom : remove unused ignore_cd.
May 9 2023, 9:03 AM
tsoome added inline comments to D40017: md5: Fix input error check..
May 9 2023, 8:29 AM

May 8 2023

tsoome accepted D40007: stand: Move eficom to libefi.
May 8 2023, 8:52 PM
tsoome added a comment to D40011: efi: mark as broken on i386.

Yeah. In the past I would have argued that we should work on support it (back when Intel had viable contemporary 32-bit hw and a 32-bit Tianocore to go with it) but at this point i386's future overall is not clear and we're not going to put effort into this.

May 8 2023, 8:45 PM
tsoome accepted D40011: efi: mark as broken on i386.
May 8 2023, 8:35 PM
tsoome accepted D40012: stand/efi: Retire i386 support.
May 8 2023, 8:34 PM

Apr 26 2023

tsoome committed rG795497bf3d2c: pxeboot: bugs in pxe.h (authored by tsoome).
pxeboot: bugs in pxe.h
Apr 26 2023, 1:34 PM
tsoome closed D39799: pxeboot: bugs in pxe.h.
Apr 26 2023, 1:34 PM

Apr 25 2023

tsoome added a comment to D39799: pxeboot: bugs in pxe.h.
In D39799#906388, @imp wrote:

so how was all this working before?
or is SEGDESC_t not all that important?

Apr 25 2023, 10:43 PM
tsoome requested review of D39799: pxeboot: bugs in pxe.h.
Apr 25 2023, 12:13 PM

Apr 12 2023

tsoome accepted D39412: stand/boot1.efi: Implement bootonce for ZFS.
Apr 12 2023, 6:22 AM
tsoome accepted D39411: stand/zfs: Refactor zfs_get_bootonce.
Apr 12 2023, 6:21 AM
tsoome accepted D39410: stand/zfs: Refactor zfs_set_bootenv.
Apr 12 2023, 6:21 AM
tsoome accepted D39409: stand/zfs: Refactor zfs_get_bootenv.
Apr 12 2023, 6:20 AM
tsoome accepted D39407: stand/boot1.efi: Allow modules to add env variables.
Apr 12 2023, 6:18 AM
tsoome accepted D39408: stand/zfs: Move spa_find_by_dev from zfsimpl.c to zfs.c.
Apr 12 2023, 6:17 AM
tsoome accepted D39414: stand/userboot: Simplify code.
Apr 12 2023, 6:16 AM
tsoome accepted D39415: stand/efi: Simplify code here.
Apr 12 2023, 6:15 AM
tsoome accepted D39416: stand/kboot: Simplify.
Apr 12 2023, 6:13 AM

Mar 30 2023

tsoome added a comment to D39323: vt: avoid using a spinlock.
In D39323#895597, @manu wrote:

I think doing a functional function trace is mandatory before this commit, seeing what code is calling into what code, and what locks are in use.

If you need help ask, @zlei .

What @gbe reports clearly shows we can do better than just pushing changes and waiting for others to fix them.

--HPS

Nobody here said anything about "waiting for others to fix them". I hope that you understand that we cannot test every configuration possible.
And, sure, since now we have a report that it doesn't work on hyper-v nothing will be commited before the problem is understood and fixed.

Mar 30 2023, 11:33 AM

Mar 29 2023

tsoome accepted D39323: vt: avoid using a spinlock.
Mar 29 2023, 3:20 PM

Mar 8 2023

tsoome accepted D38977: Random failure to read dos file in bootloader.
Mar 8 2023, 10:32 AM

Feb 21 2023

tsoome accepted D38600: loader: Add support for booting from a ZFS snapshot.
Feb 21 2023, 10:39 PM

Feb 10 2023

tsoome committed rG4b2322bba19d: efiserialio: use port settings (sio->Mode) for initial setup (authored by tsoome).
efiserialio: use port settings (sio->Mode) for initial setup
Feb 10 2023, 7:39 AM

Feb 3 2023

tsoome accepted D38254: kboot: bi_loadsmap for amd64.
Feb 3 2023, 12:58 PM
tsoome committed rGa1f8a0c793c6: efiserialio: use port settings (sio->Mode) for initial setup (authored by tsoome).
efiserialio: use port settings (sio->Mode) for initial setup
Feb 3 2023, 10:02 AM
tsoome accepted D38252: kboot: Define bi_loadsmap for loading memory maps.
Feb 3 2023, 9:30 AM
tsoome accepted D38251: kboot: Call enumerate_memory_arch().
Feb 3 2023, 9:29 AM
tsoome added inline comments to D38248: kboot: Add powerpc stub for enumerate_memory_arch().
Feb 3 2023, 9:28 AM
tsoome accepted D38317: test: Add fstab to all ufs images.
Feb 3 2023, 9:26 AM

Feb 2 2023

tsoome accepted D38259: kboot: Improve amd64 booting.
Feb 2 2023, 10:49 PM
tsoome accepted D38253: kboot: Powerpc provide bi_loadsmap.
Feb 2 2023, 10:21 PM
tsoome accepted D38258: kboot: aarch64 trampoline implementation.
Feb 2 2023, 10:19 PM
tsoome accepted D38264: kboot: Try to read UEFI memory from physical memory on aarch64.
Feb 2 2023, 10:06 PM
tsoome requested changes to D38264: kboot: Try to read UEFI memory from physical memory on aarch64.
Feb 2 2023, 10:00 PM
tsoome accepted D38319: kboot: Probe all disks and partitions for a kernel.
Feb 2 2023, 9:49 PM
tsoome accepted D38247: kboot: MI part of the memory enumeration code.
Feb 2 2023, 8:55 PM
tsoome accepted D38262: kboot: Enable for aarch64.
Feb 2 2023, 8:48 PM
tsoome accepted D38357: kboot: Assert errno is negative.
Feb 2 2023, 8:37 PM
tsoome accepted D38318: kboot: Fix hostdisk fmtdev.
Feb 2 2023, 4:46 PM
tsoome accepted D38315: kboot: Keep track of what's used in the segment.
Feb 2 2023, 4:44 PM
tsoome accepted D38314: kboot: Allocate a really big first segment.
Feb 2 2023, 4:40 PM
tsoome accepted D38310: kboot: Remove externs.
Feb 2 2023, 2:15 PM
tsoome accepted D38313: kboot: space_avail -- how much space exists from 'start' to end of segment.

nr_seg is int, but it can not get to negative, can it?

Feb 2 2023, 2:14 PM
tsoome accepted D38350: stand: share bootinfo.c between EFI and KBOOT.

Maybe it should be moved to common?

Feb 2 2023, 12:31 PM
tsoome accepted D38309: kboot: Add parsing of /proc/iomem into seg.c.
Feb 2 2023, 12:28 PM

Jan 24 2023

tsoome added inline comments to D36052: Enabling FreeBSD on ARM64 Hyper-V.
Jan 24 2023, 4:57 PM

Jan 18 2023

tsoome added a comment to D36052: Enabling FreeBSD on ARM64 Hyper-V.

Getting rid of default 9600 baud serial console is a good thing, we'll need to make sure this is widely documented in release notes etc.
See also D36295

Jan 18 2023, 1:11 PM

Jan 13 2023

tsoome added inline comments to D38041: stand/ofw: dev can't be NULL here.
Jan 13 2023, 9:30 PM
tsoome accepted D38043: stand: Separate base and cli parts of nvstore.

Nice, thanks!:)

Jan 13 2023, 5:51 PM

Jan 4 2023

tsoome accepted D37931: stand/efi/loader/copy.c: make sure kernel image is executable.
Jan 4 2023, 10:18 PM

Dec 16 2022

tsoome accepted D36052: Enabling FreeBSD on ARM64 Hyper-V.

thanks!

Dec 16 2022, 9:37 AM
tsoome added a comment to D36052: Enabling FreeBSD on ARM64 Hyper-V.

small nits still, but good otherwise, I assume, this code does work as expected now?

Dec 16 2022, 8:29 AM

Dec 15 2022

tsoome added a comment to D36052: Enabling FreeBSD on ARM64 Hyper-V.

Setting other values than default values cause hang during comc_setup. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266248

Dec 15 2022, 8:57 PM

Nov 18 2022

tsoome accepted D37438: arm64/pmap: freed only used for PV_STATS.

Seems reasonable.

Nov 18 2022, 5:00 PM

Oct 13 2022

tsoome accepted D36975: loader: fix elf lookup_symbol type filtering.
Oct 13 2022, 9:47 AM

Oct 11 2022

tsoome accepted D36927: sys/_pv_entry.h: Include sys/param.h.
Oct 11 2022, 2:29 PM

Oct 10 2022

tsoome accepted D36926: hwpmc: Define full set of Armv8.0 events.
Oct 10 2022, 4:06 PM
tsoome accepted D36925: hwpmc: Move DMC-620 and CMN-600 events to allow for full Armv8.0 space.

LGTM, thanks!

Oct 10 2022, 4:06 PM

Sep 20 2022

tsoome added a comment to D34479: Add support for custom keyboard layout when GELI asks for a passphrase.
In D34479#831843, @imp wrote:

Some general comments...

The style of indented #if isn't what we do in FreeBSD. Code should be indented as if the #if isn't present, and the # directives should be in column 1.
We don't add extra spaces around the ('s, as I've highlighted
We don't do if (foo) bar; on one line.
logical operators are at the end of the line, not the start of the continuation.

It's an interesting notion... You'll likely want to do something similar to the EFI boot loader as well.

Sep 20 2022, 9:02 PM ยท x86

Sep 14 2022

tsoome accepted D36568: stand: use archsw.arch_copyin instead of i386_copyin.
Sep 14 2022, 8:34 PM
tsoome accepted D36575: stand: Allocate bootinfo rather than have it be static.
Sep 14 2022, 8:32 PM
tsoome accepted D36576: stand/geli: Allocate saved_keys instead of making it static.
Sep 14 2022, 8:29 PM

Sep 13 2022

tsoome accepted D36544: i386: Mark the obsolete fields in bootinfo with _was_.
Sep 13 2022, 6:31 AM
tsoome accepted D36144: stand: Move amd64 tramp page table from .data to heap.
Sep 13 2022, 6:30 AM

Sep 8 2022

tsoome accepted D36490: stand: i386: take into account disk sector size for blk calculation.

Thanks!

Sep 8 2022, 6:54 AM

Sep 5 2022

tsoome committed rG1f5679569dd4: libpmc: pmc_init() should avoid overflowing pmc_class_table (authored by tsoome).
libpmc: pmc_init() should avoid overflowing pmc_class_table
Sep 5 2022, 12:40 PM
tsoome closed D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.
Sep 5 2022, 12:39 PM

Aug 31 2022

tsoome added inline comments to D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.
Aug 31 2022, 4:16 PM