Page MenuHomeFreeBSD

stand: share bootinfo.c between EFI and KBOOT
ClosedPublic

Authored by imp on Feb 1 2023, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 3 2024, 8:35 PM
Unknown Object (File)
Jan 3 2024, 8:35 PM
Unknown Object (File)
Jan 3 2024, 8:35 PM
Unknown Object (File)
Jan 3 2024, 8:31 PM
Unknown Object (File)
Jan 3 2024, 6:56 PM
Unknown Object (File)
Dec 22 2023, 11:34 PM
Unknown Object (File)
Nov 18 2023, 2:26 AM
Unknown Object (File)
Nov 18 2023, 12:28 AM
Subscribers

Details

Summary

Connect efi's bootinfo.c to the kboot build, and adjust to use
the kboot specific routines.

The getrootmount() call is independent of EFI. Remove ifdefs so it's
called for kboot too.

The differences between the kboot and efi bootinfo.c files are now tiny.
This could use some more refactoring, but this is a working checkpoint.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 1 2023, 11:15 PM

rebase / refactor / redo

Maybe it should be moved to common?

This revision is now accepted and ready to land.Feb 2 2023, 12:31 PM

Maybe it should be moved to common?

No. Not yet. It can't be used for anything else.

In D38350#871512, @imp wrote:

Maybe it should be moved to common?

No. Not yet. It can't be used for anything else.

We have three different ones of these, reflecting a diverse history of FreeBSD... Refactoring them to be one common thing should be undertaken, but we're not yet there. This is one step in that process.

This revision was automatically updated to reflect the committed changes.