stand: only compute symidx on x86
ClosedPublic
Actions

Authored by imp on Jan 29 2023, 3:14 PM.

Tags

None

Referenced Files

	F170654050: D38246.diff
	Sat, Sep 5, 8:17 PM

	Unknown Object (File)
	Thu, Sep 3, 12:45 PM

	Unknown Object (File)
	Wed, Aug 26, 10:35 PM

	Unknown Object (File)
	Wed, Aug 19, 5:28 AM

	Unknown Object (File)
	Wed, Aug 12, 5:30 AM

	Unknown Object (File)
	Sat, Aug 8, 3:03 PM

	Unknown Object (File)
	Fri, Aug 7, 10:17 PM

	Unknown Object (File)
	Fri, Aug 7, 6:57 PM

View All Files

Subscribers

dab

Details

Reviewers

kevans
tsoome
manu

Commits

rGce18e1939438: stand: only compute symidx on x86

Summary

We only use symidx on x86, so only compute it on x86 to fix a set but
not used warning on aarch64.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 29 2023, 3:14 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 29 2023, 3:14 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jan 29 2023, 3:14 PM

Harbormaster completed remote builds in B49288: Diff 116004.Jan 29 2023, 3:14 PM

imp added a child revision: D38247: kboot: MI part of the memory enumeration code.Jan 29 2023, 3:14 PM

rebase / refactor / redo

Harbormaster completed remote builds in B49437: Diff 116242.Feb 1 2023, 11:23 PM

kevans accepted this revision.Feb 2 2023, 3:07 AM

This revision is now accepted and ready to land.Feb 2 2023, 3:07 AM

Closed by commit rGce18e1939438: stand: only compute symidx on x86 (authored by imp). · Explain WhyFeb 2 2023, 8:07 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGce18e1939438: stand: only compute symidx on x86.

Revision Contents
Changeset List

Path

Size

stand/

common/

reloc_elf.c

9 lines

Diff 116352

View Options

stand: only compute symidx on x86ClosedPublicActions