HomeFreeBSD
Diffusion FreeBSD src repository a9e062971923

gh-bc: don't force CFLAGS to -O0 -g
Auditeda9e062971923
Actions

Description

gh-bc: don't force CFLAGS to -O0 -g

Otherwise, CFLAGS passed in via bsd.sys.mk or the user's environment are
not respected, and this leads to link errors on riscv64sf.

Details

Auditors
se
Provenance
dimAuthored on Feb 2 2023, 6:20 PM
Parents
rG79f7745c098a: ipfilter: Fix use after free on packet with broken lengths
Branches
Unknown
Tags
Unknown

Event Timeline

dim committed rGa9e062971923: gh-bc: don't force CFLAGS to -O0 -g (authored by dim).Feb 2 2023, 6:20 PM
Herald added an auditor: se. ยท View Herald TranscriptFeb 2 2023, 6:21 PM
This commit now requires audit.Feb 2 2023, 6:21 PM
se accepted this commit.Feb 3 2023, 6:46 AM
se added a subscriber: se.

Passing the options "-O0 -g" was a relict from testing (as indicated by the lack of indentation) and could have been deleted instead of commenting them out.
I'll remove the line after 13.2 has been branched.

All concerns with this commit have now been addressed.Feb 3 2023, 6:46 AM

Changes (1)

PathSize
usr.bin/
gh-bc/

rGa9e062971923

View Options

usr.bin/gh-bc/Makefile

Loading...