Details

Reviewers

kevans
tsoome
manu
andrew

Commits

rGdfcca210755e: kboot: aarch64 trampoline implementation

Summary

Update exec.c (copyied from efi/loader/arch/arm64/exec.c) to allow
execution of aarch64 kernels. This includes a new trampile code that
handles copying the UEFI memory map, if available from the Linux FDT
provided PA. This is a complete implementation now, able to boot from
the LinuxBoot environment on an aarch64 server that onyl offers
LinuxBoot (though a workaround for the gitv3 inability to re-init is not
upstream in FreeBSD yet).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 29 2023, 3:15 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 29 2023, 3:15 PM

Herald added subscribers: dab, emaste, andrew. · View Herald Transcript

imp requested review of this revision.Jan 29 2023, 3:15 PM

imp added a parent revision: D38257: kboot: Connect bootinfo.c to the build.

Harbormaster completed remote builds in B49300: Diff 116016.Jan 29 2023, 3:15 PM

imp added a child revision: D38259: kboot: Improve amd64 booting.Jan 29 2023, 3:16 PM

gbe added a subscriber: gbe.Jan 29 2023, 5:57 PM

gbe added inline comments.

stand/kboot/arch/aarch64/tramp.S
36–37	Linux

Fix linux spelling, per review, and also make the comment make more sense.

Harbormaster completed remote builds in B49317: Diff 116033.Jan 29 2023, 6:36 PM

imp added a parent revision: D38256: kboot: Add aarch64 fdt fixup.Feb 1 2023, 11:17 PM

rebase / refactor / redo

Harbormaster completed remote builds in B49453: Diff 116259.Feb 1 2023, 11:25 PM

trampile -> trampoline, onyl -> only, gitv3 -> gicv3 in commit message

stand/kboot/arch/aarch64/tramp.S
46	`installs` or `sets up,` probably not both?

This revision is now accepted and ready to land.Feb 2 2023, 3:41 AM

fix spelling issues... also commit message fixed locally.

This revision now requires review to proceed.Feb 2 2023, 3:56 AM

Harbormaster completed remote builds in B49472: Diff 116295.Feb 2 2023, 3:56 AM

andrew accepted this revision.Feb 2 2023, 2:39 PM

andrew added inline comments.

stand/kboot/arch/aarch64/exec.c
59	This is likely to fail on a non-4k kernel. Should be ok for an initial port, but is something to be aware about.
184	Does it need to be physically contiguous? If so malloc might not if it spans a page boundary.
stand/kboot/arch/aarch64/tramp.S
78–79	You could make this an `ldp` instruction
85–86	And this

This revision is now accepted and ready to land.Feb 2 2023, 2:39 PM

ldr -> ldp, per andyt

This revision now requires review to proceed.Feb 2 2023, 6:06 PM

Harbormaster completed remote builds in B49483: Diff 116349.Feb 2 2023, 6:06 PM

thanks for the assembler tips

stand/kboot/arch/aarch64/exec.c
59	yea, we just use it for the trampoline, which we put AFTER the kernel, and its size doesn't really matter that much.. I'll keep this in mind in the future and come up with a better way to deal with.