Page MenuHomeFreeBSD

fattime: fix fattime to timespec conversion of dates beyond 2106-02-06
ClosedPublic

Authored by jeffpc_josefsipek.net on Apr 12 2024, 2:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 18, 12:11 PM
Unknown Object (File)
Wed, Aug 12, 2:00 PM
Unknown Object (File)
Tue, Aug 11, 4:49 PM
Unknown Object (File)
Mon, Aug 10, 10:47 PM
Unknown Object (File)
Sat, Aug 8, 5:27 AM
Unknown Object (File)
Wed, Aug 5, 2:02 PM
Unknown Object (File)
Sun, Aug 2, 4:42 AM
Unknown Object (File)
Thu, Jul 30, 4:16 PM
Subscribers

Details

Summary

It turns out that the only conversion issue was in fattime2timespec, where
multiplying the number of seconds in a day by the number of days overflowed
32-bit unsigned int for dates beyond 2106-02-07 06:28:15.

Casting one of the multiplicands as time_t forces a 64-bit multiplication on
systems where time_t is 64-bits and produces no binary changes on the one
remaining system with 32-bit time_t (namely i386).

Since the code is now tested & fixed, this change removes the fixme comments.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable