Page MenuHomeFreeBSD

fattime: fix fattime to timespec conversion of dates beyond 2106-02-06
ClosedPublic

Authored by jeffpc_josefsipek.net on Apr 12 2024, 2:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 26, 7:28 AM
Unknown Object (File)
Sat, Oct 25, 7:36 AM
Unknown Object (File)
Sun, Oct 19, 11:30 PM
Unknown Object (File)
Wed, Oct 15, 3:43 AM
Unknown Object (File)
Sep 28 2025, 5:22 AM
Unknown Object (File)
Sep 13 2025, 1:16 PM
Unknown Object (File)
Sep 12 2025, 3:23 PM
Unknown Object (File)
Sep 8 2025, 3:19 AM
Subscribers

Details

Summary

It turns out that the only conversion issue was in fattime2timespec, where
multiplying the number of seconds in a day by the number of days overflowed
32-bit unsigned int for dates beyond 2106-02-07 06:28:15.

Casting one of the multiplicands as time_t forces a 64-bit multiplication on
systems where time_t is 64-bits and produces no binary changes on the one
remaining system with 32-bit time_t (namely i386).

Since the code is now tested & fixed, this change removes the fixme comments.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable