Page MenuHomeFreeBSD

fattime: fix fattime to timespec conversion of dates beyond 2106-02-06
ClosedPublic

Authored by jeffpc_josefsipek.net on Apr 12 2024, 2:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 1, 6:20 AM
Unknown Object (File)
Tue, Jul 1, 2:50 AM
Unknown Object (File)
Mon, Jun 30, 4:28 PM
Unknown Object (File)
Mon, Jun 30, 10:33 AM
Unknown Object (File)
Sun, Jun 29, 5:00 AM
Unknown Object (File)
Wed, Jun 25, 6:10 AM
Unknown Object (File)
Tue, Jun 24, 7:08 PM
Unknown Object (File)
Jun 18 2025, 3:07 AM
Subscribers

Details

Summary

It turns out that the only conversion issue was in fattime2timespec, where
multiplying the number of seconds in a day by the number of days overflowed
32-bit unsigned int for dates beyond 2106-02-07 06:28:15.

Casting one of the multiplicands as time_t forces a 64-bit multiplication on
systems where time_t is 64-bits and produces no binary changes on the one
remaining system with 32-bit time_t (namely i386).

Since the code is now tested & fixed, this change removes the fixme comments.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable