kboot: Assert errno is negative
ClosedPublic
Actions

Authored by imp on Feb 2 2023, 8:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 22, 9:50 AM

	Unknown Object (File)
	Fri, May 22, 1:19 AM

	Unknown Object (File)
	Tue, May 19, 3:29 AM

	Unknown Object (File)
	Mon, May 18, 3:35 AM

	Unknown Object (File)
	Sun, May 17, 3:30 AM

	Unknown Object (File)
	Thu, Apr 30, 1:01 PM

	Unknown Object (File)
	Apr 20 2026, 9:34 AM

	Unknown Object (File)
	Apr 14 2026, 11:30 AM

View All 97 Files

Subscribers

dab

Details

Reviewers

brooks
kevans
tsoome
manu

Commits

rG63c7a483e552: kboot: Assert errno is negative

Summary

When converting from a Linux error to a FreeBSD errno, assert that the
value passed in is negative, as is Linux's custom.

Suggested by: brooks
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Feb 2 2023, 8:27 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 2 2023, 8:27 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Feb 2 2023, 8:27 PM

Harbormaster completed remote builds in B49490: Diff 116361.Feb 2 2023, 8:27 PM

I'd be tempted to allow 0 so it could be used for standard syscall-like functions, but this is fine.

This revision is now accepted and ready to land.Feb 2 2023, 8:32 PM

tsoome accepted this revision.Feb 2 2023, 8:37 PM

Closed by commit rG63c7a483e552: kboot: Assert errno is negative (authored by imp). · Explain WhyFeb 2 2023, 9:12 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG63c7a483e552: kboot: Assert errno is negative.

Revision Contents
Changeset List

Path

Size

stand/

kboot/

host_syscall.h

9 lines

Diff 116364

View Options

stand/kboot/host_syscall.h

kboot: Assert errno is negativeClosedPublicActions