Page MenuHomeFreeBSD
Differential D38041

stand/ofw: dev can't be NULL here
ClosedPublic
Actions

Authored by imp on Jan 13 2023, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 21, 6:14 PM
Unknown Object (File)
Wed, Mar 18, 10:24 AM
Unknown Object (File)
Tue, Mar 17, 5:44 AM
Unknown Object (File)
Tue, Mar 10, 4:37 PM
Unknown Object (File)
Tue, Mar 10, 1:49 AM
Unknown Object (File)
Mon, Mar 9, 6:00 PM
Unknown Object (File)
Sat, Mar 7, 12:15 PM
Unknown Object (File)
Fri, Mar 6, 11:15 PM
View All Files
Subscribers
dab

Details

Reviewers
kevans
manu
tsoome
Commits
rG2f7b00be106f: stand/ofw: dev can't be NULL here
rGd38d8a4c4e9a: stand/ofw: dev can't be NULL here
Summary

dev can't be NULL here. ofw_common_parsedev is always called via
devparse (indirectly through dv_parsedev() calls there which call it
with the args unchanged). In the past, ofw_getdev could call us with
NULL pointer for the parse-only case, but that's now all handled inside
of devparse for simplicity.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jan 13 2023, 4:33 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 13 2023, 4:33 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Jan 13 2023, 4:33 PM
Harbormaster completed remote builds in B49092: Diff 115048.Jan 13 2023, 4:33 PM
imp added a child revision: D38042: stand/uboot: Explain why we test for NULL here.Jan 13 2023, 4:33 PM
imp added a reviewer: tsoome.Jan 13 2023, 6:38 PM
kevans accepted this revision.Jan 13 2023, 7:39 PM
This revision is now accepted and ready to land.Jan 13 2023, 7:39 PM
Closed by commit rGd38d8a4c4e9a: stand/ofw: dev can't be NULL here (authored by imp). · Explain WhyJan 13 2023, 9:27 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGd38d8a4c4e9a: stand/ofw: dev can't be NULL here.
tsoome added inline comments.Jan 13 2023, 9:29 PM
stand/libofw/devicename.c
111

default_parsedev() is actually testing it too.

imp added a comment.Jan 13 2023, 10:46 PM

Good eye.

imp mentioned this in rG4883f347f6ed: stand: dev can't be NULL in default_prasedev.Jan 13 2023, 10:57 PM
imp added a commit: rG2f7b00be106f: stand/ofw: dev can't be NULL here.Jan 24 2023, 10:21 PM
imp mentioned this in rG3ececb0f35b9: stand: dev can't be NULL in default_prasedev.

Revision Contents
Changeset List

PathSize
stand/
libofw/
3 lines

Diff 115093

View Options

stand/libofw/devicename.c

Loading...