Page MenuHomeFreeBSD

stand/ofw: dev can't be NULL here
ClosedPublic

Authored by imp on Jan 13 2023, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 16, 4:42 PM
Unknown Object (File)
Wed, Aug 26, 9:04 PM
Unknown Object (File)
Aug 12 2026, 9:08 PM
Unknown Object (File)
Aug 11 2026, 11:29 PM
Unknown Object (File)
Aug 10 2026, 11:00 AM
Unknown Object (File)
Aug 10 2026, 10:50 AM
Unknown Object (File)
Aug 10 2026, 10:47 AM
Unknown Object (File)
Aug 7 2026, 6:38 AM
Subscribers

Details

Summary

dev can't be NULL here. ofw_common_parsedev is always called via
devparse (indirectly through dv_parsedev() calls there which call it
with the args unchanged). In the past, ofw_getdev could call us with
NULL pointer for the parse-only case, but that's now all handled inside
of devparse for simplicity.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jan 13 2023, 4:33 PM
This revision is now accepted and ready to land.Jan 13 2023, 7:39 PM
This revision was automatically updated to reflect the committed changes.
stand/libofw/devicename.c
111

default_parsedev() is actually testing it too.