Page MenuHomeFreeBSD

stand/ofw: dev can't be NULL here
ClosedPublic

Authored by imp on Jan 13 2023, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 26 2024, 10:09 AM
Unknown Object (File)
Jan 5 2024, 5:33 AM
Unknown Object (File)
Jan 5 2024, 5:33 AM
Unknown Object (File)
Jan 3 2024, 8:15 PM
Unknown Object (File)
Jan 3 2024, 7:01 PM
Unknown Object (File)
Dec 20 2023, 7:39 AM
Unknown Object (File)
Dec 13 2023, 10:37 AM
Unknown Object (File)
Dec 13 2023, 10:20 AM
Subscribers

Details

Summary

dev can't be NULL here. ofw_common_parsedev is always called via
devparse (indirectly through dv_parsedev() calls there which call it
with the args unchanged). In the past, ofw_getdev could call us with
NULL pointer for the parse-only case, but that's now all handled inside
of devparse for simplicity.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jan 13 2023, 4:33 PM
This revision is now accepted and ready to land.Jan 13 2023, 7:39 PM
This revision was automatically updated to reflect the committed changes.
stand/libofw/devicename.c
111

default_parsedev() is actually testing it too.