Random failure to read dos file in bootloader
AcceptedPublic
Actions

Authored by vico.chern_qq.com on Mar 8 2023, 8:11 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 21, 10:04 PM

	Unknown Object (File)
	Fri, Jun 19, 12:19 AM

	Unknown Object (File)
	Mon, Jun 8, 8:20 PM

	Unknown Object (File)
	Mon, May 25, 8:23 PM

	Unknown Object (File)
	Mon, May 25, 8:14 PM

	Unknown Object (File)
	May 18 2026, 12:59 AM

	Unknown Object (File)
	May 17 2026, 8:22 PM

	Unknown Object (File)
	May 17 2026, 8:17 PM

View All 87 Files

Subscribers

dab

imp

Details

Reviewers

trasz
manu
tsoome

Summary

The failure is due to data overflow while calculate block offset by 'blkoff' for some cases. Extend the variables to 64bits.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vico.chern_qq.com created this revision.Mar 8 2023, 8:11 AM

Herald added a reviewer: manu. · View Herald TranscriptMar 8 2023, 8:11 AM

Herald added subscribers: dab, imp. · View Herald Transcript

vico.chern_qq.com requested review of this revision.Mar 8 2023, 8:11 AM

vico.chern_qq.com added a reviewer: tsoome.Mar 8 2023, 9:29 AM

tsoome accepted this revision.Mar 8 2023, 10:32 AM

This revision is now accepted and ready to land.Mar 8 2023, 10:32 AM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

dosfs.c

8 lines

Diff 118520

View Options

Random failure to read dos file in bootloaderAcceptedPublicActions