Differential D55179

loader.efi: free_tables() appears to free tss_pa twice.
ClosedPublic
Actions

Authored by tsoome on Sun, Feb 8, 11:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 5, 7:15 PM

	Unknown Object (File)
	Wed, Mar 4, 5:10 PM

	Unknown Object (File)
	Sun, Mar 1, 3:34 PM

	Unknown Object (File)
	Sun, Mar 1, 12:44 PM

	Unknown Object (File)
	Wed, Feb 25, 4:44 PM

	Unknown Object (File)
	Mon, Feb 16, 7:04 PM

	Unknown Object (File)
	Fri, Feb 13, 11:39 PM

	Unknown Object (File)
	Tue, Feb 10, 9:42 PM

View All 9 Files

Subscribers

Details

Reviewers

manu
kib

Commits

rGf2186bbd63fc: loader.efi: free_tables() appears to free tss_pa twice.

Summary

we check and reset loader_gdt_pa, but use FreePages(tss_pa).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Sun, Feb 8, 11:02 AM

Herald added a reviewer: manu. · View Herald TranscriptSun, Feb 8, 11:02 AM

Herald added subscribers: dab, bcran, imp. · View Herald Transcript

tsoome requested review of this revision.Sun, Feb 8, 11:02 AM

tsoome added a parent revision: D55178: loader.efi: tss_pa setup seems to be flawed in trap.c.

tsoome added a child revision: D55180: loader.efi: efi_redirect_exceptions does use uninitialized pointer.

Harbormaster completed remote builds in B70517: Diff 171447.Sun, Feb 8, 11:02 AM

Those 4 updates are about problems what I have found from trap.c, however, since I'm getting fault with ungrab_faults, there must be something more. Typo fix is trivial and I guess I can just push that one:D

kib accepted this revision.Sun, Feb 8, 12:09 PM

This revision is now accepted and ready to land.Sun, Feb 8, 12:09 PM

Closed by commit rGf2186bbd63fc: loader.efi: free_tables() appears to free tss_pa twice. (authored by tsoome). · Explain WhySat, Feb 21, 3:23 PM

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rGf2186bbd63fc: loader.efi: free_tables() appears to free tss_pa twice..

bms added a subscriber: bms.Sat, Feb 21, 3:52 PM

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

arch/

amd64/

9 lines

Diff 172383

stand/efi/loader/arch/amd64/trap.c

Loading...