loader.efi: free_tables() appears to free tss_pa twice.
AcceptedPublic
Actions

Authored by tsoome on Sun, Feb 8, 11:02 AM.

Details

Reviewers

manu
kib

Summary

we check and reset loader_gdt_pa, but use FreePages(tss_pa).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70517
Build 67400: arc lint + arc unit

Event Timeline

tsoome created this revision.Sun, Feb 8, 11:02 AM

Herald added a reviewer: manu. · View Herald TranscriptSun, Feb 8, 11:02 AM

Herald added subscribers: dab, bcran, imp. · View Herald Transcript

tsoome requested review of this revision.Sun, Feb 8, 11:02 AM

tsoome added a parent revision: D55178: loader.efi: tss_pa setup seems to be flawed in trap.c.

tsoome added a child revision: D55180: loader.efi: efi_redirect_exceptions does use uninitialized pointer.

Harbormaster completed remote builds in B70517: Diff 171447.Sun, Feb 8, 11:02 AM

Those 4 updates are about problems what I have found from trap.c, however, since I'm getting fault with ungrab_faults, there must be something more. Typo fix is trivial and I guess I can just push that one:D

kib accepted this revision.Sun, Feb 8, 12:09 PM

This revision is now accepted and ready to land.Sun, Feb 8, 12:09 PM

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

arch/

amd64/

trap.c

9 lines

Diff 171447

View Options

stand/efi/loader/arch/amd64/trap.c

loader.efi: free_tables() appears to free tss_pa twice.AcceptedPublicActions