Page MenuHomeFreeBSD
Differential D55178

loader.efi: tss_pa setup seems to be flawed in trap.c
ClosedPublic
Actions

Authored by tsoome on Sun, Feb 8, 11:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 4, 4:30 PM
Unknown Object (File)
Wed, Mar 4, 9:11 AM
Unknown Object (File)
Wed, Mar 4, 3:06 AM
Unknown Object (File)
Wed, Mar 4, 12:09 AM
Unknown Object (File)
Sat, Feb 28, 7:11 PM
Unknown Object (File)
Sat, Feb 28, 7:23 AM
Unknown Object (File)
Tue, Feb 24, 5:41 PM
Unknown Object (File)
Tue, Feb 24, 11:13 AM
View All 21 Files
Subscribers
bcran
dab
imp
kib

Details

Reviewers
manu
kib
Commits
rGdc11af08a498: loader.efi: tss_pa setup seems to be flawed in trap.c
Summary

since sd_lobase is 24 bits, we would need to shift 24 bits, not 16.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome created this revision.Sun, Feb 8, 11:01 AM
Herald added a reviewer: manu. · View Herald TranscriptSun, Feb 8, 11:01 AM
Herald added subscribers: dab, bcran, imp. · View Herald Transcript
tsoome requested review of this revision.Sun, Feb 8, 11:01 AM
tsoome added a parent revision: D55177: fix typo in efi/loader/arch/amd64/trap.c.
Harbormaster completed remote builds in B70516: Diff 171446.Sun, Feb 8, 11:01 AM
tsoome added a child revision: D55179: loader.efi: free_tables() appears to free tss_pa twice..Sun, Feb 8, 11:02 AM
kib accepted this revision.Sun, Feb 8, 12:02 PM
kib added a subscriber: kib.
kib added inline comments.
stand/efi/loader/arch/amd64/trap.c
223

sd_lobase is 24-bits wide, so I do not think it matters

This revision is now accepted and ready to land.Sun, Feb 8, 12:02 PM
tsoome marked an inline comment as done.Sat, Feb 21, 8:48 AM
tsoome added inline comments.
stand/efi/loader/arch/amd64/trap.c
223

yep, dropping it.

tsoome updated this revision to Diff 172370.Sat, Feb 21, 8:49 AM
tsoome marked an inline comment as done.

remove not needed mask.

This revision now requires review to proceed.Sat, Feb 21, 8:49 AM
Harbormaster completed remote builds in B70848: Diff 172370.Sat, Feb 21, 8:49 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 21, 8:56 AM
Closed by commit rGdc11af08a498: loader.efi: tss_pa setup seems to be flawed in trap.c (authored by tsoome). · Explain Why
This revision was automatically updated to reflect the committed changes.
tsoome added a commit: rGdc11af08a498: loader.efi: tss_pa setup seems to be flawed in trap.c.

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
arch/
amd64/
2 lines

Diff 172371

View Options

stand/efi/loader/arch/amd64/trap.c

Loading...