Page MenuHomeFreeBSD

Don't re-evaluate ALTQ kernel configuration due to events on non-ALTQ interfaces
ClosedPublic

Authored by pkelsey on Jan 22 2019, 1:55 AM.

Details

Summary

Prior to this patch, events on interfaces that couldn't possibly be part of a PF ALTQ configuration, such as vlan(4), would trigger a copy-existing / install-new / teardown-old PF ALTQ configuration cycle. This would result in needlessly lengthy vlan(4) creation times on systems with active PF configurations that had a large number (hundreds or thousands) of queues. On such systems that also employ hundreds or thousands of vlan(4) interfaces, the time required to create those interfaces became untenable.

Test Plan

Tested with a pf.conf containing ~4k queues. vlan(4) creation times are reduced from ~200ms each to < 10ms each.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pkelsey created this revision.Jan 22 2019, 1:55 AM
kristof accepted this revision.Jan 24 2019, 2:58 AM
This revision is now accepted and ready to land.Jan 24 2019, 2:58 AM
This revision was automatically updated to reflect the committed changes.