Differential D19220

Still a memory corruption bug in vdev_read in loader ZFS support
ClosedPublic
Actions

Authored by pkelsey on Feb 17 2019, 4:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 22, 4:54 PM

	Unknown Object (File)
	Sun, Jun 21, 6:30 PM

	Unknown Object (File)
	Sun, Jun 21, 4:06 PM

	Unknown Object (File)
	Fri, Jun 19, 2:56 PM

	Unknown Object (File)
	Thu, Jun 18, 1:12 PM

	Unknown Object (File)
	Tue, Jun 16, 2:46 PM

	Unknown Object (File)
	May 20 2026, 4:04 PM

	Unknown Object (File)
	May 18 2026, 4:49 PM

View All Files

Subscribers

delphij

Details

Reviewers

allanjude
imp
tsoome

Commits

rS344234: It turns out r344226 narrowed the overrun bug but did not eliminate it entirely

Summary

D19140 didn't quite expunge the memory corruption bug in vdev_read() in zfs.c. In that fix, the single-sector case with non-zero tail would overrun the output buffer by the tail size.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkelsey created this revision.Feb 17 2019, 4:16 AM

Herald added a subscriber: delphij. · View Herald TranscriptFeb 17 2019, 4:16 AM

tsoome accepted this revision.Feb 17 2019, 7:02 AM

This revision is now accepted and ready to land.Feb 17 2019, 7:02 AM

pkelsey retitled this revision from Still a memory corruption bug in vdev_readin loader ZFS support to Still a memory corruption bug in vdev_read in loader ZFS support.Feb 17 2019, 4:27 PM

allanjude accepted this revision.Feb 17 2019, 5:32 PM

Closed by commit rS344234: It turns out r344226 narrowed the overrun bug but did not eliminate it entirely (authored by pkelsey). · Explain WhyFeb 17 2019, 5:47 PM

This revision was automatically updated to reflect the committed changes.