Page MenuHomeFreeBSD
Differential D11170

cddl/usr.bin/zstreamdump build warning fixes
AbandonedPublic
Actions

Authored by sbruno on Jun 12 2017, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 6:21 PM
Unknown Object (File)
Mon, Jun 29, 8:17 PM
Unknown Object (File)
Sun, Jun 28, 4:53 AM
Unknown Object (File)
Thu, Jun 25, 5:36 AM
Unknown Object (File)
Tue, Jun 23, 7:11 PM
Unknown Object (File)
Sat, Jun 20, 1:29 AM
Unknown Object (File)
May 30 2026, 4:53 PM
Unknown Object (File)
May 28 2026, 10:07 PM
View All Files
Subscribers
None

Details

Reviewers
kbowling
avg
allanjude
aprieger_llnw.com
Summary

fixes for warnings during build time for the application in cddl/usr.bin/zstreamdump

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9990
Build 10417: arc lint + arc unit

Event Timeline

aprieger_llnw.com created this revision.Jun 12 2017, 10:52 PM
Harbormaster completed remote builds in B9836: Diff 29521.Jun 12 2017, 10:52 PM
aprieger_llnw.com added a comment.EditedJun 12 2017, 10:55 PM

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/617c9f82b9ce12428da6c500ce95f120

  1. cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c
    • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • fix: change the print format modifier for the uint64_t variables from "%llx" or "%llu" to "%"PRIu64 on lines 125, 392, 561 and 562
sbruno added reviewers: avg, allanjude.Jun 17 2017, 6:46 PM
allanjude added inline comments.Jun 18 2017, 3:08 AM
cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c
392

Doesn't this change the behaviour, from printing in hex to printing in decimal?

sbruno requested changes to this revision.Jun 18 2017, 10:48 PM
sbruno added inline comments.
cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c
392

Yeah, it does. This should be PRIx64 if I understand the macros in /usr/include/x86/_inttypes.h

This revision now requires changes to proceed.Jun 18 2017, 10:48 PM
aprieger_llnw.com updated this revision to Diff 29823.Jun 19 2017, 5:23 PM
aprieger_llnw.com edited edge metadata.
  • cddl/usr.bin/zstreamdump revision update
Harbormaster completed remote builds in B9990: Diff 29823.Jun 19 2017, 5:23 PM
sbruno commandeered this revision.Jun 24 2020, 7:41 PM
sbruno abandoned this revision.
sbruno edited reviewers, added: aprieger_llnw.com; removed: sbruno.

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
cmd/
zstreamdump/
10 lines

Diff 29823

View Options

cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c

Loading...