Page MenuHomeFreeBSD

cddl/usr.bin/zstreamdump build warning fixes
AbandonedPublic

Authored by sbruno on Jun 12 2017, 10:52 PM.

Details

Summary

fixes for warnings during build time for the application in cddl/usr.bin/zstreamdump

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9990
Build 10417: arc lint + arc unit

Event Timeline

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/617c9f82b9ce12428da6c500ce95f120

  1. cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c
    • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • fix: change the print format modifier for the uint64_t variables from "%llx" or "%llu" to "%"PRIu64 on lines 125, 392, 561 and 562
cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c
392

Doesn't this change the behaviour, from printing in hex to printing in decimal?

sbruno requested changes to this revision.Jun 18 2017, 10:48 PM
sbruno added inline comments.
cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c
392

Yeah, it does. This should be PRIx64 if I understand the macros in /usr/include/x86/_inttypes.h

This revision now requires changes to proceed.Jun 18 2017, 10:48 PM
aprieger_llnw.com edited edge metadata.
  • cddl/usr.bin/zstreamdump revision update
sbruno abandoned this revision.
sbruno edited reviewers, added: aprieger_llnw.com; removed: sbruno.