Page MenuHomeFreeBSD

aprieger_llnw.com (Aaron Prieger)
User

Projects

User does not belong to any projects.

User Details

User Since
May 30 2017, 6:30 PM (242 w, 1 d)

Recent Activity

Aug 10 2017

aprieger_llnw.com added a comment to D11970: cddl/sbin/zfs build warning fix.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/8a6e81012a5d8894659151c23e49adf0

  1. cddl/contrib/opensolaris/cmd/zfs/zfs_main.c
    • warning: format specifies type 'unsigned long' but the argument has type 'unsigned long long' [-Wformat]
      • fix: corrected print modifier from PRIu64 which is reserved for uint_64 variables, changes to %llu
Aug 10 2017, 10:57 PM
aprieger_llnw.com created D11970: cddl/sbin/zfs build warning fix.
Aug 10 2017, 10:53 PM
aprieger_llnw.com added a comment to D11958: usr.bin/mandoc build warning/error fixes.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/53047c8a5d6eb6c28281e41a30e7d1da

  1. contrib/mdocml/main.c
    • warning: implicit declaration of function 'getline' is invalid in C99 [-Wimplicit-function-declaration]
      • fix: defined _WITH_GETLINE on line 37 to allow the 'getline' function to be used with POSIX, according to the FreeBSD manual
  2. contrib/mdocml/mandocdb.c
    • warning: implicit declaration of function 'getline' is invalid in C99 [-Wimplicit-function-declaration]
      • fix: defined _WITH_GETLINE on line 43 to allow the 'getline' function to be used with POSIX, according to the FreeBSD manual
  3. contrib/mdocml/manpath.c
    • warning: implicit declaration of function 'getline' is invalid in C99 [-Wimplicit-function-declaration]
      • fix: defined _WITH_GETLINE on line 28 to allow the 'getline' function to be used with POSIX, according to the FreeBSD manual
Aug 10 2017, 5:35 PM
aprieger_llnw.com created D11958: usr.bin/mandoc build warning/error fixes.
Aug 10 2017, 5:31 PM
aprieger_llnw.com set the repository for D11869: sys/boot/geli build warning fixes to rS FreeBSD src repository - subversion.
Aug 10 2017, 5:28 PM

Aug 4 2017

aprieger_llnw.com added a comment to D11869: sys/boot/geli build warning fixes.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/cb7e4248bc235c1d24a3e82fb30998d5

  1. sys/boot/geli/geliboot_crypto.c
    • warning: incompatible pointer types passing 'struct aes_xts_ctx *' to parameter of type 'caddr_t' (aka 'char *') [-Wincompatible-pointer-types]
      • fix: explicitly casted the parameters to type caddr_t on lines 85, 90, 95
Aug 4 2017, 7:23 PM
aprieger_llnw.com created D11869: sys/boot/geli build warning fixes.
Aug 4 2017, 7:21 PM

Aug 2 2017

aprieger_llnw.com abandoned D11083: cddl/lib/libzfs build warning fixes.

Will submit changes directly to the OpenZFS Github

Aug 2 2017, 5:33 PM
aprieger_llnw.com abandoned D11100: cddl/sbin/zfs build warning fixes.

Will submit changes directly through the OpenZFS Github

Aug 2 2017, 5:32 PM

Jul 25 2017

aprieger_llnw.com abandoned D11719: lib/clang/lldb build warning fixes.
Jul 25 2017, 5:30 PM
aprieger_llnw.com added a comment to D11719: lib/clang/lldb build warning fixes.

Thank you, I will post the change upstream

Jul 25 2017, 5:29 PM

Jul 24 2017

aprieger_llnw.com added a comment to D11719: lib/clang/lldb build warning fixes.

, Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/0f847b47b3d2d522d27c4dfbf723b3cd

  1. contrib/llvm/tools/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    • warning: warning: format specifies type 'unsigned long' but the argument has type 'rep' (aka 'long long') [-Wformat]
      • fix: added the explicit modifiers (unsigned long) to the parameters on lines 2198, 2199 and 2256
Jul 24 2017, 10:12 PM
aprieger_llnw.com created D11719: lib/clang/lldb build warning fixes.
Jul 24 2017, 10:10 PM
aprieger_llnw.com added a comment to D11714: gnu/usr.bin/gdb/libgdb more build warning/bug fixes.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/a952754f3c2a06a5cdbb7137d7612e77

  1. contrib/gdb/gdb/arch-utils.c
    • warning: warning: passing 'bfd_byte *' (aka 'unsigned char *') to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: added the (char*) explicit modifier on lines 58 and 60
Jul 24 2017, 8:47 PM
aprieger_llnw.com created D11714: gnu/usr.bin/gdb/libgdb more build warning/bug fixes.
Jul 24 2017, 8:33 PM

Jul 21 2017

aprieger_llnw.com abandoned D11691: sys/boot/geli build warning fixes.
Jul 21 2017, 8:58 PM
aprieger_llnw.com added a comment to D11691: sys/boot/geli build warning fixes.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/4f6b2e7492d344ea911b918ea8f4e9d9

  1. sys/boot/geli/geliboot_crypto.c
    • warning: incompatible pointer types passing 'struct aes_xts_ctx *' to parameter of type 'caddr_t' (aka 'char *') [-Wincompatible-pointer-types]
      • fix: explicitly casted the parameters to type caddr_t on lines 85, 90, 95
Jul 21 2017, 6:35 PM
aprieger_llnw.com created D11691: sys/boot/geli build warning fixes.
Jul 21 2017, 6:29 PM

Jun 23 2017

aprieger_llnw.com added a comment to D11327: lib/libalias/libalias bug/build warning fixes.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/e21689151f16ceb4aed8bfb4ce031853

  1. sys/netinet/libalias/alias.c
    • warning: cast from 'char *' to 'struct ip *' increases required alignment from 1 to 2 [-Wcast-align]
      • fix: added the (void *) explicit modifier to force alignment on lines 1236, 1255, 1281, 1282, 1324, 1455, 1563
    • taking address of packed member 'ip_dst' of class or structure 'ip' may result in an unaligned pointer value [-Waddress-of-packed-member]
      • fix: created new in_addr variable dst to use in the function in place of the packed member on lines 1371, 1377
    • warning: taking address of packed member 'ip_src' of class or structure 'ip' may result in an unaligned pointer value [-Waddress-of-packed-member]
      • fix: created new in_addr variable src to use in the function in place of the packed member on lines 1525, 1533
Jun 23 2017, 5:43 PM
aprieger_llnw.com created D11327: lib/libalias/libalias bug/build warning fixes.
Jun 23 2017, 5:24 PM

Jun 19 2017

aprieger_llnw.com added a comment to D11277: kerberos5/libexec/kcm update deprecated functions causing build warnings.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/b1f8fe42a8f690da68b533c67720ecef

  1. crypto/heimdal/kcm/acquire.c
  2. crypto/heimdal/kcm/client.c
  3. crypto/heimdal/kcm/events.c
  4. crypto/heimdal/kcm/renew.c
Jun 19 2017, 10:17 PM
aprieger_llnw.com created D11277: kerberos5/libexec/kcm update deprecated functions causing build warnings.
Jun 19 2017, 10:12 PM
aprieger_llnw.com updated the diff for D11068: tests/sys/geom build warning fixes.
  • tests/sys/geom build warning fixes
  • tests/sys/geom revision update
Jun 19 2017, 6:18 PM
aprieger_llnw.com updated the diff for D11166: lib/libpcap build warning fixes.
  • lib>libpcap revision update
Jun 19 2017, 5:38 PM
aprieger_llnw.com updated the diff for D11170: cddl/usr.bin/zstreamdump build warning fixes.
  • cddl/usr.bin/zstreamdump revision update
Jun 19 2017, 5:23 PM
aprieger_llnw.com updated the diff for D11199: gnu/usr.bin/gdb/libgdb build warning/bug fixes.
  • gnu/usr.bin/gdb/libgdb more build warning/bug fixes
Jun 19 2017, 5:13 PM

Jun 16 2017

aprieger_llnw.com added a comment to D11180: gnu/usr.bin/grep some build warning fixes.

Hello kevans91_ksu.edu,

Jun 16 2017, 7:41 PM
aprieger_llnw.com planned changes to D11199: gnu/usr.bin/gdb/libgdb build warning/bug fixes.

Many more build warnings when built on different targets, will be taken down from review until revised

Jun 16 2017, 7:21 PM
aprieger_llnw.com added a comment to D11180: gnu/usr.bin/grep some build warning fixes.

Note: Remaining warnings:

  • /usr/home/aprieger/repos/freebsd_master/freebsd/gnu/usr.bin/grep/grep.c:1410:15: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
  • /usr/home/aprieger/repos/freebsd_master/freebsd/gnu/usr.bin/grep/grep.c:1593:20: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
Jun 16 2017, 7:12 PM
aprieger_llnw.com added a comment to D11166: lib/libpcap build warning fixes.

Note: remaining warnings:

  • yacc: 38 shift/reduce conflicts.
Jun 16 2017, 7:02 PM
aprieger_llnw.com added a comment to D11205: kerberos5/lib/libkrb5 more build warning fixes.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/c8047fba03cfbb54bb5a46560679471c

  1. crypto/heimdal/lib/krb5/init_creds_pw.c
    • warning: taking the absolute value of unsigned type 'LR_TYPE' (aka 'enum LR_TYPE') has no effect [-Wabsolute-value]
      • fix: added the signed modifier to change the unsigned parameter in the switch to allow it to be taken the absolute value of on line 314
      • note: simply removing the absolute value function causes more warnings calling for the unhandled enumeration values for the switch
  2. crypto/heimdal/lib/krb5/ticket.c
    • warning: format specifies type 'int' but the argument has type 'long' [-Wformat]
      • fix: added the (int) explicit modifier to the parameter on line 783
Jun 16 2017, 5:51 PM
aprieger_llnw.com retitled D11226: kerberos5/usr.bin/kinit build warning/bug fixes from crypto/heimdal/kuser bug/build warning fixes to kerberos5/usr.bin/kinit build warning/bug fixes.
Jun 16 2017, 5:39 PM

Jun 15 2017

aprieger_llnw.com added a comment to D11226: kerberos5/usr.bin/kinit build warning/bug fixes.

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/1cfc4f76359e36ff91c50595dc832afe

  1. crypto/heimdal/kuser/kinit.c
    • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
      • fix: changed the abs() function to labs() to accommodate the long parameters lines 583 and 591
Jun 15 2017, 7:45 PM
aprieger_llnw.com created D11226: kerberos5/usr.bin/kinit build warning/bug fixes.
Jun 15 2017, 7:43 PM
aprieger_llnw.com added a comment to D11199: gnu/usr.bin/gdb/libgdb build warning/bug fixes.

Changelog

  1. contrib/gdb/gdb/amd64fbsd-nat.c
    • warning: incompatible pointer to integer conversion assigning to 'CORE_ADDR' (aka 'unsigned long') from 'void *' [-Wint-conversion]
      • fix: explicitly casted the parameters of the two variables to (CORE_ADDR) one lines 231 and 232
  2. contrib/gdb/gdb/amd64-tdep.c
    • warning: passing 'unsigned char [3]' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: casted the parameter to (char *) on line 744
  3. contrib/gdb/gdb/breakpoint.c
    • warning: expression result unused [-Wunused-value]
      • fix: removed the unused variable
  4. contrib/gdb/gdb/cli/cli-setshow.c
    • warning: passing 'unsigned char *' to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameter to (const char *) on line 282
  5. contrib/gdb/gdb/coff-pe-read.c
    • warning: assigning to 'char *' from 'unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the RHS to (char *) on line 299
    • warning: passing 'unsigned char *' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameter to (char *) on line 336
  6. contrib/gdb/gdb/corelow.c
    • warning: passing 'const void *' to parameter of type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
      • fix: explicitly casted the parameter to (char *) on lines 532 and 576
  7. contrib/gdb/gdb/c-typeprint.c
    • warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
      • fix: removed the first part of the condition, as it is uneeded
  8. contrib/gdb/gdb/dwarf2expr.c
    • warning: 154 enumeration values not handled in switch: 'DW_OP_addr', 'DW_OP_const1u', 'DW_OP_const1s'... [-Wswitch]
      • fix: added a default case to end of switch statement on line 565
    • warning: passing 'char *' to parameter of type 'unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameters to (unsigned char *) on lines 531, 532, 544, 545
  9. contrib/gdb/gdb/dwarf2-frame.c
    • warning: passing 'long *' to parameter of type 'unsigned long *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameters to (unsigned long *) on line 396
    • warning: assigning to 'unsigned char *' from 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the RHS to (unsigned char *) on lines 1339, 1381, 1382, 1440, 1441
    • warning: unsequenced modification and access to 'buf' [-Wunsequenced]
      • fix: moved the incrementation of buf one lines down one line 1364
    • warning: assigning to 'char *' from 'unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the RHS to (char *) on lines 1376
  10. contrib/gdb/gdb/dwarf2loc.c
    • warning: assigning to 'unsigned char *' from 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the LHS to (unsigned char *) on line 164, 315, 531, 578
    • warning: assigning to 'bfd_byte *' (aka 'unsigned char *') from 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the RHS to (bfd_byte *) on line 241
    • warning: passing 'bfd_byte *' (aka 'unsigned char *') to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameter to (char *) on line 254
    • warning: assigning to 'char *' from 'unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the RHS to (char *) on line 65 and 66
    • warning: passing 'char *' to parameter of type 'unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameter to (unsigned char *) on lines 70 and 72
    • warning: passing 'unsigned int *' to parameter of type 'int *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameter to (int *) on lines 70 and 72
  11. contrib/gdb/gdb/dwarf2read.c
    • warning: passing 'unsigned int *' to parameter of type 'int *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameter to (int *) on lines 4586, 5416, 7554
    • warning: passing 'int *' to parameter of type 'unsigned int *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the parameter to (unsigned int *) on lines 5260, 5268, 5273, 5275, 5277, 5416, 7554, 7974, 7976, 8001, 8003, 8053, 8055
    • warning: assigning to 'unsigned char *' from 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly casted the RHS to (unsigned char *) on lines 8092 and 8117
  12. contrib/gdb/gdb/f-exp.y
    • warning: enumeration values 'tp_const', 'tp_volatile', and 'tp_space_identifier' not handled in switch [-Wswitch]
      • fix: added the default case to the switch on line 541
  13. contrib/gdb/gdb/f-typeprint.c
    • warning: enumeration values 'TYPE_CODE_TEMPLATE', 'TYPE_CODE_TEMPLATE_ARG', and 'TYPE_CODE_NAMESPACE' not handled in switch [-Wswitch]
      • fix: added the default case to the switch on line 149 and 261
Jun 15 2017, 6:06 PM

Jun 14 2017

aprieger_llnw.com created D11205: kerberos5/lib/libkrb5 more build warning fixes.
Jun 14 2017, 11:09 PM
aprieger_llnw.com added a comment to D11199: gnu/usr.bin/gdb/libgdb build warning/bug fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/1dfe9bc5edcf0a710f71b02d38f9446e

Jun 14 2017, 10:41 PM
aprieger_llnw.com updated the test plan for D11199: gnu/usr.bin/gdb/libgdb build warning/bug fixes.
Jun 14 2017, 10:40 PM
aprieger_llnw.com added reviewers for D11199: gnu/usr.bin/gdb/libgdb build warning/bug fixes: kbowling, sbruno.
Jun 14 2017, 10:40 PM
aprieger_llnw.com created D11199: gnu/usr.bin/gdb/libgdb build warning/bug fixes.
Jun 14 2017, 10:39 PM
aprieger_llnw.com added a comment to D11100: cddl/sbin/zfs build warning fixes.

Thank you for the feedback! I will send try to get it reviewed and submitted on their end.

Jun 14 2017, 4:58 PM

Jun 13 2017

aprieger_llnw.com added a comment to D11180: gnu/usr.bin/grep some build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/1663e8154be3e2349a350ac86aaad2cb

  1. gnu/usr.bin/grep/dfa.c
    • warning: passing 'const unsigned char *' to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: explicitly cast the parameters to (const char *) on lines 386, 2511, 2518, 2531, 2786
    • warning: incompatible pointer types assigning to 'wchar_t *' (aka 'int *') from 'wctype_t *' (aka 'unsigned long *') [-Wincompatible-pointer-types]
      • fix: Separate the line 488 into two lines, individually assigning them to NULL
    • warning: incompatible pointer types assigning to 'wctype_t *' (aka 'unsigned long *') from 'wchar_t *' (aka 'int *') [-Wincompatible-pointer-types]
      • fix: changed the second parameter of MALLOC call on line 557 to wctype_t, which is the correct type of the first parameter which needs toe be equal to allocate the correct memory
    • warning: passing 'const char *' to parameter of type 'const unsigned char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: fixed the FETCH macro by casting the first parameter to (const unsigned char *) for the function called within the macro that had an incorrect type of parameter being used in the call affecting lines 729, 877, 883, 893, 901, 916, 1004, 1007, 1031, 1035, 1036, 1039, 1051, 1052,
  2. gnu/usr.bin/grep/dfa.c
    • warning: shifting a negative signed value is undefined [-Wshift-negative-value]
      • NO FIX: unable to find solution without mutating the results, may need warning suppression for lines 1410, 1593
  3. gnu/usr.bin/grep/search.c
    • warning: format string is not a string literal (potentially insecure) [-Wformat-security]
      • fix: Added the %s modifier to the print statements on lines 108, 147, 156, 159, 203, 287, 758, 781, 793, 807, 815
Jun 13 2017, 6:35 PM
aprieger_llnw.com created D11180: gnu/usr.bin/grep some build warning fixes.
Jun 13 2017, 6:22 PM
aprieger_llnw.com added a comment to D11179: gnu/usr.bin/diff3 build warning fix.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/9107cf87b7ee961c51b0e8b3d311445f

  1. cddl/contrib/opensolaris/cmd/zdb/zdb.c
    • warning: format string is not a string literal (potentially insecure) [-Wformat-security]
      • fix: add the print modifier "%s" for the printf parameter on line 1409
Jun 13 2017, 5:05 PM
aprieger_llnw.com created D11179: gnu/usr.bin/diff3 build warning fix.
Jun 13 2017, 5:04 PM
aprieger_llnw.com added a comment to D11178: cddl/usr.sbin/zdb build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/5fd2d6cd7562aeac1a261e7b4b72f559

  1. cddl/contrib/opensolaris/cmd/zdb/zdb.c
    • warning: format specifies type 'long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • fix: change the print format modifier for the uint64_t variable from "%lld" to "%"PRIu64 on lines 1149
    • warning: format string is not a string literal (potentially insecure) [-Wformat-security]
      • fix: add the "%s" string modifier in the printf statement before the expression on lines 2049, and 2061
Jun 13 2017, 4:46 PM
aprieger_llnw.com created D11178: cddl/usr.sbin/zdb build warning fixes.
Jun 13 2017, 4:43 PM

Jun 12 2017

aprieger_llnw.com added a comment to D11171: cddl/usr.bin/ztest build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/c7b4d3316c65bb5003229a420752557e

  1. cddl/contrib/opensolaris/cmd/ztest/ztest.c
    • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • fix: change the print format modifier for the uint64_t variables from "%llu" to "%"PRIu64 on lines 2260, 3389, 3391, 3393, 3395, 3397, 3436, 3438, 3440, 3442, 3444, 4268, 4674, 4677, 4678
    • warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
      • fix: change the print format modifier for the int64_t variable from "%lld" to "%"PRId64 on line 2260
Jun 12 2017, 11:20 PM
aprieger_llnw.com created D11171: cddl/usr.bin/ztest build warning fixes.
Jun 12 2017, 11:17 PM
aprieger_llnw.com added a comment to D11170: cddl/usr.bin/zstreamdump build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/617c9f82b9ce12428da6c500ce95f120

  1. cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c
    • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • fix: change the print format modifier for the uint64_t variables from "%llx" or "%llu" to "%"PRIu64 on lines 125, 392, 561 and 562
Jun 12 2017, 10:55 PM
aprieger_llnw.com created D11170: cddl/usr.bin/zstreamdump build warning fixes.
Jun 12 2017, 10:52 PM
aprieger_llnw.com added a comment to D11166: lib/libpcap build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/42d7f6af7bc0daabd37d209befd6f9f4

  1. contrib/libpcap/bpf/net/bpf_filter.c
    • warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
      • fix: modified the function that defines SOLARIS to accommodate the design desired by clang
Jun 12 2017, 9:48 PM
aprieger_llnw.com created D11166: lib/libpcap build warning fixes.
Jun 12 2017, 9:46 PM
aprieger_llnw.com abandoned D11119: gnu/usr.bin/gdb build warning fixes.
Jun 12 2017, 5:10 PM
aprieger_llnw.com updated the diff for D11119: gnu/usr.bin/gdb build warning fixes.

Reverted some changes

Jun 12 2017, 4:40 PM

Jun 9 2017

aprieger_llnw.com added a comment to D11119: gnu/usr.bin/gdb build warning fixes.

Changelog:
Pre-fix warnings are at: https://github.llnw.net/gist/aprieger/25d1af09f4ef0881a2d8

  1. contrib/gdb/gdb/arch-utils.c
    • warning: passing 'bfd_byte *' (aka 'unsigned char *') to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: added the explicit modifier (char *) to parameters on lines 48 and 60
  2. contrib/gdb/gdb/ax-gdb.c
    • warning: 20 enumeration values not handled in switch: 'TYPE_CODE_UNDEF', 'TYPE_CODE_PTR', 'TYPE_CODE_INT'... [-Wswitch]
      • fix: added the default case that simply breaks for the enumeration values on line 745
  3. contrib/gdb/gdb/breakpoint.c
    • warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
      • fix: removed the extra parenthesis for the expressions on lines 2650, 2662
    • warning: expression result unused [-Wunused-value]
      • fix: removed the unused expressions on lines 5546 and 7623
  4. contrib/gdb/gdb/c-typeprint.c
    • warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
      • fix: added the explicit modifier (int) to suppress the warning on line 543
Jun 9 2017, 6:57 PM
aprieger_llnw.com created D11119: gnu/usr.bin/gdb build warning fixes.
Jun 9 2017, 6:45 PM
aprieger_llnw.com added a comment to D11116: lib/libc/locale/xlocale_private.h compile warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/1abe4dd00d141096e9d6135586d4926c

  1. cddl/contrib/opensolaris/cmd/zpool/zpool_main.c
    • warning: passing 'long *' to parameter of type 'volatile u_long *' (aka 'volatile unsigned long *') converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: added the explicit modifier (volatile u_long *) to the parameter one lines 147 and 169
Jun 9 2017, 4:31 PM
aprieger_llnw.com created D11116: lib/libc/locale/xlocale_private.h compile warning fixes.
Jun 9 2017, 4:28 PM

Jun 8 2017

aprieger_llnw.com updated the diff for D11104: cddl/sbin/zpool build warning fixes.

Made a mistake in casting the unsigned longs to integers, needed to be cast to longs to accomodate for the size differences

Jun 8 2017, 8:55 PM
aprieger_llnw.com added a comment to D11104: cddl/sbin/zpool build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/cf6d6401aa8e52d3e6fabc094b997bcb

  1. cddl/contrib/opensolaris/cmd/zpool/zpool_main.c
    • warning: field width should have type 'int', but argument has type 'size_t' (aka 'unsigned long') [-Wformat]
      • fix: added the explicit modifier (int) to the parameter on lines 2847, 2849, 2917, 2919, 2961
    • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • fix: changed the print format modifier from "%llu" to "%"PRIu64 on lines 2949, 4605, 4609, 4879, 4886, 5083, 5206
    • warning: format specifies type 'long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • fix: changed the print format modifier from "%lld" to "%"PRIu64 on lines 5194, 5200
  2. cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c
    • warning: taking the absolute value of unsigned type 'unsigned long' has no effect [-Wabsolute-value]
      • fix: explicitly casted the two sides of the subtraction expression to (long) from (unsigned longs) because unsigned longs cannot become negative and will instead loop to the higher bound of the number limits
Jun 8 2017, 8:54 PM
aprieger_llnw.com created D11104: cddl/sbin/zpool build warning fixes.
Jun 8 2017, 8:25 PM
aprieger_llnw.com added a comment to D11100: cddl/sbin/zfs build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/d14e571d85c30c11f80c4a6cb4bb5071

  1. cddl/contrib/opensolaris/cmd/zfs/zfs_main.c
    • warning: format specifies type 'unsigned long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
      • fix: changed format modifier from "%llu" to "%"PRId64 on line 1332
    • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • fix: changed format modifier from "%llu" to "%"PRIu64 one lines 2075, 2184, 2188, 2551, 2622, 2630 and 5624
    • warning: field width should have type 'int', but argument has type 'size_t' (aka 'unsigned long') [-Wformat]
      • fix: added explicit modifier (int) to parameter on lines 2653, 2655, 2679, 2682, 2977, 2979, 3055, 3057 and 5632
    • warning: data argument not used by format string [-Wformat-extra-args]
      • fix: removed the data argument that was not used
    • warning: format string is not a string literal (potentially insecure) [-Wformat-security]
      • fix: added the modifier "%s" to print the string on lines 5206, 5261 and 5322
    • warning: field width should have type 'int', but argument has type 'unsigned long' [-Wformat]
      • fix: added explicit modifier (int) to parameters on line 5601
    • warning: format specifies type 'int' but the argument has type 'char *' [-Wformat]
      • fix: changed print format modifier from "%c" to "%s" on line 6102
Jun 8 2017, 6:59 PM
aprieger_llnw.com created D11100: cddl/sbin/zfs build warning fixes.
Jun 8 2017, 6:44 PM

Jun 7 2017

aprieger_llnw.com added a comment to D11083: cddl/lib/libzfs build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/af6068106b41143d8f67525a70bbe915

  1. cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c
    • Warnings:
      • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    • Fixes:
      • changed the print format modifier to "%"PRIu64 on lines 2401, 2967, 3024
  2. cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c
    • Warnings:
      • warning: format specifies type 'long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    • Fixes:
      • changed the print format modifier to "%"PRIu64 on lines 123, 417
  3. cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
    • Warnings:
      • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • warning: format specifies type 'long long' but the argument has type 'long' [-Wformat]
      • warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    • Fixes:
      • changed the print format modifier to "%"PRIu64 on lines 267, 366, 2524, 2559, 3214, 3811, 3821, 3843
      • changed the print format modifier to "%ld" on lines 1462, 1523
      • changed the print format modifier to "%"PRId64 on lines 1469, 1527
  4. cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c
    • Warnings:
      • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • warning: incompatible pointer to integer conversion assigning to 'uint64_t' (aka 'unsigned long') from 'void *' [-Wint-conversion]
    • Fixes:
      • changed the print format modifier to "%"PRIu64 on lines 590, 596
      • added the explicit modifier to NULL on lines 820, 821, 822
Jun 7 2017, 6:46 PM
aprieger_llnw.com created D11083: cddl/lib/libzfs build warning fixes.
Jun 7 2017, 6:32 PM

Jun 5 2017

aprieger_llnw.com updated the diff for D11031: usr.sbin/wpa/wpa_supplicant: build warning fixes.
Jun 5 2017, 9:17 PM
aprieger_llnw.com updated the diff for D11031: usr.sbin/wpa/wpa_supplicant: build warning fixes.

Edit: changed the format modification for "size_t" types from"%lu" to "%zu"

Jun 5 2017, 9:16 PM
aprieger_llnw.com added a comment to D11068: tests/sys/geom build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/3fda4ad7d4d0e1a11f6625f796fe8a80

  1. sys/geom/eli/pkcs5v2.c
    • Warnings:
      • warning: passing 'const char *' to parameter of type 'const uint8_t *' (aka 'const unsigned char *') converts between pointers to integer types with different sign [-Wpointer-sign]
      • warning: passing 'uint8_t [11]' to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]
    • Fixes:
      • added the explicit modifier "const uint8_t *" to parameter "passphrase" to prepare it for the function on line 72
      • added the explicit modifier "const char *" to parameter "passphrase" to prepare it for the function on line 103
Jun 5 2017, 8:56 PM
aprieger_llnw.com created D11068: tests/sys/geom build warning fixes.
Jun 5 2017, 8:52 PM
aprieger_llnw.com added a comment to D11067: usr.bin/elf2aout build warning fix.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/ec32a64f35be3e4f0d250da53310ea27

  1. usr.bin/elf2aout/elf2aout.c
    • Warnings:
      • warning: cast from 'char *' to 'Elf64_Phdr *' increases required alignment from 1 to 8 [-Wcast-align]
    • Fixes:
      • added the explicit modifier "void *" to the casting in order to force the alignment
Jun 5 2017, 8:22 PM
aprieger_llnw.com created D11067: usr.bin/elf2aout build warning fix.
Jun 5 2017, 8:18 PM
aprieger_llnw.com added a comment to D11063: kerberos5/lib/libkdc build warning fixes.

Changelog:
Pre-fix warnings are at: https://github.llnw.net/gist/aprieger/fc51f108152d4ef69f5c

  1. crypto/heimdal/kdc/digest.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 608
  2. crypto/heimdal/kdc/kerberos5.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 1299 and 1310
  3. crypto/heimdal/kdc/pkinit.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 104 and 126
Jun 5 2017, 6:45 PM
aprieger_llnw.com created D11063: kerberos5/lib/libkdc build warning fixes.
Jun 5 2017, 6:34 PM
aprieger_llnw.com added a comment to D11059: kerberos5/lib/libkrb5 some build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/84fc35f2fb992bb96da5e8bb88f03086

  1. crypto/heimdal/lib/krb5/rd_cred.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 225
  2. crypto/heimdal/lib/krb5/rd_priv.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 139
  3. crypto/heimdal/lib/krb5/rd_req.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 444
  4. crypto/heimdal/lib/krb5/rd_safe.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on line 162
  5. crypto/heimdal/lib/krb5/ticket.c
    • Warnings:
      • warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
    • Fixes:
      • changed the abs() function to labs() to handle the long argument on lines 779 and 783
Jun 5 2017, 6:03 PM
aprieger_llnw.com created D11059: kerberos5/lib/libkrb5 some build warning fixes.
Jun 5 2017, 5:44 PM

Jun 2 2017

aprieger_llnw.com added a comment to D11031: usr.sbin/wpa/wpa_supplicant: build warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/3a1e9084e4dde2b7e6675ce071c92d21

  1. contrib/wpa/src/drivers/driver_ndis.c
    • Warnings:
      • warning: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
      • warning: passing 'PTSTR' (aka 'char *') to parameter of type 'int8_t *' (aka 'signed char *') converts between pointers to integer types with different sign [-Wpointer-sign]
      • warning: passing 'char [128]' to parameter of type 'int8_t *' (aka 'signed char *') converts between pointers to integer types with different sign [-Wpointer-sign]
    • Fixes:
      • changed the string format type from "%d" to "%lu" to handle the "unsigned long" variable instead of "int" on lines 507, 513, 576, 1539, 1573, 1595, 1786
      • changed the string format type from "%d" to "%u" to handle the "unsigned int" variable instead of "int" on lines 513
      • added the explicit modifier "int8_t*" to variables on lines 2142, 2148, 2764, 3067, 3073
  2. contrib/wpa/src/drivers/Packet32.c
    • Warnings:
      • warning: passing 'int8_t *' (aka 'signed char *') to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • warning: assigning to 'char *' from 'int8_t *' (aka 'signed char *') converts between pointers to integer types with different sign [-Wpointer-sign]
    • Fixes:
      • added the explicit modifier "const char*" to variables on lines 128, 130, 136, 147
      • added the explicit modifer "char *" to variable on line 247
Jun 2 2017, 9:37 PM
aprieger_llnw.com created D11031: usr.sbin/wpa/wpa_supplicant: build warning fixes.
Jun 2 2017, 9:20 PM
aprieger_llnw.com added a comment to D11029: usr.sbin/ntp/libopts: build time warning fixes.

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/17436862ce2d27511eb0ba95d8e08e0a

  1. contrib/ntp/sntp/libopts/autoopts.c
    • Added a getWformatFree( ) function that merely return the const char* contents of the const char* input, to normalize the data
    • More documentation located in code
    • The strings are derived from two files: ao-strs.c and ao-strs.h which define the message structure and macros used by the applications
  2. contrib/ntp/sntp/libopts/enum.c
    • Warnings: this warning is consistent through the entire application
      • warning: format string contains '\0' within the string body [-Wformat]
    • Fixes:
      • Utilized getWformatFree( ) on the format strings of various print statements at lines 112, 135, 148, 155, 307 to suppress the warnings
  3. contrib/ntp/sntp/libopts/find.c
    • Warnings: this warning is consistent through the entire application
      • warning: format string contains '\0' within the string body [-Wformat]
    • Fixes:
      • Utilized getWformatFree( ) on the format strings of various print statements at lines 114, 119, 219, 432 to suppress the warnings
  4. contrib/ntp/sntp/libopts/makeshell.c
    • Warnings: this warning is consistent through the entire application
      • warning: format string contains '\0' within the string body [-Wformat]
    • Fixes:
      • Utilized getWformatFree( ) on the format strings of various print statements at lines 152, 162, 171, 183, 189, 200, 235, 386, 388, 391, 441, 537, 540, 543, 544, 549, 550, 552, 556, 559, 562, 569, 570, 573, 574, 577, 587, 590, 593, 596, 619, 694, 704 to suppress the warnings
  5. contrib/ntp/sntp/libopts/pgusage.c
    • Warnings: this warning is consistent through the entire application
      • warning: format string contains '\0' within the string body [-Wformat]
    • Fixes:
      • Utilized getWformatFree( ) on the format strings of various print statements at lines 48, 90 to suppress the warnings
  6. contrib/ntp/sntp/libopts/nested.c
    • Warnings: this warning is consistent through the entire application
      • warning: format string contains '\0' within the string body [-Wformat]
    • Fixes:
      • Utilized getWformatFree( ) on the format strings of various print statements at lines 928 to suppress the warnings
  7. contrib/ntp/sntp/libopts/putshell.c
    • Warnings: this warning is consistent through the entire application
      • warning: format string contains '\0' within the string body [-Wformat]
    • Fixes:
      • Utilized getWformatFree( ) on the format strings of various print statements at lines 190, 277, 283, 288, 297, 315, 330, 333, 336, 375, 403, 440, 451, 471, 483, 491, 493 to suppress the warnings
  8. contrib/ntp/sntp/libopts/save.c
    • Warnings: this warning is consistent through the entire application
      • warning: format string contains '\0' within the string body [-Wformat]
    • Fixes:
      • Utilized getWformatFree( ) on the format strings of various print statements at lines 351, 366, 386, 392, 396, 411, 439, 459, 463, 503, 556 to suppress the warnings
  9. contrib/ntp/sntp/libopts/usage.c
    • Warnings: this warning is consistent through the entire application
      • warning: format string contains '\0' within the string body [-Wformat]
    • Fixes:
      • Utilized getWformatFree( ) on the format strings of various print statements at lines 352, 357, 437 to suppress the warnings
Jun 2 2017, 5:23 PM
aprieger_llnw.com updated the summary of D11029: usr.sbin/ntp/libopts: build time warning fixes.
Jun 2 2017, 4:59 PM
aprieger_llnw.com created D11029: usr.sbin/ntp/libopts: build time warning fixes.
Jun 2 2017, 4:58 PM

Jun 1 2017

aprieger_llnw.com added a comment to D11019: usr.sbin/lpr/lpc: build warning fixes.

Changelog:

  1. usr.sbin/lpr/lpc/lpc.c
    • Warning
      • passing 'char *[20]' to parameter of type 'const char **' discards qualifiers in nested pointer types [-Wincompatible-pointer-types-discards-qualifiers]
    • Fix:
      • Explicitly cast the variable "margv" to const char ** only for it's use as a parameter to suppress the error
Jun 1 2017, 8:29 PM
aprieger_llnw.com created D11019: usr.sbin/lpr/lpc: build warning fixes.
Jun 1 2017, 8:22 PM

May 31 2017

aprieger_llnw.com retitled D11012: usr.sbin/sendmail: build warnings fixed from usr.sbin/sendmail: warnings fixed to usr.sbin/sendmail: build warnings fixed.
May 31 2017, 4:43 PM
aprieger_llnw.com retitled D11012: usr.sbin/sendmail: build warnings fixed from Sendmail: Warnings fixed to usr.sbin/sendmail: warnings fixed.
May 31 2017, 4:41 PM
aprieger_llnw.com added a comment to D11012: usr.sbin/sendmail: build warnings fixed.

Changelog:

  1. contrib/sendmail/src/envelope.c
    • Warnings
      • warning: format not a string literal and no format arguments [-Wformat-security]
    • Fixes:
      • Add the modifier "$s" to the "message( )" functions calls at line 221
  2. contrib/sendmail/src/parseaddr.c
    • Warnings:
      • warning: format not a string literal and no format arguments [-Wformat-security]
    • Fixes:
      • Add the modifier "$s" to the "message( )" functions calls at lines 326 & 423
  3. contrib/sendmail/src/srvrsmtp.c
    • Warnings:
      • warning: format not a string literal and no format arguments [-Wformat-security]
    • Fixes:
      • Add the modifier "$s" to the "usrerr( )" functions calls at lines 581, 587. 1852, 2455, 3662 & 3782
      • Add the modifier "$s" to the "message( )" functions calls at line 934
May 31 2017, 4:39 PM
aprieger_llnw.com retitled D11012: usr.sbin/sendmail: build warnings fixed from Sendmail: warning fixed to Sendmail: Warnings fixed.
May 31 2017, 4:30 PM
aprieger_llnw.com created D11012: usr.sbin/sendmail: build warnings fixed.
May 31 2017, 4:29 PM

May 30 2017

aprieger_llnw.com added a comment to D10995: tcp: tcpdchk & tcpdmatch: warning fixes.
  1. contrib/tcp_wrappers/tcpdchk.c
    • Replaced the function <getopt.h> with the library containing the function <unistd.h>
  2. contrib/tcp_wrappers/tcpdmatch.c
    • Replaced the function <getopt.h> with the library containing the function <unistd.h>
May 30 2017, 9:23 PM
aprieger_llnw.com updated the diff for D10995: tcp: tcpdchk & tcpdmatch: warning fixes.
  • tcp: tcpdchk & tcpdmatch: changed lib <getopt.h> to <unistd.h>
May 30 2017, 9:23 PM
aprieger_llnw.com added a comment to D10995: tcp: tcpdchk & tcpdmatch: warning fixes.

Changelog:

  1. contrib/tcp_wrappers/fakelog.c
    • Warnings for each of functions: openlog( ), vsyslog( ), VARARGS( ), closelog( )
      • warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
      • warning: control reaches end of non-void function [-Wreturn-type]
    • Fixes:
      • Explicitly added specification of function type to void for each function, suppressing both warnings for each function listed
  2. contrib/tcp_wrappers/inetcf.c
    • Warnings:
      • warning: incompativle redeclaration of library function 'malloc'
      • note: 'malloc' is a builtin with type 'void *(unsigned long)'
      • warning: implicit declaration of function 'check_path' is invalid in C99 [-Wimplicit-function-declaration]
    • Fixes:
      • Removed redeclaration of malloc on line 21
      • Included library <stdlib.h> in the code which contains the malloc( ) function in it's library
      • Included scaffold.h header file in the code that contains check-path( ) function
  3. contrib/tcp_wrappers/scaffold.c
    • Warnings:
      • warning: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Wimplicit-function-declaration]
      • note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'
    • Fixes:
      • Included <stdlib.h> in the code which contains the exit( ) function in it's library
  4. contrib/tcp_wrappers/tcpdchk.c
    • Warnings:
      • warning: implicit declaration of function 'getopt' is invalid in C99 [-Wimplicit-function-declaration]
      • warning: implicit declaration of function 'atoi' is invalid in C99 [-Wimplicit-function-declaration]
    • Fixes:
      • Included the specific function <getopt.h> library to the code
      • Included<stdlib.h> to the code which contains the atoi( ) function in the library
  5. contrib/tcp_wrappers/tcpdmatch.c
    • Warnings:
      • warning: implicit declaration of function 'getopt' is invalid in C99 [-Wimplicit-function-declaration]
    • Fixes:
      • Included<stdlib.h> to the code which contains the getopt( ) function in the library
May 30 2017, 7:26 PM
aprieger_llnw.com created D10995: tcp: tcpdchk & tcpdmatch: warning fixes.
May 30 2017, 6:55 PM