Differential D23023

Decrease logging severity when adding a device or reading config table.
ClosedPublic
Actions

Authored by markj on Jan 3 2020, 5:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 11:54 AM

	Unknown Object (File)
	Wed, Oct 30, 3:55 AM

	Unknown Object (File)
	Mon, Oct 28, 9:52 AM

	Unknown Object (File)
	Oct 4 2024, 8:45 PM

	Unknown Object (File)
	Oct 2 2024, 5:55 AM

	Unknown Object (File)
	Sep 5 2024, 10:55 PM

	Unknown Object (File)
	Aug 19 2024, 10:11 PM

	Unknown Object (File)
	Aug 19 2024, 11:56 AM

View All 54 Files

Subscribers

Details

Reviewers

deepak.ukey_microsemi.com
sbruno
scott.benesh_microsemi.com

Commits

rS356445: Decrease logging severity when adding a device or reading config table.

Summary

In PR 243056 a user reports some spamming from the driver. In
particular, the driver warns about PQI_CONF_TABLE_SECTION_SOFT_RESET
(not yet defined in the driver, but handled in Linux). The Linux driver
also does not warn about unrecognized sections.

Also do not log a warning when a device is added, since this is routine.
Lower severity to DISC, to match pqisrc_remove_device().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jan 3 2020, 5:21 PM

Harbormaster completed remote builds in B28462: Diff 66307.Jan 3 2020, 5:21 PM

markj added reviewers: deepak.ukey_microsemi.com, sbruno.Jan 3 2020, 5:21 PM

sbruno accepted this revision.Jan 3 2020, 5:52 PM

sbruno added a reviewer: scott.benesh_microsemi.com.

This revision is now accepted and ready to land.Jan 3 2020, 5:52 PM

Closed by commit rS356445: Decrease logging severity when adding a device or reading config table. (authored by markj). · Explain WhyJan 7 2020, 4:07 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS356445: Decrease logging severity when adding a device or reading config table..

Herald added a subscriber: imp. · View Herald TranscriptJan 7 2020, 4:07 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

smartpqi/

smartpqi_discovery.c

2 lines

smartpqi_init.c

2 lines

Diff 66441

head/sys/dev/smartpqi/smartpqi_discovery.c

Loading...

head/sys/dev/smartpqi/smartpqi_init.c

Loading...