Page MenuHomeFreeBSD

gnu/usr.bin/gdb/libgdb more build warning/bug fixes
Needs ReviewPublic

Authored by aprieger_llnw.com on Jul 24 2017, 8:33 PM.

Details

Reviewers
kbowling
sbruno
Summary

Code changes to fix warnings/bugs during buildtime for the application in the folder gnu/usr.bin/gdb/libgdb

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10641
Build 11045: arc lint + arc unit

Event Timeline

Changelog:
Pre-fix warnings located at: https://gist.github.com/aprieger-llnw/a952754f3c2a06a5cdbb7137d7612e77

  1. contrib/gdb/gdb/arch-utils.c
    • warning: warning: passing 'bfd_byte *' (aka 'unsigned char *') to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: added the (char*) explicit modifier on lines 58 and 60
  2. contrib/gdb/gdb/ax-gdb.c
    • warning: warning: 20 enumeration values not handled in switch: 'TYPE_CODE_UNDEF', 'TYPE_CODE_PTR', 'TYPE_CODE_INT'... [-Wswitch]
      • fix: added a default case that does nothing to handle the unhandled cases on line 746
  3. contrib/gdb/gdb/breakpoint.c
    • warning: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
      • fix: removed the extra parentheses on lines 2650 and 2662
    • warning: warning: expression result unused [-Wunused-value]
      • fix: removed the unused variable expression on line 5546

In-tree GDB is now disabled (rS368441) and being removed soon