Page MenuHomeFreeBSD

sysutils/cpu-microcode-*: Reorganize CPU microcode ports
ClosedPublic

Authored by jrm on Aug 10 2023, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 1:25 AM
Unknown Object (File)
Mon, Apr 8, 10:54 AM
Unknown Object (File)
Mar 14 2024, 2:50 AM
Unknown Object (File)
Mar 5 2024, 3:49 PM
Unknown Object (File)
Mar 5 2024, 3:46 PM
Unknown Object (File)
Mar 5 2024, 3:46 PM
Unknown Object (File)
Mar 5 2024, 3:46 PM
Unknown Object (File)
Mar 5 2024, 3:46 PM
Subscribers

Details

Summary

Prior to this update, sysutils/devcpu-data, which only contains an RC
script, had run dependencies on the AMD and Intel microcode ports. This
made it cumbersome to have just the AMD or just the Intel microcode
ports installed. With this change, the microcode ports now depend on
the RC script.

Other changes:

  • Use more intuitive port names: cpu-microcode, cpu-microcode-amd, cpu-microcode-intel, and cpu-microcode-rc.
  • Add the metaport, cpu-microcode, which pulls in all related ports.
  • Pet portclippy/portfmt

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm requested review of this revision.Aug 10 2023, 5:53 PM

I like the change overall. My one annoying/bikesheddy comment is, can we call them cpu-microcode-* instead of cpu-ucode-*? I don't think the terseness buys us anything, "microcode" is more amenable to searching (e.g., with pkg search), and the rc.d script is called microcode_update.

I like the change overall. My one annoying/bikesheddy comment is, can we call them cpu-microcode-* instead of cpu-ucode-*? I don't think the terseness buys us anything, "microcode" is more amenable to searching (e.g., with pkg search), and the rc.d script is called microcode_update.

Not bikesheddy to me. I think it's a good point and will make that change later today. Thanks.

Change new port names from cpu-ucode-* to cpu-microcode-*.

jrm retitled this revision from sysutils/cpu-ucode-*: Reorganize CPU microcode ports to sysutils/cpu-microcode-*: Reorganize CPU microcode ports.Aug 10 2023, 7:03 PM
jrm edited the summary of this revision. (Show Details)

Thanks very much for implementing this idea!

A minor point: since we have port/package names changed, do you think we can also change the PORTVERSION of cpu-microcode and cpu-microcode-rc to something like 1.0 as they don't need to reflect the snapshot date.

This revision is now accepted and ready to land.Aug 11 2023, 4:01 AM

sysutils/cpu-microcode-rc/distinfo contains TIMESTAMP only, I think it can be removed.

Thank you!

sysutils/cpu-microcode-rc/files/pkg-message.in
22–23

I think there should be a comma after "here".

sysutils/cpu-microcode/pkg-descr
2

Incorporate suggestions from lwhsu and markj

  • tweak cpu-microcode/pkg-descr
  • add missing comma for nonrestrictive clause in devcpu-data/files/pkg-message.in
  • remove unnecessary sysutils/cpu-microcode-rc/distinfo

The only suggestion I didn't incorporate was changing PORTVERSION of
cpu-microcode and cpu-microcode-rc from a datestamp to 1.0. Help me understand
why PORTVERSION=1.0 is better than a datestamp and I'll make the change.

This revision now requires review to proceed.Aug 12 2023, 2:02 PM
jrm marked 2 inline comments as done.Aug 12 2023, 2:07 PM
This revision is now accepted and ready to land.Aug 14 2023, 1:52 PM
In D41406#943556, @jrm wrote:

The only suggestion I didn't incorporate was changing PORTVERSION of
cpu-microcode and cpu-microcode-rc from a datestamp to 1.0. Help me understand
why PORTVERSION=1.0 is better than a datestamp and I'll make the change.

I don't have strong opinion about this. My preference is because that these two ports contain the things we developed locally and don't like in other two ports, it represents the snapshot date. Thus we can use semantic versioning (https://semver.org/). And in the past, people didn't aware it and just bump all the date-style PORTVERSION

Switch value of PORTVERSION in sysutils/cpu-microcode and sysutils/cpu-microcode-rc from datastamps to semantic versions

This revision now requires review to proceed.Aug 15 2023, 2:44 PM
This revision is now accepted and ready to land.Aug 15 2023, 2:45 PM

Nice work. This looks good to me. Thank you for implementing this.