Page MenuHomeFreeBSD

Use callout(9) instead of deprecated timeout(9).
Needs ReviewPublic

Authored by jhb on Thu, Nov 28, 8:27 PM.

Details

Reviewers
imp
sbruno
Test Plan
  • only compiled, not tested

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 28071
Build 26216: arc lint + arc unit

Event Timeline

jhb created this revision.Thu, Nov 28, 8:27 PM
sbruno resigned from this revision.Fri, Nov 29, 1:17 AM

I don't have access to this hardware. I can't test the changes here.

imp accepted this revision.Fri, Nov 29, 1:51 AM
This revision is now accepted and ready to land.Fri, Nov 29, 1:51 AM
jhb added a subscriber: sbruno.Fri, Nov 29, 5:06 PM

@sbruno Do you have a PoC for this driver?

imp added a comment.Sat, Nov 30, 2:45 AM
In D22598#494383, @jhb wrote:

@sbruno Do you have a PoC for this driver?

IIRC, it was from HP. But I'm not sure how well PQI with SOP has been accepted in the marketplace...

In D22598#494456, @imp wrote:
In D22598#494383, @jhb wrote:

@sbruno Do you have a PoC for this driver?

IIRC, it was from HP. But I'm not sure how well PQI with SOP has been accepted in the marketplace...

Well, we seem to be selling lots of cards. :) I'll have the developers update our code base and test out these changes.

imp added a comment.Fri, Dec 6, 6:42 PM
In D22598#494456, @imp wrote:
In D22598#494383, @jhb wrote:

@sbruno Do you have a PoC for this driver?

IIRC, it was from HP. But I'm not sure how well PQI with SOP has been accepted in the marketplace...

Well, we seem to be selling lots of cards. :) I'll have the developers update our code base and test out these changes.

Awesome! That's good feedback to get! Thanks for having your team look at it

jhb updated this revision to Diff 65482.Wed, Dec 11, 12:28 AM

Don't pass CALLOUT_MPSAFE to callout_init().

This revision now requires review to proceed.Wed, Dec 11, 12:28 AM