Page MenuHomeFreeBSD

dtrace: Disable getf() as it is broken on FreeBSD.
ClosedPublic

Authored by domagoj.stolfa_gmail.com on Dec 10 2021, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 2:12 PM
Unknown Object (File)
Sep 15 2025, 1:12 AM
Unknown Object (File)
Sep 14 2025, 6:31 AM
Unknown Object (File)
Sep 14 2025, 3:20 AM
Unknown Object (File)
Sep 8 2025, 11:36 PM
Unknown Object (File)
Sep 3 2025, 5:24 PM
Unknown Object (File)
Aug 31 2025, 9:22 PM
Unknown Object (File)
Aug 16 2025, 11:30 PM
Subscribers

Details

Summary

getf() on FreeBSD calls _sx_slock(), _sx_sunlock() and fget_locked().
Furthermore, it does not set the per-core fault flag, meaning it
usually ends up in a double fault panic once getf() does get called,
especially from fbt.

Reviewing the DTrace Toolkit + a number of other scripts scattered
around FreeBSD, I have not been able to find one use of getf(). Given
how broken the implementation currently is, we disable it until it
can be implemented properly.

Also comment out a test in aggs/tst.subr.d for getf().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable