Page MenuHomeFreeBSD

sef (Sean Eric Fagan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2018, 3:36 AM (75 w, 1 d)

Recent Activity

Tue, Oct 1

sef committed rS352932: Fix a regression introduced in r344601, and work properly with the.
Fix a regression introduced in r344601, and work properly with the
Tue, Oct 1, 6:06 PM
sef committed rS352924: MFC r352580: Fix a regression introduced in r344601 for zfs send.
MFC r352580: Fix a regression introduced in r344601 for zfs send
Tue, Oct 1, 3:36 AM

Sat, Sep 28

sef added inline comments to D21807: VirtIO SCSI online disk resize.
Sat, Sep 28, 10:17 PM

Tue, Sep 24

sef added a comment to D21646: vfs: add root vnode caching for mount points.
In D21646#475415, @mjg wrote:

The new op is *not* called by anything but the new handler which has to be explicitly set by filesystems which want the feature, i.e. the change is a no-op for anyone who does not opt in.

Tue, Sep 24, 10:39 PM
sef added inline comments to D21646: vfs: add root vnode caching for mount points.
Tue, Sep 24, 10:33 PM
sef added a comment to D21646: vfs: add root vnode caching for mount points.

There is no way to get a "default" implementation for this.

Tue, Sep 24, 10:32 PM
sef added a comment to D21646: vfs: add root vnode caching for mount points.

Perhaps I'm confused, but since you've added a new VFS operation, shouldn't there be a default implementation? You mention doing this for ZFS, but it's only there for tmpfs and UFS; does this need to be a VFS function, or should it be done as part of the mount structure and maintenance functions?

Tue, Sep 24, 10:26 PM

Sep 23 2019

sef committed rS352614: Add two options to allow mount to avoid covering up existing mount points..
Add two options to allow mount to avoid covering up existing mount points.
Sep 23 2019, 4:28 AM
sef closed D21458: Add mount options to prevent covering.
Sep 23 2019, 4:28 AM

Sep 21 2019

sef updated the diff for D21458: Add mount options to prevent covering.

Remove thread argument to vfs_emptydir. Also remove a blank line. Per kib.

Sep 21 2019, 6:42 PM
sef added a comment to D21458: Add mount options to prevent covering.

The td arg is still there.

Sep 21 2019, 6:40 PM
sef added a comment to D21458: Add mount options to prevent covering.

Any further comments on this? I'd gotten an OOB message from Josh about this. If not, I'll make sure it's still functional and plan on committing this weekend or Monday.

Sep 21 2019, 6:19 PM
sef committed rS352580: Fix a regression introduced in r344601, and work properly with the.
Fix a regression introduced in r344601, and work properly with the
Sep 21 2019, 5:54 PM
sef closed D21709: Fix zfs send -v, -P, -n, and -V again.
Sep 21 2019, 5:54 PM

Sep 18 2019

sef created D21709: Fix zfs send -v, -P, -n, and -V again.
Sep 18 2019, 9:40 PM

Sep 15 2019

sef updated the diff for D21458: Add mount options to prevent covering.

I forgot to add the assertion kib suggested. (NB, still doesn't have the td changes we discussed.)

Sep 15 2019, 9:01 PM

Sep 14 2019

sef abandoned D21660: Ask sync(8) to sync multiple times.

More discussion about it than it's worth. Ah well.

Sep 14 2019, 8:43 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.
In D21660#472249, @avg wrote:

Or add a sleep instead of additional sync-s. And how do you know that 3 will always be enough?

Sep 14 2019, 8:43 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.

BTW, you marked it as needing revision, but didn't say what revision.

Sep 14 2019, 8:39 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.

Could you please tell more about this?

Sep 14 2019, 8:38 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.

If you need more than one sync, then you've broken posix semantics.

Sep 14 2019, 8:35 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.

If you think that it's useful and sync 3 would be an improvement, then could you please explain why?

Sep 14 2019, 8:29 PM
sef created D21660: Ask sync(8) to sync multiple times.
Sep 14 2019, 8:17 PM
sef added inline comments to D21458: Add mount options to prevent covering.
Sep 14 2019, 8:10 PM
sef added inline comments to D21458: Add mount options to prevent covering.
Sep 14 2019, 7:40 PM
sef updated the diff for D21458: Add mount options to prevent covering.

Small change from kib feedback.

Sep 14 2019, 5:52 PM
sef added inline comments to D21458: Add mount options to prevent covering.
Sep 14 2019, 5:51 PM

Sep 13 2019

sef updated the diff for D21458: Add mount options to prevent covering.

More changes due to feedback from kib. Thanks!

Sep 13 2019, 11:36 PM
sef added a comment to D21458: Add mount options to prevent covering.

New update coming in.

Sep 13 2019, 11:35 PM
sef updated the diff for D21458: Add mount options to prevent covering.

Feedback from kib.

Sep 13 2019, 7:16 PM
sef added a comment to D21458: Add mount options to prevent covering.

Updated diff coming in a few seconds.

Sep 13 2019, 7:16 PM

Sep 11 2019

sef added a comment to D21458: Add mount options to prevent covering.

Ping, anyone?

Sep 11 2019, 11:15 PM

Sep 6 2019

sef updated the diff for D21458: Add mount options to prevent covering.

Feedback from Alan.

Sep 6 2019, 6:37 PM
sef added inline comments to D21458: Add mount options to prevent covering.
Sep 6 2019, 6:36 PM

Sep 5 2019

sef added a comment to D21458: Add mount options to prevent covering.

Ping?

Sep 5 2019, 5:57 PM

Sep 3 2019

sef committed rS351730: MFC r343881, r343882.
MFC r343881, r343882
Sep 3 2019, 4:50 AM

Sep 1 2019

sef added a comment to D21458: Add mount options to prevent covering.

Add support for having "cover" and "noemptydir" to the options parsing.

Sep 1 2019, 3:00 AM

Aug 29 2019

D21458: Add mount options to prevent covering now requires review to proceed.

Update the man page dates per reminder.

Aug 29 2019, 5:08 PM

Aug 28 2019

sef created D21458: Add mount options to prevent covering.
Aug 28 2019, 8:06 PM
sef abandoned D15446: AES CCM-CBC cryptography code.
Aug 28 2019, 7:32 PM

Aug 13 2019

sef accepted D20477: Introduce stats(3).
Aug 13 2019, 6:12 PM
sef accepted D20116: Introduce <sys/qmath.h>.
Aug 13 2019, 6:11 PM

Jun 28 2019

sef added inline comments to D20116: Introduce <sys/qmath.h>.
Jun 28 2019, 8:50 PM
sef added a comment to D20477: Introduce stats(3).

Still no examples, but linking to the consumer helps.

Jun 28 2019, 6:33 PM

Jun 25 2019

sef added a comment to D20116: Introduce <sys/qmath.h>.

As for rounding - the bugs section, which mentioned them, is gone. The code is just a fixed-point library, so the rounding is what one would expect, I suppose: stuff gets truncated according to the radix point. Should I document it somehow?

Jun 25 2019, 5:33 PM

Jun 22 2019

sef added a comment to D20584: add a linux compatible copy_file_range(2) syscall.

This much work in the kernel for what should be user-space makes me twitchy... but there is lots of precedent for it, so I obviously have to get with the times.

Jun 22 2019, 5:27 AM

Jun 13 2019

sef added a comment to D20116: Introduce <sys/qmath.h>.

I'm too old for the world.

Jun 13 2019, 8:57 PM
sef added a comment to D20116: Introduce <sys/qmath.h>.

The spilt-up man pages are much better. The examples definitely help a lot. But now I'm wondering about things like rounding -- the obvious usage that occurred to me here was, ahem, ZZZZZZ9.99, to borrow from a long-ago past :).

Jun 13 2019, 7:51 PM

Jun 5 2019

sef added a comment to D20116: Introduce <sys/qmath.h>.

This mostly seems ok -- it's pretty much nothing but a man page and header file, after all -- but my biggest complaint is that the man page is exceedingly complicated, and does not provide any real examples. The examples would also be a good way to show the justification for the code.

Jun 5 2019, 12:48 AM

Jun 4 2019

sef committed rS348664: Add my birthday entry, per Kirk's request.
Add my birthday entry, per Kirk's request
Jun 4 2019, 7:06 PM

Jun 3 2019

sef added a comment to D20477: Introduce stats(3).

I'd like to see some example usages.

Jun 3 2019, 10:59 PM
sef added inline comments to D20477: Introduce stats(3).
Jun 3 2019, 9:03 PM

May 25 2019

sef committed rS348268: Add an AESNI-optimized version of the CCM/CBC cryptographic and authentication.
Add an AESNI-optimized version of the CCM/CBC cryptographic and authentication
May 25 2019, 7:26 AM
sef closed D19298: AESNI version of CCM+CBC-MAC.
May 25 2019, 7:26 AM

May 24 2019

sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

A bit late, but the updated diff promised. Thanks cem & jhb!

May 24 2019, 6:17 PM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

Doing testing with the changes, then I'll upload the diffs.

May 24 2019, 2:29 AM

May 23 2019

sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

I'll get to those tomorrow, thanks! (Various stuff going on today has thrown my schedule off.)

May 23 2019, 12:36 AM

May 3 2019

sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

The promised updated diffs.

May 3 2019, 8:14 PM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

I'm updating and build testing before uploading new diffs.

May 3 2019, 5:54 PM

May 1 2019

sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

Poke?

May 1 2019, 10:57 PM

Apr 24 2019

sef accepted D20043: Don't panic for empty CCM requests..

Something made me think that it was not acceptable, but now I can't remember what it was, so it's clearly wrong.

Apr 24 2019, 10:46 PM

Apr 10 2019

sef accepted D19853: [security/nist-kat]: Add AES-CCM and plain SHA digest test vectors..
Apr 10 2019, 7:35 PM
sef added inline comments to D19298: AESNI version of CCM+CBC-MAC.
Apr 10 2019, 6:33 PM
sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

I lost the length descriptor prefix in the last change. I've put it back, and run cryptocheck with -A lengths of 0, 13, 16, 32, 192102, and 127091. (User-space can't test more than 256k unfortunately.)

Apr 10 2019, 6:30 PM
sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

Review feedback incorporated.

Apr 10 2019, 2:06 AM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

New diff coming right after this.

Apr 10 2019, 2:05 AM

Apr 8 2019

sef added inline comments to D19298: AESNI version of CCM+CBC-MAC.
Apr 8 2019, 6:51 PM

Apr 6 2019

sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

(I'll go through the rest of the comments this weekend.)

Apr 6 2019, 12:27 AM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.
In D19298#425490, @cem wrote:

In this implementation, I'm not sure the 2-pass decrypt buys us anything. We already pre-allocate space (if input is non-contiguous) — checking the tag first doesn't save us from a DoS in terms of memory use. If the (unexpected case) tag verification fails, we'd need to do extra work to clobber anything we output, maybe? I might be forgetting something about CCM.

Apr 6 2019, 12:26 AM

Apr 4 2019

sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

Per feedback from cem, remove aes_block_t. Note that I did use a uint8_t pointer for some of the work, rather than having annoying typecasts in function calls.

Apr 4 2019, 8:38 PM
sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

Changed the GMAC_DIGEST_LEN uses to be sizeof(tag).

Apr 4 2019, 7:27 PM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

Responses to cem; a new patch incoming.

Apr 4 2019, 7:24 PM

Mar 28 2019

sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

Implement some (but not all, due to asking some questions) of the feedback from cem@.

Mar 28 2019, 10:01 PM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

Respond to cem. Updated diff to follow.

Mar 28 2019, 10:00 PM

Mar 27 2019

sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

Ping anyone?

Mar 27 2019, 8:59 PM

Mar 14 2019

sef committed rS345124: MFC r344140,r344141,r344142,r344143,r344388,r344547.
MFC r344140,r344141,r344142,r344143,r344388,r344547
Mar 14 2019, 2:46 AM

Mar 11 2019

sef committed rS344998: MFC r343882.
MFC r343882
Mar 11 2019, 3:02 AM
sef committed rS344997: MFC r343881.
MFC r343881
Mar 11 2019, 3:00 AM
sef committed rS344995: MFC r344402.
MFC r344402
Mar 11 2019, 2:43 AM

Mar 1 2019

sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

Ping?

Mar 1 2019, 8:13 PM
sef added a comment to D19153: Handle SIGPIPE in gssd, and limit kgssapi RPC retries.
In D19153#415697, @avg wrote:

Somewhat belated question, would it make sense to mark the client created in sys_gssd_syscall() as interruptible?

Mar 1 2019, 5:58 PM

Feb 27 2019

sef committed rS344630: Have cryptocheck toggle kern.cryptodevallowsoft if necessary (this.
Have cryptocheck toggle kern.cryptodevallowsoft if necessary (this
Feb 27 2019, 7:27 PM
sef closed D19372: Have cryptocheck toggle kern.cryptodevallowsoft as needed.
Feb 27 2019, 7:27 PM
sef updated the diff for D19372: Have cryptocheck toggle kern.cryptodevallowsoft as needed.

Feedback from jhb. (Just uploaded for completeness sake; I'll be checking it in after I update my svn source, apply the patch, and do a buildworld just to make sure I didn't do anything stupid again.)

Feb 27 2019, 6:53 PM
sef added inline comments to D19372: Have cryptocheck toggle kern.cryptodevallowsoft as needed.
Feb 27 2019, 6:52 PM
sef updated the diff for D19372: Have cryptocheck toggle kern.cryptodevallowsoft as needed.

Move the #includes around per cem.

Feb 27 2019, 12:16 AM
sef added inline comments to D19372: Have cryptocheck toggle kern.cryptodevallowsoft as needed.
Feb 27 2019, 12:16 AM

Feb 26 2019

sef created D19372: Have cryptocheck toggle kern.cryptodevallowsoft as needed.
Feb 26 2019, 11:05 PM
sef committed rS344601: Set process title during zfs send..
Set process title during zfs send.
Feb 26 2019, 7:23 PM
sef closed D19184: Set process title during zfs send.
Feb 26 2019, 7:23 PM

Feb 25 2019

sef updated the diff for D19184: Set process title during zfs send.

mav pointed out that I'd missed the same changes to zfs_send_resume.

Feb 25 2019, 11:17 PM
sef committed rS344547: Fix another bug introduced during the review process of r344140:.
Fix another bug introduced during the review process of r344140:
Feb 25 2019, 7:14 PM

Feb 24 2019

sef added a comment to D19184: Set process title during zfs send.

Ping?

Feb 24 2019, 9:05 PM

Feb 23 2019

sef accepted D19098: Parallel zfs mounting.

Seems generally fine to me, although I haven't looked at the ZoL side for comparison.

Feb 23 2019, 7:51 AM
sef abandoned D17066: AES CCM-CBC cryptography code.
Feb 23 2019, 5:53 AM

Feb 22 2019

sef created D19298: AESNI version of CCM+CBC-MAC.
Feb 22 2019, 8:39 PM
sef added inline comments to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.
Feb 22 2019, 8:15 PM · ZFS

Feb 21 2019

sef committed rS344451: Fix the usage error I introduced in r344192..
Fix the usage error I introduced in r344192.
Feb 21 2019, 10:49 PM
sef committed rS344402: * Handle SIGPIPE in gssd.
* Handle SIGPIPE in gssd
Feb 21 2019, 1:30 AM
sef closed D19153: Handle SIGPIPE in gssd, and limit kgssapi RPC retries.
Feb 21 2019, 1:30 AM