- User Since
- May 15 2018, 3:36 AM (48 w, 4 d)
Wed, Apr 10
I lost the length descriptor prefix in the last change. I've put it back, and run cryptocheck with -A lengths of 0, 13, 16, 32, 192102, and 127091. (User-space can't test more than 256k unfortunately.)
Review feedback incorporated.
New diff coming right after this.
Mon, Apr 8
Sat, Apr 6
(I'll go through the rest of the comments this weekend.)
Thu, Apr 4
Per feedback from cem, remove aes_block_t. Note that I did use a uint8_t pointer for some of the work, rather than having annoying typecasts in function calls.
Changed the GMAC_DIGEST_LEN uses to be sizeof(tag).
Responses to cem; a new patch incoming.
Thu, Mar 28
Implement some (but not all, due to asking some questions) of the feedback from cem@.
Respond to cem. Updated diff to follow.
Wed, Mar 27
Mar 14 2019
Mar 11 2019
Mar 1 2019
Feb 27 2019
Feedback from jhb. (Just uploaded for completeness sake; I'll be checking it in after I update my svn source, apply the patch, and do a buildworld just to make sure I didn't do anything stupid again.)
Move the #includes around per cem.
Feb 26 2019
Feb 25 2019
mav pointed out that I'd missed the same changes to zfs_send_resume.
Feb 24 2019
Feb 23 2019
Seems generally fine to me, although I haven't looked at the ZoL side for comparison.
Feb 22 2019
Feb 21 2019
Feb 20 2019
Feb 19 2019
Feb 18 2019
Feb 17 2019
Feb 16 2019
Feb 15 2019
Update the man page date.
Warn if the virtual hostname argument is too long. (Note that this is only a warning.)
Fixed the date in the man page (although I guess it's already wrong :)), and don't set the virtual host if it's too long.
Feb 14 2019
I was going to upload a new diff, but just got email that you've got more comments :).
I diff'd the wrong source tree. I just made sure this one built, and produced the correct results, e.g.
Feb 13 2019
Feb 12 2019
Took Rick's advice and moved the retry setting to a more specific place.
Feb 11 2019
Updating because I changed the CBC-MAC revision.
Feedback from cem (thanks!).
Feb 10 2019
Ping? Is this one ok to go?
Feb 7 2019
I changed my #ifdef CRYPT_DEBUG back to #if 0 in the parent branch/review, so this has the new version of that.
Per discussion in my other review, revert my change for the crypto debug macro ifdef.
Feb 6 2019
Feb 5 2019
Feb 1 2019
Switch to using a single type macro.
Jan 31 2019
Jan 30 2019
Jan 25 2019
Ok, seems good to me then.
Hm, this will break the output. For the better, I think. Does it need a man page change as well?