Page MenuHomeFreeBSD

sef (Sean Eric Fagan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2018, 3:36 AM (39 w, 6 d)

Recent Activity

Yesterday

sef added a comment to D19184: Set process title during zfs send.

This might be a dumb question, but does the process title change often enough that setproctitle_fast() added in rS335939 should be used?

Sun, Feb 17, 8:44 PM

Sat, Feb 16

sef committed rS344192: Add support for a virtual hostname to nfsd.
Add support for a virtual hostname to nfsd
Sat, Feb 16, 12:16 AM
sef closed D19191: Add support for a virtual hostname to nfsd.
Sat, Feb 16, 12:16 AM

Fri, Feb 15

sef updated the diff for D19184: Set process title during zfs send.

Update the man page date.

Fri, Feb 15, 6:54 PM
sef updated the diff for D19191: Add support for a virtual hostname to nfsd.

Warn if the virtual hostname argument is too long. (Note that this is only a warning.)

Fri, Feb 15, 6:44 PM
sef added a comment to D19191: Add support for a virtual hostname to nfsd.

Thanks for adding the strlen() check. I am going to be nitpicky and suggest an
error message be printed (not sure if the nfsd should fail or just log an error?),
since silently ignoring the "-V" argument could cause confusion too, I think?

Fri, Feb 15, 5:32 PM
sef updated the diff for D19191: Add support for a virtual hostname to nfsd.

Fixed the date in the man page (although I guess it's already wrong :)), and don't set the virtual host if it's too long.

Fri, Feb 15, 7:18 AM
sef committed rS344143: Fix another issue from r344141, having to do with size of a shift amount..
Fix another issue from r344141, having to do with size of a shift amount.
Fri, Feb 15, 4:15 AM
sef committed rS344142: Pasting in a source control line missed the last quote. Fixed..
Pasting in a source control line missed the last quote. Fixed.
Fri, Feb 15, 4:02 AM
sef committed rS344141: Add AES-CCM encryption, and plumb into OCF..
Add AES-CCM encryption, and plumb into OCF.
Fri, Feb 15, 3:53 AM
sef closed D19090: Add AES-CCM encryption.
Fri, Feb 15, 3:53 AM
sef committed rS344140: Add CBC-MAC authentication..
Add CBC-MAC authentication.
Fri, Feb 15, 3:47 AM
sef closed D18592: Add CBC-MAC authentication code.
Fri, Feb 15, 3:47 AM

Thu, Feb 14

sef added inline comments to D19090: Add AES-CCM encryption.
Thu, Feb 14, 9:21 PM
sef updated the diff for D19090: Add AES-CCM encryption.

cem's feedback.

Thu, Feb 14, 9:05 PM
sef added a comment to D19090: Add AES-CCM encryption.

I was going to upload a new diff, but just got email that you've got more comments :).

Thu, Feb 14, 9:04 PM
sef updated the diff for D19090: Add AES-CCM encryption.

Feedback from jhb.

Thu, Feb 14, 8:24 PM
sef added inline comments to D19090: Add AES-CCM encryption.
Thu, Feb 14, 8:23 PM
sef created D19191: Add support for a virtual hostname to nfsd.
Thu, Feb 14, 6:08 AM
sef added a comment to D19090: Add AES-CCM encryption.

Ping?

Thu, Feb 14, 3:34 AM
sef updated the diff for D19184: Set process title during zfs send.

I diff'd the wrong source tree. I just made sure this one built, and produced the correct results, e.g.

Thu, Feb 14, 1:21 AM

Wed, Feb 13

sef added a comment to D19184: Set process title during zfs send.

Ah I didn't realized that we haven't upstreamed it & thanks for forward-porting it for so many years...

Wed, Feb 13, 9:57 PM
sef created D19184: Set process title during zfs send.
Wed, Feb 13, 9:40 PM

Tue, Feb 12

sef updated the diff for D19153: Handle SIGPIPE in gssd, and limit kgssapi RPC retries.

Took Rick's advice and moved the retry setting to a more specific place.

Tue, Feb 12, 2:09 AM
sef added a reviewer for D19153: Handle SIGPIPE in gssd, and limit kgssapi RPC retries: dfr.
Tue, Feb 12, 1:42 AM

Mon, Feb 11

sef created D19153: Handle SIGPIPE in gssd, and limit kgssapi RPC retries.
Mon, Feb 11, 11:52 PM
sef updated the diff for D19090: Add AES-CCM encryption.

Updating because I changed the CBC-MAC revision.

Mon, Feb 11, 6:33 AM
sef updated the diff for D18592: Add CBC-MAC authentication code.

Feedback from cem (thanks!).

Mon, Feb 11, 6:32 AM
sef added inline comments to D18592: Add CBC-MAC authentication code.
Mon, Feb 11, 6:32 AM

Sun, Feb 10

sef added a comment to D18592: Add CBC-MAC authentication code.

Ping? Is this one ok to go?

Sun, Feb 10, 10:08 PM

Thu, Feb 7

sef committed rS343882: r343881 had an uninitialized error. This fixes that..
r343881 had an uninitialized error. This fixes that.
Thu, Feb 7, 10:10 PM
sef committed rS343881: r339008 broke repquota for UFS. This rectifies that..
r339008 broke repquota for UFS. This rectifies that.
Thu, Feb 7, 9:51 PM
sef closed D18785: Fix quotas for UFS after r339008.
Thu, Feb 7, 9:51 PM
sef added a reviewer for D18785: Fix quotas for UFS after r339008: delphij.
Thu, Feb 7, 8:48 PM
sef updated the diff for D19090: Add AES-CCM encryption.

I changed my #ifdef CRYPT_DEBUG back to #if 0 in the parent branch/review, so this has the new version of that.

Thu, Feb 7, 1:42 AM
sef updated the diff for D18592: Add CBC-MAC authentication code.

Per discussion in my other review, revert my change for the crypto debug macro ifdef.

Thu, Feb 7, 1:41 AM
sef updated the diff for D19090: Add AES-CCM encryption.

Feedback from cem.

Thu, Feb 7, 12:55 AM
sef added inline comments to D19090: Add AES-CCM encryption.
Thu, Feb 7, 12:55 AM

Wed, Feb 6

sef added a reviewer for D19090: Add AES-CCM encryption: mmacy.
Wed, Feb 6, 7:35 PM
sef created D19090: Add AES-CCM encryption.
Wed, Feb 6, 12:44 AM
sef added a child revision for D18592: Add CBC-MAC authentication code: D19090: Add AES-CCM encryption.
Wed, Feb 6, 12:44 AM

Tue, Feb 5

sef added a comment to D18592: Add CBC-MAC authentication code.
In D18592#408160, @jhb wrote:

I'm generally happy with this. The #if 0 -> #ifdef CRYPTO_DEBUG change still seems unrelated, but I don't care strongly about it either way.

Tue, Feb 5, 7:12 PM

Fri, Feb 1

sef added a comment to D18592: Add CBC-MAC authentication code.
In D18592#407488, @cem wrote:

I meant the second half of the sentence — are you still working on feedback or not?

Fri, Feb 1, 9:09 PM
sef added a comment to D18592: Add CBC-MAC authentication code.
In D18592#407486, @cem wrote:
In D18592#400076, @sef wrote:

NB: This is mostly tested simply by compilation, as I've still got some more feedback to incorporate.

Is this still the case or do you figure you've finished that? I was waiting for that to wrap up before I took another look.

Fri, Feb 1, 9:02 PM
sef added a comment to D18592: Add CBC-MAC authentication code.

! In D18592#407482, @cem wrote:
Thanks!

Fri, Feb 1, 8:54 PM
sef updated the diff for D18592: Add CBC-MAC authentication code.

Switch to using a single type macro.

Fri, Feb 1, 8:18 PM
sef added inline comments to D18592: Add CBC-MAC authentication code.
Fri, Feb 1, 7:34 PM
sef added inline comments to D18592: Add CBC-MAC authentication code.
Fri, Feb 1, 7:19 PM
sef added inline comments to D18592: Add CBC-MAC authentication code.
Fri, Feb 1, 6:57 PM

Thu, Jan 31

sef committed rS343624: MFC r342928:.
MFC r342928:
Thu, Jan 31, 10:08 PM
sef committed rS343623: MFC r342928:.
MFC r342928:
Thu, Jan 31, 10:07 PM

Wed, Jan 30

sef added inline comments to D18592: Add CBC-MAC authentication code.
Wed, Jan 30, 2:02 AM
sef added inline comments to D18592: Add CBC-MAC authentication code.
Wed, Jan 30, 1:56 AM

Fri, Jan 25

sef accepted D18958: align nfsdumpstate column output.

Ok, seems good to me then.

Fri, Jan 25, 5:41 PM
sef added a comment to D18958: align nfsdumpstate column output.

Hm, this will break the output. For the better, I think. Does it need a man page change as well?

Fri, Jan 25, 5:32 PM

Wed, Jan 23

sef added a comment to D18592: Add CBC-MAC authentication code.

Prod?

Wed, Jan 23, 2:20 AM

Jan 11 2019

sef committed rS342928: Change ZFS quotas to return EINVAL when not present (matches man page)..
Change ZFS quotas to return EINVAL when not present (matches man page).
Jan 11 2019, 2:54 AM

Jan 8 2019

sef created D18785: Fix quotas for UFS after r339008.
Jan 8 2019, 7:56 PM

Jan 7 2019

sef added inline comments to D18592: Add CBC-MAC authentication code.
Jan 7 2019, 5:29 PM
sef committed rS342841: MFC r341641: Reduce number of DNS queries in mountd..
MFC r341641: Reduce number of DNS queries in mountd.
Jan 7 2019, 5:59 AM

Jan 5 2019

sef updated the diff for D18592: Add CBC-MAC authentication code.

More changes due to feedback. Biggest one being a change to the _Update and _Final routines.

Jan 5 2019, 7:14 AM

Jan 2 2019

sef updated the diff for D18592: Add CBC-MAC authentication code.

More response to feedback from cem. Still incomplete; I have to refactor the code a bit to deal with unexpected usage patterns.

Jan 2 2019, 7:54 PM
sef added inline comments to D18592: Add CBC-MAC authentication code.
Jan 2 2019, 7:53 PM
sef added a comment to D18592: Add CBC-MAC authentication code.
In D18592#398160, @cem wrote:

I don't know there are any you can directly copy. These two I know of might be useful for inspiration:

Jan 2 2019, 7:24 PM

Dec 27 2018

sef updated the diff for D18592: Add CBC-MAC authentication code.

This doesn't have all of cem's comments handled, so there'll be more; this is to get a snapshot in place before I start doing some network changes at home.

Dec 27 2018, 9:47 PM
sef added inline comments to D18592: Add CBC-MAC authentication code.
Dec 27 2018, 9:45 PM

Dec 24 2018

sef added a comment to D18592: Add CBC-MAC authentication code.

Where are similar ones for AES-GCM that I can copy? :)

https://csrc.nist.gov/CSRC/media/Projects/Cryptographic-Algorithm-Validation-Program/documents/mac/gcmtestvectors.zip

Dec 24 2018, 11:35 PM
sef updated the diff for D18592: Add CBC-MAC authentication code.

Feedback from cem. This won't be the final version.

Dec 24 2018, 11:35 PM
sef added inline comments to D18592: Add CBC-MAC authentication code.
Dec 24 2018, 11:34 PM
sef added a comment to D18592: Add CBC-MAC authentication code.

There's a lot for me to digest, thanks!

Dec 24 2018, 11:06 PM

Dec 17 2018

sef created D18592: Add CBC-MAC authentication code.
Dec 17 2018, 10:05 PM
sef added a comment to D18520: Update opencrypto for ZFS crypto.

They should be fully independent algorithms / steps, even if they don't have a consumer until the last step. If they're integrated in a way that they can't be separated and at least compile, I think that's a problem.

Dec 17 2018, 8:58 PM
sef added a comment to D18520: Update opencrypto for ZFS crypto.
In D18520#394737, @cem wrote:
  1. adding the CBC-MAC soft implementations (AES_CBC_MAC_foo, "ccm-cbc.c"). I don't think there's any real reason to call it ccm-cbc.c instead of cbc-mac, since it is a independent algorithm in its own right.
  2. adding the CCM soft implementations (I'm not really clear where these are or how this works; the exf struction points to aes_icm for everything except reinit).
  3. adding CCM/CBC to cryptodev along with some basic tests
Dec 17 2018, 6:45 PM

Dec 13 2018

sef updated the diff for D18522: AES iov optimization.

Re-implemented per cem's feedback. Tested with cryptocheck.

Dec 13 2018, 1:58 AM

Dec 12 2018

sef added inline comments to D18522: AES iov optimization.
Dec 12 2018, 7:24 PM
sef added a reviewer for D18522: AES iov optimization: mmacy.
Dec 12 2018, 3:59 AM
sef created D18522: AES iov optimization.
Dec 12 2018, 3:59 AM

Dec 11 2018

sef added inline comments to D18520: Update opencrypto for ZFS crypto.
Dec 11 2018, 11:31 PM
sef added a comment to D18520: Update opencrypto for ZFS crypto.

mmacy, there should be changes for cryptocheck as well.

Dec 11 2018, 11:26 PM

Dec 6 2018

sef closed D18430: Reduce mountd DNS queries.
Dec 6 2018, 6:22 PM
sef committed rS341641: Reduce number of DNS queries in mountd..
Reduce number of DNS queries in mountd.
Dec 6 2018, 6:22 PM
sef added a comment to D18430: Reduce mountd DNS queries.
In D18430#392768, @mav wrote:

Generally looks good to me, except one cosmetic issue -- the line seems to go beyond 80 columns, so it would be nice to re-wrap it earlier.

Dec 6 2018, 2:37 AM
sef updated the diff for D18430: Reduce mountd DNS queries.

Fix the larger-than-80-columns I got from using the wrong window for my editing.

Dec 6 2018, 2:37 AM

Dec 4 2018

sef created D18430: Reduce mountd DNS queries.
Dec 4 2018, 10:15 PM

Nov 29 2018

sef committed rS341171: MFC r340442.
MFC r340442
Nov 29 2018, 1:06 AM
sef committed rS341170: MFC r340442.
MFC r340442
Nov 29 2018, 1:06 AM

Nov 14 2018

sef committed rS340442: mountd has no way to configure the listen queue depth; rather than add a new.
mountd has no way to configure the listen queue depth; rather than add a new
Nov 14 2018, 7:07 PM

Nov 9 2018

sef accepted D17927: Do not ignore arc_adjust() return value.
Nov 9 2018, 11:50 PM

Oct 11 2018

sef added inline comments to D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:13 PM · ZFS
sef added a comment to D17495: Fix deadlock in IO pipeline.

Looks ok to me.

Oct 11 2018, 3:52 AM

Oct 1 2018

sef committed rS339034: MFC r334844, r336180, r336458.
MFC r334844, r336180, r336458
Oct 1 2018, 4:09 AM

Sep 29 2018

sef committed rS339008: MFC r336017,r338799.
MFC r336017,r338799
Sep 29 2018, 12:44 AM

Sep 26 2018

sef committed rS338953: Add per-session locking to cryptosoft (swcr)..
Add per-session locking to cryptosoft (swcr).
Sep 26 2018, 8:23 PM
sef closed D17307: Per-session locking for cryptosoft.
Sep 26 2018, 8:23 PM

Sep 25 2018

sef added a comment to D17307: Per-session locking for cryptosoft.

I have been unable to reproduce that panic, even on the same machine.

Sep 25 2018, 11:32 PM
sef added a comment to D17307: Per-session locking for cryptosoft.

On a system with GELI swap, moving the lock until after the call to crypto_done() resulted in a panic (page fault while lock held). That doesn't make any sense to me. Changing it back to what I had initially resulted in a successful boot. So I'm going to be investigating this a bit more.

Sep 25 2018, 7:41 PM
sef updated the diff for D17307: Per-session locking for cryptosoft.

Turn a blank line into a real blank line.

Sep 25 2018, 6:10 PM
sef updated the diff for D17307: Per-session locking for cryptosoft.

But without the cryptocheck changes.

Sep 25 2018, 5:09 PM
sef updated the diff for D17307: Per-session locking for cryptosoft.

Upload the _right_ diff file.

Sep 25 2018, 5:07 PM
sef updated the diff for D17307: Per-session locking for cryptosoft.

Per feedback from mav and cem, move the unlock to before the callback..

Sep 25 2018, 5:03 PM