Page MenuHomeFreeBSD

sef (Sean Eric Fagan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2018, 3:36 AM (30 w, 6 d)

Recent Activity

Thu, Dec 13

sef updated the diff for D18522: AES iov optimization.

Re-implemented per cem's feedback. Tested with cryptocheck.

Thu, Dec 13, 1:58 AM

Wed, Dec 12

sef added inline comments to D18522: AES iov optimization.
Wed, Dec 12, 7:24 PM
sef added a reviewer for D18522: AES iov optimization: mmacy.
Wed, Dec 12, 3:59 AM
sef created D18522: AES iov optimization.
Wed, Dec 12, 3:59 AM

Tue, Dec 11

sef added inline comments to D18520: Update opencrypto for ZFS crypto.
Tue, Dec 11, 11:31 PM
sef added a comment to D18520: Update opencrypto for ZFS crypto.

mmacy, there should be changes for cryptocheck as well.

Tue, Dec 11, 11:26 PM

Thu, Dec 6

sef closed D18430: Reduce mountd DNS queries.
Thu, Dec 6, 6:22 PM
sef committed rS341641: Reduce number of DNS queries in mountd..
Reduce number of DNS queries in mountd.
Thu, Dec 6, 6:22 PM
sef added a comment to D18430: Reduce mountd DNS queries.
In D18430#392768, @mav wrote:

Generally looks good to me, except one cosmetic issue -- the line seems to go beyond 80 columns, so it would be nice to re-wrap it earlier.

Thu, Dec 6, 2:37 AM
sef updated the diff for D18430: Reduce mountd DNS queries.

Fix the larger-than-80-columns I got from using the wrong window for my editing.

Thu, Dec 6, 2:37 AM

Tue, Dec 4

sef created D18430: Reduce mountd DNS queries.
Tue, Dec 4, 10:15 PM

Thu, Nov 29

sef committed rS341171: MFC r340442.
MFC r340442
Thu, Nov 29, 1:06 AM
sef committed rS341170: MFC r340442.
MFC r340442
Thu, Nov 29, 1:06 AM

Nov 14 2018

sef committed rS340442: mountd has no way to configure the listen queue depth; rather than add a new.
mountd has no way to configure the listen queue depth; rather than add a new
Nov 14 2018, 7:07 PM

Nov 9 2018

sef accepted D17927: Do not ignore arc_adjust() return value.
Nov 9 2018, 11:50 PM

Oct 11 2018

sef added inline comments to D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:13 PM · ZFS
sef added a comment to D17495: Fix deadlock in IO pipeline.

Looks ok to me.

Oct 11 2018, 3:52 AM

Oct 1 2018

sef committed rS339034: MFC r334844, r336180, r336458.
MFC r334844, r336180, r336458
Oct 1 2018, 4:09 AM

Sep 29 2018

sef committed rS339008: MFC r336017,r338799.
MFC r336017,r338799
Sep 29 2018, 12:44 AM

Sep 26 2018

sef committed rS338953: Add per-session locking to cryptosoft (swcr)..
Add per-session locking to cryptosoft (swcr).
Sep 26 2018, 8:23 PM
sef closed D17307: Per-session locking for cryptosoft.
Sep 26 2018, 8:23 PM

Sep 25 2018

sef added a comment to D17307: Per-session locking for cryptosoft.

I have been unable to reproduce that panic, even on the same machine.

Sep 25 2018, 11:32 PM
sef added a comment to D17307: Per-session locking for cryptosoft.

On a system with GELI swap, moving the lock until after the call to crypto_done() resulted in a panic (page fault while lock held). That doesn't make any sense to me. Changing it back to what I had initially resulted in a successful boot. So I'm going to be investigating this a bit more.

Sep 25 2018, 7:41 PM
sef updated the diff for D17307: Per-session locking for cryptosoft.

Turn a blank line into a real blank line.

Sep 25 2018, 6:10 PM
sef updated the diff for D17307: Per-session locking for cryptosoft.

But without the cryptocheck changes.

Sep 25 2018, 5:09 PM
sef updated the diff for D17307: Per-session locking for cryptosoft.

Upload the _right_ diff file.

Sep 25 2018, 5:07 PM
sef updated the diff for D17307: Per-session locking for cryptosoft.

Per feedback from mav and cem, move the unlock to before the callback..

Sep 25 2018, 5:03 PM
sef added inline comments to D17307: Per-session locking for cryptosoft.
Sep 25 2018, 4:57 PM
sef added a comment to D17307: Per-session locking for cryptosoft.

I didn't profile it too much; I just walked through the code and saw that, with Reinit, the key schedule would get changed, and without locking, that could cause some problems.

Sep 25 2018, 12:33 AM

Sep 24 2018

sef updated the diff for D17307: Per-session locking for cryptosoft.

Ran the diff in the correct directory this time. Sorry.

Sep 24 2018, 11:46 PM
sef added a comment to D17307: Per-session locking for cryptosoft.
In D17307#368980, @cem wrote:

This diff seems to be missing the part where the lock is taken.

Sep 24 2018, 11:45 PM
sef created D17307: Per-session locking for cryptosoft.
Sep 24 2018, 11:37 PM

Sep 20 2018

sef accepted D17233: zfs: depessimize zfs_root with rmlocks.
Sep 20 2018, 11:30 PM
sef added a comment to D17233: zfs: depessimize zfs_root with rmlocks.

The ZFS side seems fine to me (I defer to stronger backgrounds on the VFS interactions).

Sep 20 2018, 11:30 PM

Sep 7 2018

sef updated the summary of D17066: AES CCM-CBC cryptography code.
Sep 7 2018, 4:43 PM
sef updated the diff for D17066: AES CCM-CBC cryptography code.

Feedback from mav -- removed some zfs crypto changes in sys/conf/files, and change the constants for the crypto algorithms.

Sep 7 2018, 4:43 PM

Sep 6 2018

sef created D17066: AES CCM-CBC cryptography code.
Sep 6 2018, 9:22 PM

Jul 18 2018

sef committed rS336458: Fix a couple of typos in r334844 noticed by Richard Kojedzinszky..
Fix a couple of typos in r334844 noticed by Richard Kojedzinszky.
Jul 18 2018, 4:03 PM

Jul 10 2018

sef committed rS336180: Fix up some missed and mis-merges from the sequential scan code.
Fix up some missed and mis-merges from the sequential scan code
Jul 10 2018, 8:11 PM

Jul 5 2018

sef committed rS336017: This exposes ZFS user and group quotas via the normal.
This exposes ZFS user and group quotas via the normal
Jul 5 2018, 10:56 PM
sef closed D15886: Expose ZFS quotas over nfs.
Jul 5 2018, 10:56 PM

Jun 18 2018

sef added a comment to D15886: Expose ZFS quotas over nfs.
In D15886#336048, @sef wrote:

Is it possible to provide a switch to disable the SETQUOTA RPC?

Sorry, I meant a command line option to rpc.rquotad if it's not clear.

Jun 18 2018, 8:08 PM
sef updated the diff for D15886: Expose ZFS quotas over nfs.

Incorporate feedback from delphij.

Jun 18 2018, 7:17 PM
sef added a comment to D15886: Expose ZFS quotas over nfs.

Is it possible to provide a switch to disable the SETQUOTA RPC?

Jun 18 2018, 7:16 PM
sef created D15886: Expose ZFS quotas over nfs.
Jun 18 2018, 6:30 PM

Jun 16 2018

sef committed rS334844: This originated from ZFS On Linux, as.
This originated from ZFS On Linux, as
Jun 16 2018, 7:51 AM
sef closed D15562: ZFS sorted scans.
Jun 16 2018, 7:51 AM · ZFS

Jun 8 2018

sef added a comment to D15562: ZFS sorted scans.

Checked in as r334844.

Jun 8 2018, 5:39 PM · ZFS
sef updated the diff for D15562: ZFS sorted scans.

Alexander pointed out that what I'd undone a change (range_tree_create()) because I'd ported from our 11-base system. Fixed that, and scrubbed a system a few times.

Jun 8 2018, 2:18 PM · ZFS

Jun 3 2018

sef added inline comments to D15446: AES CCM-CBC cryptography code.
Jun 3 2018, 1:39 AM

Jun 2 2018

sef added a comment to D15446: AES CCM-CBC cryptography code.

Then why wasn't the RFC noted in the comments then? There is the NIST version as well, which is what I was looking at originally.

Jun 2 2018, 5:33 PM
sef added a comment to D15446: AES CCM-CBC cryptography code.

Yes, we have done this before. When I did the GCM work under contract for the FreeBSD Foundation, they paid for a third party reviewer to go over the code and make sure it was correct. So, yes, we have done this before.

Jun 2 2018, 5:19 PM

May 31 2018

sef updated the diff for D15446: AES CCM-CBC cryptography code.

Rewrote the AESNI decryption function to not leak the data. Added a link to the RFC I used as the specification. Cleaned up some code a bit. Became the first consumer of the aesencdec.h inline function.

May 31 2018, 5:37 PM

May 28 2018

sef added a comment to D15446: AES CCM-CBC cryptography code.

I was unable to review that the code matches an implementation, as the code does not state what implementation it implements. Even if I review it, a professional cryptographer needs to be paid to review the code before it is committed/enabled for general use.

May 28 2018, 12:41 AM

May 26 2018

sef added a comment to D15562: ZFS sorted scans.
In D15562#329076, @mav wrote:

I don't think it is a very good idea to merge two pretty much independent ZoL commits into one FreeBSD commit. It could have sense if the first one would be significantly broken and second fixed the issue, but priority upgrade implemented in second commit is only a performance optimization, mostly unrelated to scrub even, in which case having it separate would make commit history cleaner for later comparison.

May 26 2018, 3:06 AM · ZFS
sef updated the diff for D15562: ZFS sorted scans.

A late sequential-scan-related patch was mentioned when I created the PR for OpenZFS, it's at https://github.com/zfsonlinux/zfs/commit/a8b2e30685c9214c

May 26 2018, 2:42 AM · ZFS

May 25 2018

sef updated the diff for D15446: AES CCM-CBC cryptography code.

Somehow my copy of tcpdump's README got tweaked and in the diff. I've removed it.

May 25 2018, 5:24 PM
sef added a comment to D15562: ZFS sorted scans.
In D15562#328648, @avg wrote:

Just a quick question, is this the same change that was recently presented at OpenZFS summit (http://open-zfs.org/w/images/a/a0/Saso_-_resilver_update.pdf)?
Or an alternative to it?

May 25 2018, 6:33 AM · ZFS
sef updated the diff for D15446: AES CCM-CBC cryptography code.

Even though it exits, I should have a va_end() because otherwise someone will use it as an example.

May 25 2018, 4:39 AM

May 24 2018

sef added a comment to D15446: AES CCM-CBC cryptography code.

Mostly LGTM. Is there a reason to keep these #if 0's in tools/tools/crypto/cryptocheck.c?

May 24 2018, 8:23 PM
sef created D15562: ZFS sorted scans.
May 24 2018, 8:00 PM · ZFS

May 21 2018

sef updated the diff for D15446: AES CCM-CBC cryptography code.

Fix the fixable parts of mav's feedback. (cryptocheck.c remains the same, per my response to him.)

May 21 2018, 5:10 PM
sef updated the diff for D15446: AES CCM-CBC cryptography code.

I wrote AESNI code for AES-CCM+CBC-MAC.

May 21 2018, 3:29 AM

May 15 2018

sef updated the diff for D15446: AES CCM-CBC cryptography code.

Per Alexander, I created a different, more-contextful, diff.

May 15 2018, 6:27 PM
sef created D15446: AES CCM-CBC cryptography code.
May 15 2018, 6:00 PM