- User Since
- May 15 2018, 3:36 AM (58 w, 2 d)
Tue, Jun 25
As for rounding - the bugs section, which mentioned them, is gone. The code is just a fixed-point library, so the rounding is what one would expect, I suppose: stuff gets truncated according to the radix point. Should I document it somehow?
Sat, Jun 22
This much work in the kernel for what should be user-space makes me twitchy... but there is lots of precedent for it, so I obviously have to get with the times.
Thu, Jun 13
I'm too old for the world.
The spilt-up man pages are much better. The examples definitely help a lot. But now I'm wondering about things like rounding -- the obvious usage that occurred to me here was, ahem, ZZZZZZ9.99, to borrow from a long-ago past :).
Wed, Jun 5
This mostly seems ok -- it's pretty much nothing but a man page and header file, after all -- but my biggest complaint is that the man page is exceedingly complicated, and does not provide any real examples. The examples would also be a good way to show the justification for the code.
Tue, Jun 4
Mon, Jun 3
I'd like to see some example usages.
May 25 2019
May 24 2019
A bit late, but the updated diff promised. Thanks cem & jhb!
Doing testing with the changes, then I'll upload the diffs.
May 23 2019
I'll get to those tomorrow, thanks! (Various stuff going on today has thrown my schedule off.)
May 3 2019
The promised updated diffs.
I'm updating and build testing before uploading new diffs.
May 1 2019
Apr 24 2019
Something made me think that it was not acceptable, but now I can't remember what it was, so it's clearly wrong.
Apr 10 2019
I lost the length descriptor prefix in the last change. I've put it back, and run cryptocheck with -A lengths of 0, 13, 16, 32, 192102, and 127091. (User-space can't test more than 256k unfortunately.)
Review feedback incorporated.
New diff coming right after this.
Apr 8 2019
Apr 6 2019
(I'll go through the rest of the comments this weekend.)
Apr 4 2019
Per feedback from cem, remove aes_block_t. Note that I did use a uint8_t pointer for some of the work, rather than having annoying typecasts in function calls.
Changed the GMAC_DIGEST_LEN uses to be sizeof(tag).
Responses to cem; a new patch incoming.
Mar 28 2019
Implement some (but not all, due to asking some questions) of the feedback from cem@.
Respond to cem. Updated diff to follow.
Mar 27 2019
Mar 14 2019
Mar 11 2019
Mar 1 2019
Feb 27 2019
Feedback from jhb. (Just uploaded for completeness sake; I'll be checking it in after I update my svn source, apply the patch, and do a buildworld just to make sure I didn't do anything stupid again.)
Move the #includes around per cem.
Feb 26 2019
Feb 25 2019
mav pointed out that I'd missed the same changes to zfs_send_resume.
Feb 24 2019
Feb 23 2019
Seems generally fine to me, although I haven't looked at the ZoL side for comparison.
Feb 22 2019
Feb 21 2019
Feb 20 2019
Feb 19 2019
Feb 18 2019
Feb 17 2019
Feb 16 2019
Feb 15 2019
Update the man page date.
Warn if the virtual hostname argument is too long. (Note that this is only a warning.)
Fixed the date in the man page (although I guess it's already wrong :)), and don't set the virtual host if it's too long.
Feb 14 2019
I was going to upload a new diff, but just got email that you've got more comments :).
I diff'd the wrong source tree. I just made sure this one built, and produced the correct results, e.g.
Feb 13 2019
Feb 12 2019
Took Rick's advice and moved the retry setting to a more specific place.
Feb 11 2019
Updating because I changed the CBC-MAC revision.
Feedback from cem (thanks!).
Feb 10 2019
Ping? Is this one ok to go?
Feb 7 2019
I changed my #ifdef CRYPT_DEBUG back to #if 0 in the parent branch/review, so this has the new version of that.
Per discussion in my other review, revert my change for the crypto debug macro ifdef.