Page MenuHomeFreeBSD

sef (Sean Eric Fagan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2018, 3:36 AM (305 w, 2 h)

Recent Activity

Jan 14 2023

sef committed rGf32db406504e: Allow a comma-separated list in login class capabilities, (authored by sef).
Allow a comma-separated list in login class capabilities,
Jan 14 2023, 6:49 PM
sef updated the diff for D25368: Allow comma in login.conf capabilities.

Changes based on Allan's comments:

  • Moved a comment around
  • Changed the name of a variable to have its purpose clearer
  • Updated a comment to reflect the current prototype
Jan 14 2023, 2:41 PM

Mar 11 2022

sef committed R9:5ab3b7f42a0d: Re-add my gpg key. (authored by Sean Eric Fagan <sef@kithrup.com>).
Re-add my gpg key.
Mar 11 2022, 5:02 PM

Nov 12 2021

sef accepted D32931: zfs: Fix a deadlock between page busy and the teardown lock.

Thanks

Nov 12 2021, 3:30 PM

Nov 11 2021

sef accepted D32931: zfs: Fix a deadlock between page busy and the teardown lock.

The code looks fine (small change, after all), other than my request for comments. :)

Nov 11 2021, 1:11 AM

May 30 2021

sef committed rG505dc43562d9: The zone(9) man page had two entries for uma_reclaim(), one with (authored by sef).
The zone(9) man page had two entries for uma_reclaim(), one with
May 30 2021, 8:03 PM

May 18 2021

sef accepted D30309: md5: Create md5sum, etc compatible programs.
May 18 2021, 3:45 AM

May 17 2021

sef accepted D30309: md5: Create md5sum, etc compatible programs.

lgtm.

May 17 2021, 5:30 AM

May 13 2021

sef added a comment to D30255: style: Relax 80 column rule.

I still use an 80 character limit, and an 80 character-wide Terminal window.

May 13 2021, 10:10 PM
sef accepted D30254: style: tweak tab after #define advice.
May 13 2021, 10:01 PM

Jul 11 2020

sef added a comment to D24801: Allow ls to list extattrs on a file.

I think the best way forward is to start with -@ first and leave -l output as it is, at first.

Jul 11 2020, 7:42 PM

Jul 10 2020

sef added a comment to D24801: Allow ls to list extattrs on a file.

Ping? Anyone?

Jul 10 2020, 5:20 PM

Jul 1 2020

sef accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 1 2020, 11:21 PM

Jun 21 2020

sef accepted D25312: Relax the rule against declaring variables in nested scopes..

Long long long overdue.

Jun 21 2020, 6:19 AM

Jun 20 2020

sef requested review of D25368: Allow comma in login.conf capabilities.
Jun 20 2020, 12:22 AM

Jun 18 2020

sef added a comment to D24801: Allow ls to list extattrs on a file.

Ping?

Jun 18 2020, 9:18 AM

May 27 2020

sef added inline comments to D24801: Allow ls to list extattrs on a file.
May 27 2020, 8:10 PM

May 24 2020

sef added inline comments to D24801: Allow ls to list extattrs on a file.
May 24 2020, 1:58 AM

May 15 2020

sef added inline comments to D24801: Allow ls to list extattrs on a file.
May 15 2020, 5:58 PM
sef added inline comments to D24801: Allow ls to list extattrs on a file.
May 15 2020, 5:54 PM

May 10 2020

sef added a comment to D24801: Allow ls to list extattrs on a file.

Oh, an example output:

May 10 2020, 8:46 PM
sef requested review of D24801: Allow ls to list extattrs on a file.
May 10 2020, 8:44 PM

Mar 8 2020

sef added a comment to D23722: Allow default mount options for ZFS.

I have not forgotten about this; I'm working on another aspect of this (dataset properties), and am holding off on committing this a bit.

Mar 8 2020, 12:49 AM

Feb 24 2020

sef added a comment to D23722: Allow default mount options for ZFS.

Ping anyone?

Feb 24 2020, 7:13 AM
sef added a reviewer for D23722: Allow default mount options for ZFS: ZFS.
Feb 24 2020, 7:13 AM

Feb 17 2020

sef updated the diff for D23722: Allow default mount options for ZFS.
Feb 17 2020, 1:37 AM
sef added a comment to D23722: Allow default mount options for ZFS.

New version coming now. Thanks!

Feb 17 2020, 1:36 AM

Feb 16 2020

sef created D23722: Allow default mount options for ZFS.
Feb 16 2020, 10:03 PM

Nov 13 2019

sef added inline comments to D22353: elf_aux_info: Add support for AT_EXECPATH..
Nov 13 2019, 9:35 PM
sef accepted D22353: elf_aux_info: Add support for AT_EXECPATH..
Nov 13 2019, 9:32 PM

Nov 10 2019

sef accepted D22271: Create /etc/os-release file..

My only concern involves the /etc symlink possibly pointing at a non-existent file. This is a small concern not worth preventing this.

Nov 10 2019, 6:16 AM

Nov 3 2019

sef added a comment to D22224: zfs: fix spurious lock contention during path lookup.

Great, thanks! :) I'll go over it in more detail over the next few days.

Nov 3 2019, 1:01 AM
sef added a comment to D22224: zfs: fix spurious lock contention during path lookup.

A quick skim and the main question I had is: no acl check?

Nov 3 2019, 12:58 AM

Oct 1 2019

sef committed rS352932: Fix a regression introduced in r344601, and work properly with the.
Fix a regression introduced in r344601, and work properly with the
Oct 1 2019, 6:06 PM
sef committed rS352924: MFC r352580: Fix a regression introduced in r344601 for zfs send.
MFC r352580: Fix a regression introduced in r344601 for zfs send
Oct 1 2019, 3:36 AM

Sep 28 2019

sef added inline comments to D21807: VirtIO SCSI online disk resize.
Sep 28 2019, 10:17 PM

Sep 24 2019

sef added a comment to D21646: vfs: add root vnode caching for mount points.
In D21646#475415, @mjg wrote:

The new op is *not* called by anything but the new handler which has to be explicitly set by filesystems which want the feature, i.e. the change is a no-op for anyone who does not opt in.

Sep 24 2019, 10:39 PM
sef added inline comments to D21646: vfs: add root vnode caching for mount points.
Sep 24 2019, 10:33 PM
sef added a comment to D21646: vfs: add root vnode caching for mount points.

There is no way to get a "default" implementation for this.

Sep 24 2019, 10:32 PM
sef added a comment to D21646: vfs: add root vnode caching for mount points.

Perhaps I'm confused, but since you've added a new VFS operation, shouldn't there be a default implementation? You mention doing this for ZFS, but it's only there for tmpfs and UFS; does this need to be a VFS function, or should it be done as part of the mount structure and maintenance functions?

Sep 24 2019, 10:26 PM

Sep 23 2019

sef committed rS352614: Add two options to allow mount to avoid covering up existing mount points..
Add two options to allow mount to avoid covering up existing mount points.
Sep 23 2019, 4:28 AM
sef closed D21458: Add mount options to prevent covering.
Sep 23 2019, 4:28 AM

Sep 21 2019

sef updated the diff for D21458: Add mount options to prevent covering.

Remove thread argument to vfs_emptydir. Also remove a blank line. Per kib.

Sep 21 2019, 6:42 PM
sef added a comment to D21458: Add mount options to prevent covering.

The td arg is still there.

Sep 21 2019, 6:40 PM
sef added a comment to D21458: Add mount options to prevent covering.

Any further comments on this? I'd gotten an OOB message from Josh about this. If not, I'll make sure it's still functional and plan on committing this weekend or Monday.

Sep 21 2019, 6:19 PM
sef committed rS352580: Fix a regression introduced in r344601, and work properly with the.
Fix a regression introduced in r344601, and work properly with the
Sep 21 2019, 5:54 PM
sef closed D21709: Fix zfs send -v, -P, -n, and -V again.
Sep 21 2019, 5:54 PM

Sep 18 2019

sef created D21709: Fix zfs send -v, -P, -n, and -V again.
Sep 18 2019, 9:40 PM

Sep 15 2019

sef updated the diff for D21458: Add mount options to prevent covering.

I forgot to add the assertion kib suggested. (NB, still doesn't have the td changes we discussed.)

Sep 15 2019, 9:01 PM

Sep 14 2019

sef abandoned D21660: Ask sync(8) to sync multiple times.

More discussion about it than it's worth. Ah well.

Sep 14 2019, 8:43 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.
In D21660#472249, @avg wrote:

Or add a sleep instead of additional sync-s. And how do you know that 3 will always be enough?

Sep 14 2019, 8:43 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.

BTW, you marked it as needing revision, but didn't say what revision.

Sep 14 2019, 8:39 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.

Could you please tell more about this?

Sep 14 2019, 8:38 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.

If you need more than one sync, then you've broken posix semantics.

Sep 14 2019, 8:35 PM
sef added a comment to D21660: Ask sync(8) to sync multiple times.

If you think that it's useful and sync 3 would be an improvement, then could you please explain why?

Sep 14 2019, 8:29 PM
sef created D21660: Ask sync(8) to sync multiple times.
Sep 14 2019, 8:17 PM
sef added inline comments to D21458: Add mount options to prevent covering.
Sep 14 2019, 8:10 PM
sef added inline comments to D21458: Add mount options to prevent covering.
Sep 14 2019, 7:40 PM
sef updated the diff for D21458: Add mount options to prevent covering.

Small change from kib feedback.

Sep 14 2019, 5:52 PM
sef added inline comments to D21458: Add mount options to prevent covering.
Sep 14 2019, 5:51 PM

Sep 13 2019

sef updated the diff for D21458: Add mount options to prevent covering.

More changes due to feedback from kib. Thanks!

Sep 13 2019, 11:36 PM
sef added a comment to D21458: Add mount options to prevent covering.

New update coming in.

Sep 13 2019, 11:35 PM
sef updated the diff for D21458: Add mount options to prevent covering.

Feedback from kib.

Sep 13 2019, 7:16 PM
sef added a comment to D21458: Add mount options to prevent covering.

Updated diff coming in a few seconds.

Sep 13 2019, 7:16 PM

Sep 11 2019

sef added a comment to D21458: Add mount options to prevent covering.

Ping, anyone?

Sep 11 2019, 11:15 PM

Sep 6 2019

sef updated the diff for D21458: Add mount options to prevent covering.

Feedback from Alan.

Sep 6 2019, 6:37 PM
sef added inline comments to D21458: Add mount options to prevent covering.
Sep 6 2019, 6:36 PM

Sep 5 2019

sef added a comment to D21458: Add mount options to prevent covering.

Ping?

Sep 5 2019, 5:57 PM

Sep 3 2019

sef committed rS351730: MFC r343881, r343882.
MFC r343881, r343882
Sep 3 2019, 4:50 AM

Sep 1 2019

sef added a comment to D21458: Add mount options to prevent covering.

Add support for having "cover" and "noemptydir" to the options parsing.

Sep 1 2019, 3:00 AM

Aug 29 2019

D21458: Add mount options to prevent covering now requires review to proceed.

Update the man page dates per reminder.

Aug 29 2019, 5:08 PM

Aug 28 2019

sef created D21458: Add mount options to prevent covering.
Aug 28 2019, 8:06 PM
sef abandoned D15446: AES CCM-CBC cryptography code.
Aug 28 2019, 7:32 PM

Aug 13 2019

sef accepted D20477: Introduce stats(3).
Aug 13 2019, 6:12 PM
sef accepted D20116: Introduce <sys/qmath.h>.
Aug 13 2019, 6:11 PM

Jun 28 2019

sef added inline comments to D20116: Introduce <sys/qmath.h>.
Jun 28 2019, 8:50 PM
sef added a comment to D20477: Introduce stats(3).

Still no examples, but linking to the consumer helps.

Jun 28 2019, 6:33 PM

Jun 25 2019

sef added a comment to D20116: Introduce <sys/qmath.h>.

As for rounding - the bugs section, which mentioned them, is gone. The code is just a fixed-point library, so the rounding is what one would expect, I suppose: stuff gets truncated according to the radix point. Should I document it somehow?

Jun 25 2019, 5:33 PM

Jun 22 2019

sef added a comment to D20584: add a linux compatible copy_file_range(2) syscall.

This much work in the kernel for what should be user-space makes me twitchy... but there is lots of precedent for it, so I obviously have to get with the times.

Jun 22 2019, 5:27 AM

Jun 13 2019

sef added a comment to D20116: Introduce <sys/qmath.h>.

I'm too old for the world.

Jun 13 2019, 8:57 PM
sef added a comment to D20116: Introduce <sys/qmath.h>.

The spilt-up man pages are much better. The examples definitely help a lot. But now I'm wondering about things like rounding -- the obvious usage that occurred to me here was, ahem, ZZZZZZ9.99, to borrow from a long-ago past :).

Jun 13 2019, 7:51 PM

Jun 5 2019

sef added a comment to D20116: Introduce <sys/qmath.h>.

This mostly seems ok -- it's pretty much nothing but a man page and header file, after all -- but my biggest complaint is that the man page is exceedingly complicated, and does not provide any real examples. The examples would also be a good way to show the justification for the code.

Jun 5 2019, 12:48 AM

Jun 4 2019

sef committed rS348664: Add my birthday entry, per Kirk's request.
Add my birthday entry, per Kirk's request
Jun 4 2019, 7:06 PM

Jun 3 2019

sef added a comment to D20477: Introduce stats(3).

I'd like to see some example usages.

Jun 3 2019, 10:59 PM
sef added inline comments to D20477: Introduce stats(3).
Jun 3 2019, 9:03 PM

May 25 2019

sef committed rS348268: Add an AESNI-optimized version of the CCM/CBC cryptographic and authentication.
Add an AESNI-optimized version of the CCM/CBC cryptographic and authentication
May 25 2019, 7:26 AM
sef closed D19298: AESNI version of CCM+CBC-MAC.
May 25 2019, 7:26 AM

May 24 2019

sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

A bit late, but the updated diff promised. Thanks cem & jhb!

May 24 2019, 6:17 PM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

Doing testing with the changes, then I'll upload the diffs.

May 24 2019, 2:29 AM

May 23 2019

sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

I'll get to those tomorrow, thanks! (Various stuff going on today has thrown my schedule off.)

May 23 2019, 12:36 AM

May 3 2019

sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

The promised updated diffs.

May 3 2019, 8:14 PM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

I'm updating and build testing before uploading new diffs.

May 3 2019, 5:54 PM

May 1 2019

sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

Poke?

May 1 2019, 10:57 PM

Apr 24 2019

sef accepted D20043: Don't panic for empty CCM requests..

Something made me think that it was not acceptable, but now I can't remember what it was, so it's clearly wrong.

Apr 24 2019, 10:46 PM

Apr 10 2019

sef accepted D19853: [security/nist-kat]: Add AES-CCM and plain SHA digest test vectors..
Apr 10 2019, 7:35 PM
sef added inline comments to D19298: AESNI version of CCM+CBC-MAC.
Apr 10 2019, 6:33 PM
sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

I lost the length descriptor prefix in the last change. I've put it back, and run cryptocheck with -A lengths of 0, 13, 16, 32, 192102, and 127091. (User-space can't test more than 256k unfortunately.)

Apr 10 2019, 6:30 PM
sef updated the diff for D19298: AESNI version of CCM+CBC-MAC.

Review feedback incorporated.

Apr 10 2019, 2:06 AM
sef added a comment to D19298: AESNI version of CCM+CBC-MAC.

New diff coming right after this.

Apr 10 2019, 2:05 AM

Apr 8 2019

sef added inline comments to D19298: AESNI version of CCM+CBC-MAC.
Apr 8 2019, 6:51 PM