Page MenuHomeFreeBSD

run uncrustify over vtfontcvt.c
Needs ReviewPublic

Authored by domagoj.stolfa_gmail.com on May 13 2021, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 21 2024, 5:41 PM
Unknown Object (File)
Jun 14 2024, 5:36 PM
Unknown Object (File)
Jun 4 2024, 4:05 AM
Unknown Object (File)
May 6 2024, 1:43 PM
Unknown Object (File)
May 3 2024, 12:52 AM
Unknown Object (File)
Apr 23 2024, 3:35 PM
Unknown Object (File)
Apr 14 2024, 4:38 PM
Unknown Object (File)
Dec 23 2023, 12:34 AM
Subscribers

Details

Reviewers
emaste
Summary

Posted as an example of running a FreeBSD-ish uncrustify config (https://reviews.freebsd.org/P500: based on https://github.com/freebsd/pkg/blob/master/freebsd.cfg with minor changes) over vtfontcvt.c to compare to https://reviews.freebsd.org/D26340.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

usr.bin/vtfontcvt/vtfontcvt.c
56

This whole struct is not great.

65

Should the brace be on a new line here?

225

TAILQ_FOREACH is treated as a for loop here through:

set FOR TAILQ_FOREACH

should it be?

573

This is wrong

581

Same as line 573

1126

This doesn't look right.

Remove a whole bunch of noise compared to the previous diff.