Page MenuHomeFreeBSD

run uncrustify over vtfontcvt.c
Needs ReviewPublic

Authored by domagoj.stolfa_gmail.com on May 13 2021, 3:16 PM.
Tags
None
Referenced Files
F163790844: D30248.id89136.diff
Sun, Jul 26, 1:18 AM
Unknown Object (File)
Sat, Jul 25, 1:33 PM
Unknown Object (File)
Sat, Jul 25, 9:01 AM
Unknown Object (File)
Sat, Jul 25, 5:57 AM
Unknown Object (File)
Fri, Jul 24, 9:05 AM
Unknown Object (File)
Sun, Jul 12, 12:14 AM
Unknown Object (File)
Sat, Jul 11, 10:04 AM
Unknown Object (File)
Thu, Jul 9, 11:24 AM
Subscribers

Details

Reviewers
emaste
Summary

Posted as an example of running a FreeBSD-ish uncrustify config (https://reviews.freebsd.org/P500: based on https://github.com/freebsd/pkg/blob/master/freebsd.cfg with minor changes) over vtfontcvt.c to compare to https://reviews.freebsd.org/D26340.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

usr.bin/vtfontcvt/vtfontcvt.c
56

This whole struct is not great.

65

Should the brace be on a new line here?

225

TAILQ_FOREACH is treated as a for loop here through:

set FOR TAILQ_FOREACH

should it be?

573

This is wrong

581

Same as line 573

1126

This doesn't look right.

Remove a whole bunch of noise compared to the previous diff.