Document and subtlely change the zfs.mount_snapshot jail parameter
ClosedPublic
Actions

Authored by jamie on Wed, Jun 19, 8:04 PM.

Details

Reviewers

avg

Group Reviewers

ZFS

Commits

rG63875db56bd5: Document the zfs.mount_snapshot parameter in jail(8).
rG9cbf1de7e34a: Mark the zfs.mount_snapshot jail parameter as boolean.

Summary

The parameter zfs.mount_snapshot was added that allows jailed users to mount ZFS snapshots. It also fixes bug 274263, which is about accessing those snapshots via the .zfs directory, not mounting them. Both of these uses should be documented in jail(8).

Also, the parameter operates as a boolean, but is listed as an plain integer (format "I" instead of "B"). Changing it to a proper boolean parameter would allow the existing boolean handling in jail.conf (i.e. "zfs.mount_snapshot" and "zfs.nomount_snapshot"), while the current "zfs.mount_snapshot=1" would still work.

The ZFS code change is trivial, but I'd still like buy-in because it's contrib code.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jamie created this revision.Wed, Jun 19, 8:04 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptWed, Jun 19, 8:04 PM

jamie requested review of this revision.Wed, Jun 19, 8:04 PM

zlei added a subscriber: zlei.Thu, Jun 20, 12:49 AM

I would subtly change the title :-)
Otherwise, looks good to me.

This revision is now accepted and ready to land.Thu, Jun 20, 4:56 AM

I guess the change for sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c go to upstream first. Will it ?

crest_freebsd_rlwinm.de added a subscriber: crest_freebsd_rlwinm.de.Thu, Jun 20, 9:37 AM

In D45647#1041512, @zlei wrote:

I guess the change for sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c go to upstream first. Will it ?

See, this is the kind of thing that keeps me from checking it in. But I'll sit a few days longer, and absent anyone saying "no, wait!" I'll let it get upstreamed whenever.

Closed by commit rG9cbf1de7e34a: Mark the zfs.mount_snapshot jail parameter as boolean. (authored by jamie). · Explain WhyMon, Jun 24, 8:02 PM

This revision was automatically updated to reflect the committed changes.

jamie added a commit: rG9cbf1de7e34a: Mark the zfs.mount_snapshot jail parameter as boolean..

jamie added a commit: rG63875db56bd5: Document the zfs.mount_snapshot parameter in jail(8)..Mon, Jun 24, 8:06 PM