cd: Remove commented-out code
ClosedPublic
Actions

Authored by markj on Jan 29 2024, 4:07 PM.

Tags

None

Referenced Files

	F162324127: D43650.diff
	Sun, Jul 12, 1:45 AM

	Unknown Object (File)
	Mon, Jun 22, 2:07 AM

	Unknown Object (File)
	May 19 2026, 9:41 PM

	Unknown Object (File)
	May 15 2026, 7:16 AM

	Unknown Object (File)
	May 14 2026, 7:12 PM

	Unknown Object (File)
	May 14 2026, 7:12 PM

	Unknown Object (File)
	May 14 2026, 7:11 PM

	Unknown Object (File)
	May 14 2026, 7:10 PM

View All Files

Subscribers

None

Details

Reviewers

avg
ken
imp

Group Reviewers

cam

Commits

rGc50eeb321be0: scsi_cd: Remove commented-out code
rG0c0ec5c8cc48: scsi_cd: Remove commented-out code

Summary

This is left over from before the implementation of asynchronous media
probing, which was committed in dd78f43259ef
("scsi_cd: make the media check asynchronous") quite a while ago now.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jan 29 2024, 4:07 PM

Herald added a reviewer: cam. · View Herald TranscriptJan 29 2024, 4:07 PM

markj requested review of this revision.Jan 29 2024, 4:07 PM

Harbormaster completed remote builds in B55683: Diff 133500.Jan 29 2024, 4:07 PM

4 years is enough time to prove the new code...

This revision is now accepted and ready to land.Jan 29 2024, 11:19 PM

avg accepted this revision.Jan 30 2024, 6:41 AM

Closed by commit rG0c0ec5c8cc48: scsi_cd: Remove commented-out code (authored by markj). · Explain WhyJan 30 2024, 2:32 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0c0ec5c8cc48: scsi_cd: Remove commented-out code.

markj added a commit: rGc50eeb321be0: scsi_cd: Remove commented-out code.Feb 9 2024, 3:05 PM

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

scsi_cd.c

201 lines

Diff 133602

View Options

cd: Remove commented-out codeClosedPublicActions