Page MenuHomeFreeBSD

ZFSUmbrella
ActivePublic

Details

Description

Various work on OpenZFS and ZFS/FreeBSD.

Recent Activity

Yesterday

asomers accepted D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Fri, Feb 23, 5:12 PM · ZFS
pinchuk.alek_gmail.com updated the diff for D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Fri, Feb 23, 4:44 PM · ZFS
pinchuk.alek_gmail.com updated the diff for D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Fri, Feb 23, 4:43 PM · ZFS
allanjude added inline comments to D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Fri, Feb 23, 4:40 PM · ZFS
pinchuk.alek_gmail.com requested review of D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Fri, Feb 23, 4:33 PM · ZFS

Nov 27 2023

emaste added a watcher for ZFS: emaste.
Nov 27 2023, 3:53 PM

Oct 14 2023

allanjude added a member for ZFS: allanjude.
Oct 14 2023, 2:28 PM

Oct 10 2023

mm closed D41991: Enable block cloning by default.
Oct 10 2023, 10:48 PM · ZFS
mav accepted D41991: Enable block cloning by default.
Oct 10 2023, 1:51 PM · ZFS
markj added a comment to D41991: Enable block cloning by default.

I don't have any objection to the change, then.

Oct 10 2023, 1:48 PM · ZFS
zlei retitled D41991: Enable block cloning by default from Enable block cloning by defaut to Enable block cloning by default.
Oct 10 2023, 2:25 AM · ZFS

Sep 30 2023

mm added a comment to D41991: Enable block cloning by default.

I have now successfully run a FreeBSD regression test suite on a ZFS root with block cloning enabled

Sep 30 2023, 10:12 AM · ZFS

Sep 29 2023

markj added a comment to D41991: Enable block cloning by default.
In D41991#958356, @mm wrote:

I have run the ZFS test suite with block cloning enabled. There are no tests with different results as when it is not enabled.

Sep 29 2023, 2:34 PM · ZFS
mm added a comment to D41991: Enable block cloning by default.

I have run the ZFS test suite with block cloning enabled. There are no tests with different results as when it is not enabled.

Sep 29 2023, 12:36 PM · ZFS
mm updated the diff for D41991: Enable block cloning by default.

I have run the ZFS test suite

Sep 29 2023, 12:33 PM · ZFS

Sep 27 2023

mav added inline comments to D41991: Enable block cloning by default.
Sep 27 2023, 2:25 PM · ZFS
mav added a comment to D41991: Enable block cloning by default.
In D41991#957622, @mjg wrote:

for example there was panic under load when running poudriere, i don't know if that is fixed

Sep 27 2023, 2:20 PM · ZFS
mjg added a comment to D41991: Enable block cloning by default.

for example there was panic under load when running poudriere, i don't know if that is fixed

Sep 27 2023, 2:10 PM · ZFS
mav added a comment to D41991: Enable block cloning by default.

@mjg Does any specific bug come to your mind?

Sep 27 2023, 2:05 PM · ZFS
mjg added a comment to D41991: Enable block cloning by default.

For this to be an option this review has to provide a list of bugs reported against block cloning and commits which fix them, as is I'm not even sure it was all sorted out.

Sep 27 2023, 12:20 PM · ZFS
markj added a comment to D41991: Enable block cloning by default.

Have you tried running the test suite on a ZFS system with this change applied?

Sep 27 2023, 11:07 AM · ZFS
mm added a reviewer for D41991: Enable block cloning by default: pjd.
Sep 27 2023, 6:52 AM · ZFS
mm added reviewers for D41991: Enable block cloning by default: mjg, markj.
Sep 27 2023, 6:51 AM · ZFS
mm added a reviewer for D41991: Enable block cloning by default: mav.
Sep 27 2023, 6:50 AM · ZFS
mm requested review of D41991: Enable block cloning by default.
Sep 27 2023, 6:50 AM · ZFS

Sep 6 2023

mm closed D41721: Cross-mountpoint copy_file_range() for ZFS.
Sep 6 2023, 12:29 PM · ZFS
rmacklem accepted D41721: Cross-mountpoint copy_file_range() for ZFS.

I'll added some inline comments, but they are only suggestions.
I think this minor semantics change for VOP_COPY_FILE_RANGE()
is ok, but we'll see if others disagree.

Sep 6 2023, 12:10 AM · ZFS

Sep 5 2023

mm updated the diff for D41721: Cross-mountpoint copy_file_range() for ZFS.

I have changed the code to the way rmacklem@ recommended. In fusefs we don't have to change anything as there is already a mountpoint check at the very beginning. In nfsclient I have added the mountpoint check. ZFS can handle this change without modifications.

Sep 5 2023, 3:06 PM · ZFS
rmacklem added a comment to D41721: Cross-mountpoint copy_file_range() for ZFS.

Maybe I didn't make the NFS case clear.
For two different NFS mounts it can do the Copy
without reads/writes for some situations.
(Both mounts NFSv4.2 and either same server
or maybe different servers.)

Sep 5 2023, 1:46 AM · ZFS
rmacklem added a comment to D41721: Cross-mountpoint copy_file_range() for ZFS.

As noted, I think a check for "same file system type" is needed
before a call to VOP_COPY_FILE_RANGE().

Sep 5 2023, 1:27 AM · ZFS
mm updated the diff for D41721: Cross-mountpoint copy_file_range() for ZFS.

I have updated the diff to use a kernel mount flag.

Sep 5 2023, 12:02 AM · ZFS

Sep 4 2023

markj added inline comments to D41721: Cross-mountpoint copy_file_range() for ZFS.
Sep 4 2023, 8:31 PM · ZFS
mm requested review of D41721: Cross-mountpoint copy_file_range() for ZFS.
Sep 4 2023, 8:15 PM · ZFS

Jul 16 2023

grahamperrin removed a watcher for ZFS: grahamperrin.
Jul 16 2023, 5:29 PM

May 27 2023

grahamperrin created P571 panic: VERIFY3(dev->l2ad_hand <= dev->l2ad_evict) failed (3680984576 <= 3680983552).
May 27 2023, 2:07 PM · ZFS
grahamperrin created P570 panic: VERIFY3(dev->l2ad_hand <= dev->l2ad_evict) failed (6704865280 <= 6704857600).
May 27 2023, 2:06 PM · ZFS
grahamperrin created P569 panic: VERIFY3(dev->l2ad_hand <= dev->l2ad_evict) failed (14053755392 <= 14053740032).
May 27 2023, 2:06 PM · ZFS

Apr 26 2023

0mp closed D39657: Add support for zpool user properties.

Committed in https://cgit.freebsd.org/src/commit/?id=c98ecfceb36159e52c8d7e5cfc0d376393a6a60b

Apr 26 2023, 10:49 AM · ZFS

Apr 24 2023

markj accepted D39657: Add support for zpool user properties.
Apr 24 2023, 1:56 PM · ZFS
0mp added inline comments to D39657: Add support for zpool user properties.
Apr 24 2023, 1:55 PM · ZFS
markj added inline comments to D39657: Add support for zpool user properties.
Apr 24 2023, 1:29 PM · ZFS
0mp added a project to D39657: Add support for zpool user properties: ZFS.
Apr 24 2023, 1:20 PM · ZFS

Nov 27 2022

grahamperrin added a watcher for ZFS: grahamperrin.
Nov 27 2022, 3:42 PM

Nov 15 2021

markj closed D32521: cddl: fix missing ZFS library dependencies.
Nov 15 2021, 2:43 PM · ZFS

Nov 14 2021

val_packett.cool updated the diff for D32521: cddl: fix missing ZFS library dependencies.

Also add to Makefile.inc1 and SUBDIR_DEPEND_*. Should always work now.

Nov 14 2021, 3:19 PM · ZFS
bcr closed D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
Nov 14 2021, 2:06 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Alright, I incorporated these last feedback items. I'm going to commit this shortly.
Thanks to all reviewers, your feedback and suggestions helped a lot in improving the text!

Nov 14 2021, 1:25 PM · ZFS

Nov 13 2021

pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

As far as I'm concerned, I think you can go ahead and commit at your discretion after this round of (very minor) suggestions. Getting to diminishing returns here.

Nov 13 2021, 9:38 PM · ZFS

Oct 30 2021

markj added a comment to D32521: cddl: fix missing ZFS library dependencies.

A buildworld fails after applying this patch to main, seems to be while linking libavl:

Oct 30 2021, 2:52 PM · ZFS

Oct 29 2021

bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Change an instance of "alone" to "only" in the L2ARC description to not confuse people about adding multiple devices there.

Oct 29 2021, 6:58 PM · ZFS