Various work on OpenZFS and ZFS/FreeBSD.
Nov 27 2023
Oct 14 2023
Oct 10 2023
I don't have any objection to the change, then.
Sep 30 2023
I have now successfully run a FreeBSD regression test suite on a ZFS root with block cloning enabled
Sep 29 2023
I have run the ZFS test suite with block cloning enabled. There are no tests with different results as when it is not enabled.
I have run the ZFS test suite
Sep 27 2023
for example there was panic under load when running poudriere, i don't know if that is fixed
@mjg Does any specific bug come to your mind?
For this to be an option this review has to provide a list of bugs reported against block cloning and commits which fix them, as is I'm not even sure it was all sorted out.
Have you tried running the test suite on a ZFS system with this change applied?
Sep 6 2023
I'll added some inline comments, but they are only suggestions.
I think this minor semantics change for VOP_COPY_FILE_RANGE()
is ok, but we'll see if others disagree.
Sep 5 2023
I have changed the code to the way rmacklem@ recommended. In fusefs we don't have to change anything as there is already a mountpoint check at the very beginning. In nfsclient I have added the mountpoint check. ZFS can handle this change without modifications.
Maybe I didn't make the NFS case clear.
For two different NFS mounts it can do the Copy
without reads/writes for some situations.
(Both mounts NFSv4.2 and either same server
or maybe different servers.)
As noted, I think a check for "same file system type" is needed
before a call to VOP_COPY_FILE_RANGE().
I have updated the diff to use a kernel mount flag.
Sep 4 2023
Jul 16 2023
May 27 2023
Apr 26 2023
Apr 24 2023
Nov 27 2022
Nov 15 2021
Nov 14 2021
Also add to Makefile.inc1 and SUBDIR_DEPEND_*. Should always work now.
Alright, I incorporated these last feedback items. I'm going to commit this shortly.
Thanks to all reviewers, your feedback and suggestions helped a lot in improving the text!
Nov 13 2021
As far as I'm concerned, I think you can go ahead and commit at your discretion after this round of (very minor) suggestions. Getting to diminishing returns here.
Oct 30 2021
A buildworld fails after applying this patch to main, seems to be while linking libavl:
Oct 29 2021
Change an instance of "alone" to "only" in the L2ARC description to not confuse people about adding multiple devices there.