Details
- Reviewers
mav mjg markj pjd - Commits
- rG26103ccba8b7: zfs: enable block cloning by default
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
For this to be an option this review has to provide a list of bugs reported against block cloning and commits which fix them, as is I'm not even sure it was all sorted out.
for example there was panic under load when running poudriere, i don't know if that is fixed
there were numerous bugs reported (more than once at that) in several threads. restoring this functionality requires tallying them all up
The last one reported by Mark Millard recently was fixed: https://github.com/openzfs/zfs/pull/15251 . After that his builds succeeded. I am not aware about other poudriere block cloning issues.
there were numerous bugs reported (more than once at that) in several threads. restoring this functionality requires tallying them all up
The functionality is disabled for 5 months on FreeBSD, while there was some upstream work on it, including Linux support that should add more test cases. I haven't reviewed the history of 5 month ago, but there is a good chance that it may be not applicable.
| sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c | ||
|---|---|---|
| 94 | The val field in SYSCTL_INT is used only if ptr is SYSCTL_NULL_INT_PTR. You should do zfs_bclone_enabled = 1 instead. | |
I have run the ZFS test suite with block cloning enabled. There are no tests with different results as when it is not enabled.
Assuming this is in reference to my comment, I meant running the FreeBSD regression test suite on a system with ZFS root filesystem.
I have now successfully run a FreeBSD regression test suite on a ZFS root with block cloning enabled