Add support for zpool user properties
ClosedPublic
Actions

Authored by 0mp on Apr 18 2023, 2:05 PM.

Details

Reviewers

allanjude
markj

Commits

rGc98ecfceb361: Add support for zpool user properties

Summary

Add support for zpool user properties

Usage:

zpool set org.freebsd:comment="this is my pool" poolname

Tests are based on zfs_set's user property tests.

Also stop truncating property values at MAXNAMELEN, use ZFS_MAXPROPLEN.

Co-authored-by: Mateusz Piotrowski <0mp@FreeBSD.org>
Obtained from: OpenZFS 8eae2d214cfa Add support for zpool user properties
Sponsored by: Beckhoff Automation GmbH & Co. KG.
Sponsored by: Klara Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 51154
Build 48045: arc lint + arc unit

Event Timeline

0mp created this revision.Apr 18 2023, 2:05 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptApr 18 2023, 2:05 PM

0mp requested review of this revision.Apr 18 2023, 2:05 PM

Harbormaster completed remote builds in B51003: Diff 120567.Apr 18 2023, 2:05 PM

Remove unnecessary changes from the ABI file

Harbormaster completed remote builds in B51006: Diff 120571.Apr 18 2023, 2:40 PM

Now that the patch has been merged upstream, let's rebase on the merged version.

Harbormaster completed remote builds in B51154: Diff 120931.Apr 24 2023, 1:08 PM

0mp edited the summary of this revision. (Show Details)Apr 24 2023, 1:09 PM

0mp added a project: ZFS.Apr 24 2023, 1:20 PM

markj added a subscriber: markj.Apr 24 2023, 1:29 PM

markj added inline comments.

sys/contrib/openzfs/lib/libzfs/libzfs.abi
487	The upstream commit has more changes to libzfs.abi. Why aren't they in this patch?

0mp added inline comments.Apr 24 2023, 1:55 PM

sys/contrib/openzfs/lib/libzfs/libzfs.abi
487	I kept only the changes related to zpool user props. The upstream changes that are missing from this patch are "use_color" and "iterator" bits. I don't really know why those changes are parts of the zpool user properties patch in OpenZFS.