Page MenuHomeFreeBSD
Feed Advanced Search

Mon, Mar 18

mav added a comment to D44404: [stable/14] zfs: fix assertion in dbuf.c.

Why not backport 506fe78c48 instead?

Mon, Mar 18, 1:46 PM · ZFS
mm closed D44404: [stable/14] zfs: fix assertion in dbuf.c.
Mon, Mar 18, 1:45 PM · ZFS
des accepted D44404: [stable/14] zfs: fix assertion in dbuf.c.
Mon, Mar 18, 12:32 PM · ZFS
mm requested review of D44404: [stable/14] zfs: fix assertion in dbuf.c.
Mon, Mar 18, 11:50 AM · ZFS

Mar 5 2024

asomers closed D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Mar 5 2024, 7:29 PM · ZFS

Feb 27 2024

allanjude accepted D44043: zfsd: Use vdev prop values for fault/degrade thresholds.

reviewed-by: allanjude

Feb 27 2024, 7:57 PM · ZFS

Feb 23 2024

asomers accepted D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Feb 23 2024, 5:12 PM · ZFS
pinchuk.alek_gmail.com updated the diff for D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Feb 23 2024, 4:44 PM · ZFS
pinchuk.alek_gmail.com updated the diff for D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Feb 23 2024, 4:43 PM · ZFS
allanjude added inline comments to D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Feb 23 2024, 4:40 PM · ZFS
pinchuk.alek_gmail.com requested review of D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Feb 23 2024, 4:33 PM · ZFS

Nov 27 2023

emaste added a watcher for ZFS: emaste.
Nov 27 2023, 3:53 PM

Oct 14 2023

allanjude added a member for ZFS: allanjude.
Oct 14 2023, 2:28 PM

Oct 10 2023

mm closed D41991: Enable block cloning by default.
Oct 10 2023, 10:48 PM · ZFS
mav accepted D41991: Enable block cloning by default.
Oct 10 2023, 1:51 PM · ZFS
markj added a comment to D41991: Enable block cloning by default.

I don't have any objection to the change, then.

Oct 10 2023, 1:48 PM · ZFS
zlei retitled D41991: Enable block cloning by default from Enable block cloning by defaut to Enable block cloning by default.
Oct 10 2023, 2:25 AM · ZFS

Sep 30 2023

mm added a comment to D41991: Enable block cloning by default.

I have now successfully run a FreeBSD regression test suite on a ZFS root with block cloning enabled

Sep 30 2023, 10:12 AM · ZFS

Sep 29 2023

markj added a comment to D41991: Enable block cloning by default.
In D41991#958356, @mm wrote:

I have run the ZFS test suite with block cloning enabled. There are no tests with different results as when it is not enabled.

Sep 29 2023, 2:34 PM · ZFS
mm added a comment to D41991: Enable block cloning by default.

I have run the ZFS test suite with block cloning enabled. There are no tests with different results as when it is not enabled.

Sep 29 2023, 12:36 PM · ZFS
mm updated the diff for D41991: Enable block cloning by default.

I have run the ZFS test suite

Sep 29 2023, 12:33 PM · ZFS

Sep 27 2023

mav added inline comments to D41991: Enable block cloning by default.
Sep 27 2023, 2:25 PM · ZFS
mav added a comment to D41991: Enable block cloning by default.
In D41991#957622, @mjg wrote:

for example there was panic under load when running poudriere, i don't know if that is fixed

Sep 27 2023, 2:20 PM · ZFS
mjg added a comment to D41991: Enable block cloning by default.

for example there was panic under load when running poudriere, i don't know if that is fixed

Sep 27 2023, 2:10 PM · ZFS
mav added a comment to D41991: Enable block cloning by default.

@mjg Does any specific bug come to your mind?

Sep 27 2023, 2:05 PM · ZFS
mjg added a comment to D41991: Enable block cloning by default.

For this to be an option this review has to provide a list of bugs reported against block cloning and commits which fix them, as is I'm not even sure it was all sorted out.

Sep 27 2023, 12:20 PM · ZFS
markj added a comment to D41991: Enable block cloning by default.

Have you tried running the test suite on a ZFS system with this change applied?

Sep 27 2023, 11:07 AM · ZFS
mm added a reviewer for D41991: Enable block cloning by default: pjd.
Sep 27 2023, 6:52 AM · ZFS
mm added reviewers for D41991: Enable block cloning by default: mjg, markj.
Sep 27 2023, 6:51 AM · ZFS
mm added a reviewer for D41991: Enable block cloning by default: mav.
Sep 27 2023, 6:50 AM · ZFS
mm requested review of D41991: Enable block cloning by default.
Sep 27 2023, 6:50 AM · ZFS

Sep 6 2023

mm closed D41721: Cross-mountpoint copy_file_range() for ZFS.
Sep 6 2023, 12:29 PM · ZFS
rmacklem accepted D41721: Cross-mountpoint copy_file_range() for ZFS.

I'll added some inline comments, but they are only suggestions.
I think this minor semantics change for VOP_COPY_FILE_RANGE()
is ok, but we'll see if others disagree.

Sep 6 2023, 12:10 AM · ZFS

Sep 5 2023

mm updated the diff for D41721: Cross-mountpoint copy_file_range() for ZFS.

I have changed the code to the way rmacklem@ recommended. In fusefs we don't have to change anything as there is already a mountpoint check at the very beginning. In nfsclient I have added the mountpoint check. ZFS can handle this change without modifications.

Sep 5 2023, 3:06 PM · ZFS
rmacklem added a comment to D41721: Cross-mountpoint copy_file_range() for ZFS.

Maybe I didn't make the NFS case clear.
For two different NFS mounts it can do the Copy
without reads/writes for some situations.
(Both mounts NFSv4.2 and either same server
or maybe different servers.)

Sep 5 2023, 1:46 AM · ZFS
rmacklem added a comment to D41721: Cross-mountpoint copy_file_range() for ZFS.

As noted, I think a check for "same file system type" is needed
before a call to VOP_COPY_FILE_RANGE().

Sep 5 2023, 1:27 AM · ZFS
mm updated the diff for D41721: Cross-mountpoint copy_file_range() for ZFS.

I have updated the diff to use a kernel mount flag.

Sep 5 2023, 12:02 AM · ZFS

Sep 4 2023

markj added inline comments to D41721: Cross-mountpoint copy_file_range() for ZFS.
Sep 4 2023, 8:31 PM · ZFS
mm requested review of D41721: Cross-mountpoint copy_file_range() for ZFS.
Sep 4 2023, 8:15 PM · ZFS

Jul 16 2023

grahamperrin removed a watcher for ZFS: grahamperrin.
Jul 16 2023, 5:29 PM

May 27 2023

grahamperrin created P571 panic: VERIFY3(dev->l2ad_hand <= dev->l2ad_evict) failed (3680984576 <= 3680983552).
May 27 2023, 2:07 PM · ZFS
grahamperrin created P570 panic: VERIFY3(dev->l2ad_hand <= dev->l2ad_evict) failed (6704865280 <= 6704857600).
May 27 2023, 2:06 PM · ZFS
grahamperrin created P569 panic: VERIFY3(dev->l2ad_hand <= dev->l2ad_evict) failed (14053755392 <= 14053740032).
May 27 2023, 2:06 PM · ZFS

Apr 26 2023

0mp closed D39657: Add support for zpool user properties.

Committed in https://cgit.freebsd.org/src/commit/?id=c98ecfceb36159e52c8d7e5cfc0d376393a6a60b

Apr 26 2023, 10:49 AM · ZFS

Apr 24 2023

markj accepted D39657: Add support for zpool user properties.
Apr 24 2023, 1:56 PM · ZFS
0mp added inline comments to D39657: Add support for zpool user properties.
Apr 24 2023, 1:55 PM · ZFS
markj added inline comments to D39657: Add support for zpool user properties.
Apr 24 2023, 1:29 PM · ZFS
0mp added a project to D39657: Add support for zpool user properties: ZFS.
Apr 24 2023, 1:20 PM · ZFS

Nov 27 2022

grahamperrin added a watcher for ZFS: grahamperrin.
Nov 27 2022, 3:42 PM

Nov 15 2021

markj closed D32521: cddl: fix missing ZFS library dependencies.
Nov 15 2021, 2:43 PM · ZFS

Nov 14 2021

val_packett.cool updated the diff for D32521: cddl: fix missing ZFS library dependencies.

Also add to Makefile.inc1 and SUBDIR_DEPEND_*. Should always work now.

Nov 14 2021, 3:19 PM · ZFS
bcr closed D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
Nov 14 2021, 2:06 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Alright, I incorporated these last feedback items. I'm going to commit this shortly.
Thanks to all reviewers, your feedback and suggestions helped a lot in improving the text!

Nov 14 2021, 1:25 PM · ZFS

Nov 13 2021

pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

As far as I'm concerned, I think you can go ahead and commit at your discretion after this round of (very minor) suggestions. Getting to diminishing returns here.

Nov 13 2021, 9:38 PM · ZFS

Oct 30 2021

markj added a comment to D32521: cddl: fix missing ZFS library dependencies.

A buildworld fails after applying this patch to main, seems to be while linking libavl:

Oct 30 2021, 2:52 PM · ZFS

Oct 29 2021

bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Change an instance of "alone" to "only" in the L2ARC description to not confuse people about adding multiple devices there.

Oct 29 2021, 6:58 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Reply with confirmation about the L2ARC vdevs question.

Oct 29 2021, 6:54 PM · ZFS

Oct 27 2021

pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

I'll have another look at the whole thing, but it will likely be a few days before I can.

Oct 27 2021, 8:15 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Update with some of my own replies.

Oct 27 2021, 7:31 PM · ZFS
bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Yet another update addressing some of @pauamma_gundo.com's comments.

Oct 27 2021, 7:30 PM · ZFS
freqlabs accepted D32521: cddl: fix missing ZFS library dependencies.
Oct 27 2021, 3:06 PM · ZFS

Oct 19 2021

markj accepted D32521: cddl: fix missing ZFS library dependencies.

Looks right to me.

Oct 19 2021, 4:42 PM · ZFS

Oct 16 2021

val_packett.cool added a comment to D32521: cddl: fix missing ZFS library dependencies.

This looks good, but I'm surprised that there aren't more transitive dependencies that can be removed. For example, zfsd doesn't use libzfs_core directly, only through libzfs. Can libzfs_core be removed from its LIBADD?

Oct 16 2021, 6:58 PM · ZFS
val_packett.cool updated the diff for D32521: cddl: fix missing ZFS library dependencies.

Remove libzfs_core dep from zfsd

Oct 16 2021, 6:57 PM · ZFS
asomers added a comment to D32521: cddl: fix missing ZFS library dependencies.

This looks good, but I'm surprised that there aren't more transitive dependencies that can be removed. For example, zfsd doesn't use libzfs_core directly, only through libzfs. Can libzfs_core be removed from its LIBADD?

Oct 16 2021, 4:36 PM · ZFS
val_packett.cool updated the test plan for D32521: cddl: fix missing ZFS library dependencies.
Oct 16 2021, 4:36 PM · ZFS

Sep 27 2021

pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Aaaaaaaand done! (Split glossary to 1 sentence per line, please.)

Sep 27 2021, 2:01 AM · ZFS

Sep 26 2021

pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Mentioning it here to avoid repeating it a gazillion times: 1 sentence per line.

Sep 26 2021, 11:49 PM · ZFS

Sep 14 2021

eric_metricspace.net added a comment to D31725: Allow autounmountd to unload ZFS keys.
In D31725#720207, @rew wrote:

Sounds like a bug in the upstream module. I’d prefer to see that fixed rather than using autofs to work around the zfs_key pam module bug. Or see if it’s feasible to implement a pure autofs solution (i.e., autofs loads and unloads the key for a given dataset). If neither of the above options are possible, I’m more inclined to oppose this change until a more streamlined solution can be found.

Sep 14 2021, 12:54 AM · ZFS

Sep 12 2021

rew added a comment to D31725: Allow autounmountd to unload ZFS keys.

Sounds like a bug in the upstream module. I’d prefer to see that fixed rather than using autofs to work around the zfs_key pam module bug. Or see if it’s feasible to implement a pure autofs solution (i.e., autofs loads and unloads the key for a given dataset). If neither of the above options are possible, I’m more inclined to oppose this change until a more streamlined solution can be found.

Sep 12 2021, 8:30 PM · ZFS

Sep 10 2021

eric_metricspace.net added a comment to D31725: Allow autounmountd to unload ZFS keys.
In D31725#719491, @rew wrote:

As I explained in the description, this is intended to be used in conjunction with PAM to load a user's auth token as a key, allowing their encrypted home directory to be loaded when they log in, and unloaded once they've fully logged out. This in turn is a means to implement a common requirement on high-security systems.

According to the OpenZFS commit, the zfs_key pam module already unmounts the dataset and unloads the key when a session is closed.

For reference: https://github.com/openzfs/zfs/commit/221e67040fc47c15b3da2afb09bb48f1e9700fb9

Sep 10 2021, 12:52 AM · ZFS

Sep 9 2021

rew added a comment to D31725: Allow autounmountd to unload ZFS keys.

As I explained in the description, this is intended to be used in conjunction with PAM to load a user's auth token as a key, allowing their encrypted home directory to be loaded when they log in, and unloaded once they've fully logged out. This in turn is a means to implement a common requirement on high-security systems.

According to the OpenZFS commit, the zfs_key pam module already unmounts the dataset and unloads the key when a session is closed.

Sep 9 2021, 2:06 PM · ZFS
eric_metricspace.net added a comment to D31725: Allow autounmountd to unload ZFS keys.
In D31725#719350, @rew wrote:

Does it make sense to have autofs unload zfs keys if it doesn't even know how to load them?

Sep 9 2021, 1:09 PM · ZFS

Sep 8 2021

rew added a reviewer for D31725: Allow autounmountd to unload ZFS keys: trasz.

Does it make sense to have autofs unload zfs keys if it doesn't even know how to load them?

Sep 8 2021, 6:09 PM · ZFS

Sep 7 2021

eric_metricspace.net added a comment to D31725: Allow autounmountd to unload ZFS keys.

In general I don't think it's a good idea to add an option to opt-in unload of crypto keys: it should always be done unless explicitly opted out (or can't be opted out), so I'd recommend either removing the option and default to be safe, or make it an opt-out option (when specified, do not unload crypto key).

I'm not sure it's a good idea to abruptly change behavior in this way. I think it would be a better idea to introduce the ability as opt-in, and then change it to opt-out after announcing in advance.

I'm not very convinced that this is a behavior change (please do correct me if I was wrong). Here is my thought: the change seems to affect ZFS case only, and for ZFS the regular usage is that they are mounted by zfs mount -a, and my understanding is that this change is intended to be used with the PAM module to provide more automation to the load/unload key process.

If the assumption above was right, since there isn't current working way of loading ZFS encrypted dataset with this new workflow, we are not changing any existing behavior.

Sep 7 2021, 1:05 AM · ZFS
delphij added a comment to D31725: Allow autounmountd to unload ZFS keys.

In general I don't think it's a good idea to add an option to opt-in unload of crypto keys: it should always be done unless explicitly opted out (or can't be opted out), so I'd recommend either removing the option and default to be safe, or make it an opt-out option (when specified, do not unload crypto key).

I'm not sure it's a good idea to abruptly change behavior in this way. I think it would be a better idea to introduce the ability as opt-in, and then change it to opt-out after announcing in advance.

Sep 7 2021, 12:14 AM · ZFS

Sep 6 2021

eric_metricspace.net abandoned D31844: PAM module for loading ZFS keys on login.

Abandoning, due to the existence of the upstream module in cddl

Sep 6 2021, 11:16 PM · ZFS
eric_metricspace.net added a comment to D31725: Allow autounmountd to unload ZFS keys.

In general I don't think it's a good idea to add an option to opt-in unload of crypto keys: it should always be done unless explicitly opted out (or can't be opted out), so I'd recommend either removing the option and default to be safe, or make it an opt-out option (when specified, do not unload crypto key).

Sep 6 2021, 12:18 PM · ZFS
delphij requested changes to D31725: Allow autounmountd to unload ZFS keys.

In general I don't think it's a good idea to add an option to opt-in unload of crypto keys: it should always be done unless explicitly opted out (or can't be opted out), so I'd recommend either removing the option and default to be safe, or make it an opt-out option (when specified, do not unload crypto key).

Sep 6 2021, 12:43 AM · ZFS
delphij requested changes to D31844: PAM module for loading ZFS keys on login.

This proposed module have a lot of behavior that is very different from the Oracle and the OpenZFS implementation and since we are naming it the same way I don't think it's a good idea to diverge from the other implementations, especially the most commonly used parameters like homes= and the lack of mounting of the datasets.

Sep 6 2021, 12:27 AM · ZFS

Sep 5 2021

bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Update including the lastest suggestions to the lower last part of the chapter.

Sep 5 2021, 5:34 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Another big update, including both @ygy's and @pauamma_gundo.com's comments.
I should have kept the diff much smaller in retrospect, sorry about that. We're getting close to the final piece now, thanks to your efforts!
The line breaks were caused by my editor trying to be smarter than it should be.

Sep 5 2021, 5:33 PM · ZFS
eric_metricspace.net updated the test plan for D31844: PAM module for loading ZFS keys on login.
Sep 5 2021, 1:49 PM · ZFS
eric_metricspace.net requested review of D31844: PAM module for loading ZFS keys on login.
Sep 5 2021, 1:41 PM · ZFS

Sep 4 2021

pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Taking a break before tackling the wall of text, but splitting lines into sentences first would make needed edits easier to spot. Pretty please?

Sep 4 2021, 1:37 AM · ZFS

Sep 3 2021

pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Hoping to finish reviewing it tonight. 4 installments is pushing it.

Sep 3 2021, 6:31 PM · ZFS
ygy added inline comments to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
Sep 3 2021, 2:05 PM · ZFS
debdrup accepted D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

I've given it another once-over, and am pretty happy with it, so unless anyone else has any interjections, I say it's good to go.

Sep 3 2021, 11:46 AM · ZFS
bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

New version that includes suggestions by @pauamma_gundo.com

Sep 3 2021, 11:29 AM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Phew, a lot of changes, most of which I concur with and changed. Thanks!
Updated patch follows.

Sep 3 2021, 11:28 AM · ZFS

Sep 1 2021

pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Taking me longer than i thought (when doesn't it for anyone?) but getting there.

Sep 1 2021, 4:49 AM · ZFS

Aug 30 2021

debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715576, @bcr wrote:

That's right. My understanding is that everything is a dataset unless it was created by "zfs create -V ...", which for me is a volume (and used in this way). As you said, it may change or even blur some more with future changes. My idea is to use them consistently, for example mention datasets everywhere when it comes to ZFS features. When involving mountpoints, I'd refer to file systems, like this: "Mount the dataset as a file system into the directory tree." That way, we use it only when necessary, but keep the dataset syntax. Same when it involves volumes.

Aug 30 2021, 2:27 PM · ZFS
eric_metricspace.net requested review of D31725: Allow autounmountd to unload ZFS keys.
Aug 30 2021, 11:31 AM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

A few comments, mostly agreeing with the suggestion.

Aug 30 2021, 10:59 AM · ZFS
bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Another fine set of changes, including most (if not all) suggestions by @pauamma_gundo.com

Aug 30 2021, 10:58 AM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715576, @bcr wrote:

Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Calling them datasets introduces new ambiguities, because a dataset can both be a filesystem and a volume, and it's possible that it's definition will be expanded in future versions too.

Aug 30 2021, 9:32 AM · ZFS
pauamma_gundo.com added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Second installment. (Let me know if I'm too nitpicky or overwhelming.)

Aug 30 2021, 2:43 AM · ZFS

Aug 29 2021

debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715576, @bcr wrote:

Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Aug 29 2021, 2:14 PM · ZFS
bcr updated the diff for D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Update diff to incorporate changes from @debdrup and @pauamma_gundo.com . Looking forward to the second half of changes. I know it's tedious and I should have kept it shorter. Will consider than for future changes like this on other chapters.

Aug 29 2021, 1:56 PM · ZFS
bcr added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Thanks for your suggestions, @debdrup and @pauamma_gundo.com . I incorporated a lot of them into the next set of changes.
I looked at our current docs for the word list on how to write "file system" versus "filesystem". It seems like it does not exist in the FDP primer anymore. It used to be there in the old one: https://www-legacy.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-word-list.html . Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Aug 29 2021, 1:53 PM · ZFS