In D15838#334908, @delphij wrote:

LGTM in principal.

Should we translate terms like "Repository", etc.? It might be confusing for a newcomer what is "Phabricator" by the way, but it might need to be addressed in the English version as well.

@mat Thank you, noted.

Closed by https://svnweb.freebsd.org/base?view=revision&revision=334895

In D15721#332368, @emaste wrote:

No underscore in the commit metadata :)

@woodsb02 @mat Noted and updated the test plan. I will include these in future reviews.

In D15658#330989, @loader wrote:

This review is to merge the latest r51696 from English version:
https://svnweb.freebsd.org/doc/head/en_US.ISO8859-1/htdocs/index.xsl?r1=51605&r2=51696

There are still a few commits need to be merged since r49485:

% grep 'Original revision' zh_CN.UTF-8/htdocs/index.xsl                                       
<!-- Original revision: r49485 -->

% svnlite log --diff -r 49485:51605 svn://svn.freebsd.org/doc/head/en_US.ISO8859-1/htdocs/index.xsl

In D15658#330925, @loader wrote:

I assume 49485:51605 will be merged later, right?

Update the patch.

In D14899#327968, @mat wrote:

In D14899#327870, @ygy wrote:

In D14899#326603, @mat wrote:

I am not sure what the "3 consecutive times" adds here, could you explain?

From https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.html:

If the maintainer does not respond within three months, or if there have been three consecutive timeouts, then that maintainer is considered absent without leave, and can be replaced as the maintainer of the particular port in question.

I realized that the statement could probably be omitted here, but I just wanted to address that. Do you have a better suggestion for this circumstance?

Well, this sentence is not there for that purpose. This sentence means that if there are three consecutive timeouts, the maintainership can be reset to whatever is needed, most of the time, ports@ or any generic maintainer like perl@ or python@, and the previous maintainer cannot complain about it.

But any patch can be applied after only one maintainer timeout, including one which changes the maintainership.

In D14899#326603, @mat wrote:

I am not sure what the "3 consecutive times" adds here, could you explain?

In D14899#313761, @woodsb02 wrote:

Hi ygy,
This review is marked as "changes planned" - was this deliberate? If so, can you describe the problems you have found which are planning to address?
Cheers,
Ben

@loader @delphij could you please approve this when you have time to take a look?

Hi @woodsb02, thanks! I noted your suggestions and will learn from it. I will also add the maintainer timeout info to the commit message.

The school has been pretty busy in the past months, sorry! Will try to catch up :-)

In D14532#305009, @mat wrote:

In D14532#304868, @ygy wrote:

Looks good to me, though I am not a ports committer (yet), so it would be better to have someone else to review it :-)

But does it fix the problem you are experiencing?

Looks good to me, though I am not a ports committer (yet), so it would be better to have someone else to review it :-)

Switch to use noflavors and add PY_FLAVORS.
Update the WWW link.

I get what you are saying about this and I chose to take the "noflavors" road since the app will not be used as a module. However, I find that once I switched from concurrent to noflavors, Python 2.7 (instead of 3.6) version of all the dependencies will be used during a poudriere testport. Do you have any clues about this?

Ping, need review on the noflavors confusion.

@adamw I prefer treating it as a utility which people will not care about which languages it uses, and just omitting the python prefix in the port name.

Update as the reviewers requested.

In D13460#281614, @yuri wrote:

The word magnificent essentially expresses somebody's opinion. IMO, it shouldn't be used in package descriptions, because other people might have different opinions. It should stick to facts. :)

In D13460#281569, @adamw wrote:

Take a look at https://www.freshports.org/python. There are tons of non-module ports in the python category. I think it's completely appropriate to include it there too.

Ah, they all should be RUN_DEPENDS then...

Switched to use RUN_DEPENDS and rearranged the dependency list.

In D13425#280692, @adamw wrote:

Looks good, go for it! In your commit message, use "Differential Revision" instead of "Differential_Revision" (no underscore).

In D13425#280692, @adamw wrote:

Looks good, go for it! In your commit message, use "Differential Revision" instead of "Differential_Revision" (no underscore).