ygy (Guangyuan Yang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2017, 9:58 PM (55 w, 7 h)

Recent Activity

Mon, Jun 18

ygy committed rD51866: Start syncing news from the English version from 2018..
Start syncing news from the English version from 2018.
Mon, Jun 18, 6:42 AM
ygy closed D15845: Start syncing news from the English version from 2018..
Mon, Jun 18, 6:42 AM

Sun, Jun 17

ygy committed rP472635: - Update devel/py-gitpython to 2.1.10..
- Update devel/py-gitpython to 2.1.10.
Sun, Jun 17, 8:44 PM
ygy closed D15790: Update devel/py-gitpython to 2.1.10.
Sun, Jun 17, 8:44 PM

Sat, Jun 16

ygy updated the test plan for D15845: Start syncing news from the English version from 2018..
Sat, Jun 16, 6:44 AM
ygy updated the diff for D15845: Start syncing news from the English version from 2018..
Sat, Jun 16, 6:42 AM
ygy updated the diff for D15845: Start syncing news from the English version from 2018..
Sat, Jun 16, 6:36 AM
ygy created D15845: Start syncing news from the English version from 2018..
Sat, Jun 16, 6:30 AM
ygy updated the diff for D15790: Update devel/py-gitpython to 2.1.10.
Sat, Jun 16, 6:18 AM
ygy updated the diff for D15790: Update devel/py-gitpython to 2.1.10.
Sat, Jun 16, 6:16 AM
ygy committed rD51843: Merge header updates from the English version..
Merge header updates from the English version.
Sat, Jun 16, 6:03 AM
ygy closed D15838: Merge header updates from the English version.
Sat, Jun 16, 6:03 AM

Fri, Jun 15

ygy added a comment to D15838: Merge header updates from the English version.

LGTM in principal.

Should we translate terms like "Repository", etc.? It might be confusing for a newcomer what is "Phabricator" by the way, but it might need to be addressed in the English version as well.

Fri, Jun 15, 11:55 PM
ygy updated the diff for D15838: Merge header updates from the English version.
Fri, Jun 15, 11:28 PM
ygy updated the summary of D15838: Merge header updates from the English version.
Fri, Jun 15, 11:28 PM
ygy created D15838: Merge header updates from the English version.
Fri, Jun 15, 11:22 PM
ygy committed rP472479: Update devel/py-decorator to 2.3.0..
Update devel/py-decorator to 2.3.0.
Fri, Jun 15, 6:17 PM
ygy closed D15783: Update devel/py-decorator to 2.3.0.
Fri, Jun 15, 6:17 PM

Wed, Jun 13

ygy created D15790: Update devel/py-gitpython to 2.1.10.
Wed, Jun 13, 1:17 PM
ygy retitled D15783: Update devel/py-decorator to 2.3.0 from Update devel/py-gitpython to 2.3.0 to Update devel/py-decorator to 2.3.0.
Wed, Jun 13, 12:51 PM
ygy created D15783: Update devel/py-decorator to 2.3.0.
Wed, Jun 13, 3:09 AM

Mon, Jun 11

ygy committed rP472189: Update misc/thefuck to 3.27..
Update misc/thefuck to 3.27.
Mon, Jun 11, 3:33 PM
ygy closed D15730: Update misc/thefuck to 3.27.
Mon, Jun 11, 3:33 PM
ygy added a comment to D15730: Update misc/thefuck to 3.27.

@mat Thank you, noted.

Mon, Jun 11, 2:16 PM
ygy updated the diff for D15730: Update misc/thefuck to 3.27.
Mon, Jun 11, 2:16 PM

Sun, Jun 10

ygy created D15730: Update misc/thefuck to 3.27.
Sun, Jun 10, 6:23 AM

Sat, Jun 9

ygy closed D15721: Add myself to the calendar.

Closed by https://svnweb.freebsd.org/base?view=revision&revision=334895

Sat, Jun 9, 9:15 PM
ygy committed rP472091: - Update devel/py-gitpython to 2.1.9.
- Update devel/py-gitpython to 2.1.9
Sat, Jun 9, 9:14 PM
ygy closed D14899: devel/py-gitpython: Update to 2.1.9.
Sat, Jun 9, 9:14 PM
ygy committed rS334895: Add myself to the calendar.
Add myself to the calendar
Sat, Jun 9, 9:05 PM
ygy added a comment to D15721: Add myself to the calendar.

No underscore in the commit metadata :)

Sat, Jun 9, 9:02 PM
ygy created D15721: Add myself to the calendar.
Sat, Jun 9, 8:32 PM

Thu, Jun 7

ygy updated the test plan for D14899: devel/py-gitpython: Update to 2.1.9.
Thu, Jun 7, 3:06 PM
ygy added a comment to D14899: devel/py-gitpython: Update to 2.1.9.

@woodsb02 @mat Noted and updated the test plan. I will include these in future reviews.

Thu, Jun 7, 3:03 PM
ygy closed D15670: Update release information in zh_CN.UTF-8/share/xml/l10n.ent.
Thu, Jun 7, 2:52 PM
ygy committed rD51795: Update release information in zh_CN.UTF-8/share/xml/l10n.ent..
Update release information in zh_CN.UTF-8/share/xml/l10n.ent.
Thu, Jun 7, 2:52 PM

Wed, Jun 6

ygy committed rD51786: Add the 25th anniversary logo to zh_CN.UTF-8/htdocs/index.xsl..
Add the 25th anniversary logo to zh_CN.UTF-8/htdocs/index.xsl.
Wed, Jun 6, 2:28 PM
ygy closed D15658: Add the 25th anniversary logo to zh_CN home page.
Wed, Jun 6, 2:28 PM
ygy committed rD51785: Update zh_CN.UTF-8/htdocs/index.xsl from the en_US version..
Update zh_CN.UTF-8/htdocs/index.xsl from the en_US version.
Wed, Jun 6, 1:26 PM
ygy closed D15671: Update zh_CN.UTF-8/htdocs/index.xsl.
Wed, Jun 6, 1:26 PM
ygy updated the summary of D15671: Update zh_CN.UTF-8/htdocs/index.xsl.
Wed, Jun 6, 5:59 AM
ygy added a comment to D15658: Add the 25th anniversary logo to zh_CN home page.

This review is to merge the latest r51696 from English version:
https://svnweb.freebsd.org/doc/head/en_US.ISO8859-1/htdocs/index.xsl?r1=51605&r2=51696

There are still a few commits need to be merged since r49485:

% grep 'Original revision' zh_CN.UTF-8/htdocs/index.xsl                                       
<!-- Original revision: r49485 -->

% svnlite log --diff -r 49485:51605 svn://svn.freebsd.org/doc/head/en_US.ISO8859-1/htdocs/index.xsl
Wed, Jun 6, 5:58 AM
ygy retitled D15671: Update zh_CN.UTF-8/htdocs/index.xsl from Update to Update zh_CN.UTF-8/htdocs/index.xsl.
Wed, Jun 6, 5:56 AM
ygy created D15671: Update zh_CN.UTF-8/htdocs/index.xsl.
Wed, Jun 6, 5:53 AM
ygy created D15670: Update release information in zh_CN.UTF-8/share/xml/l10n.ent.
Wed, Jun 6, 5:11 AM
ygy committed rD51780: - Import release information to zh_CN.UTF-8/share/xml/l10n.ent..
- Import release information to zh_CN.UTF-8/share/xml/l10n.ent.
Wed, Jun 6, 4:30 AM
ygy closed D13120: Update share/xml/l10n.ent.
Wed, Jun 6, 4:30 AM

Mon, Jun 4

ygy added a comment to D13120: Update share/xml/l10n.ent.
Mon, Jun 4, 1:03 PM
ygy added a comment to D15658: Add the 25th anniversary logo to zh_CN home page.

I assume 49485:51605 will be merged later, right?

Mon, Jun 4, 1:01 PM
ygy created D15658: Add the 25th anniversary logo to zh_CN home page.
Mon, Jun 4, 3:27 AM
ygy updated the diff for D13120: Update share/xml/l10n.ent.

Update the patch.

Mon, Jun 4, 3:17 AM

Thu, May 24

ygy updated the summary of D14899: devel/py-gitpython: Update to 2.1.9.
Thu, May 24, 5:26 PM
ygy added a comment to D14899: devel/py-gitpython: Update to 2.1.9.
In D14899#327968, @mat wrote:
In D14899#327870, @ygy wrote:
In D14899#326603, @mat wrote:

I am not sure what the "3 consecutive times" adds here, could you explain?

From https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.html:

If the maintainer does not respond within three months, or if there have been three consecutive timeouts, then that maintainer is considered absent without leave, and can be replaced as the maintainer of the particular port in question.

I realized that the statement could probably be omitted here, but I just wanted to address that. Do you have a better suggestion for this circumstance?

Well, this sentence is not there for that purpose. This sentence means that if there are three consecutive timeouts, the maintainership can be reset to whatever is needed, most of the time, ports@ or any generic maintainer like perl@ or python@, and the previous maintainer cannot complain about it.

But any patch can be applied after only one maintainer timeout, including one which changes the maintainership.

Thu, May 24, 5:25 PM

May 23 2018

ygy added a comment to D14899: devel/py-gitpython: Update to 2.1.9.
In D14899#326603, @mat wrote:

I am not sure what the "3 consecutive times" adds here, could you explain?

May 23 2018, 3:55 AM

May 16 2018

ygy updated the test plan for D14899: devel/py-gitpython: Update to 2.1.9.
May 16 2018, 9:33 PM
ygy updated the summary of D14899: devel/py-gitpython: Update to 2.1.9.
May 16 2018, 5:22 PM
ygy updated the diff for D14899: devel/py-gitpython: Update to 2.1.9.
May 16 2018, 5:12 PM

Apr 1 2018

ygy added a comment to D14899: devel/py-gitpython: Update to 2.1.9.

Hi ygy,
This review is marked as "changes planned" - was this deliberate? If so, can you describe the problems you have found which are planning to address?
Cheers,
Ben

Apr 1 2018, 6:28 PM

Mar 29 2018

ygy planned changes to D14899: devel/py-gitpython: Update to 2.1.9.
Mar 29 2018, 6:31 PM
ygy created D14899: devel/py-gitpython: Update to 2.1.9.
Mar 29 2018, 6:31 PM

Mar 28 2018

ygy committed rD51520: Update zh_CN/share/xml/release.l10n.ent based on the latest en_US version..
Update zh_CN/share/xml/release.l10n.ent based on the latest en_US version.
Mar 28 2018, 7:23 PM
ygy closed D13117: Simplified Chinese Documentation Project: Update share/xml/release.l10n.ent.
Mar 28 2018, 7:23 PM

Mar 27 2018

ygy added a comment to D13117: Simplified Chinese Documentation Project: Update share/xml/release.l10n.ent.

@loader @delphij could you please approve this when you have time to take a look?

Mar 27 2018, 9:49 PM
ygy committed rP465659: - Update devel/py-colorama to 0.3.9.
- Update devel/py-colorama to 0.3.9
Mar 27 2018, 2:51 AM
ygy closed D14852: devel/py-colorama: Update to 0.3.9 and take maintainership.
Mar 27 2018, 2:51 AM
ygy added a comment to D14852: devel/py-colorama: Update to 0.3.9 and take maintainership.

Hi @woodsb02, thanks! I noted your suggestions and will learn from it. I will also add the maintainer timeout info to the commit message.

Mar 27 2018, 2:43 AM

Mar 26 2018

ygy updated the diff for D14852: devel/py-colorama: Update to 0.3.9 and take maintainership.
Mar 26 2018, 11:29 AM
ygy created D14852: devel/py-colorama: Update to 0.3.9 and take maintainership.
Mar 26 2018, 10:31 AM

Mar 24 2018

ygy committed rP465429: - Add websocketd 0.3.0.
- Add websocketd 0.3.0
Mar 24 2018, 6:43 AM

Mar 23 2018

ygy updated the diff for D13117: Simplified Chinese Documentation Project: Update share/xml/release.l10n.ent.

The school has been pretty busy in the past months, sorry! Will try to catch up :-)

Mar 23 2018, 7:47 AM

Feb 28 2018

ygy added a comment to D14532: Fix the problem described in PR #226221. (I think).
In D14532#305009, @mat wrote:
In D14532#304868, @ygy wrote:

Looks good to me, though I am not a ports committer (yet), so it would be better to have someone else to review it :-)

But does it fix the problem you are experiencing?

Feb 28 2018, 10:06 PM

Feb 27 2018

ygy accepted D14532: Fix the problem described in PR #226221. (I think).

Looks good to me, though I am not a ports committer (yet), so it would be better to have someone else to review it :-)

Feb 27 2018, 7:16 PM

Jan 16 2018

ygy committed rP459153: Update devel/py-decorator to 4.2.1.
Update devel/py-decorator to 4.2.1
Jan 16 2018, 4:06 AM
ygy closed D13930: devel/py-decorator: Update to 4.2.1.
Jan 16 2018, 4:06 AM
ygy updated the summary of D13930: devel/py-decorator: Update to 4.2.1.
Jan 16 2018, 2:53 AM
ygy created D13930: devel/py-decorator: Update to 4.2.1.
Jan 16 2018, 2:52 AM

Jan 5 2018

ygy committed rP458123: - Add thefuck 3.25.
- Add thefuck 3.25
Jan 5 2018, 9:27 AM
ygy closed D13460: [NEW] misc/thefuck: App that corrects your previous console command.
Jan 5 2018, 9:27 AM

Jan 2 2018

ygy updated the diff for D13460: [NEW] misc/thefuck: App that corrects your previous console command.

Switch to use noflavors and add PY_FLAVORS.
Update the WWW link.

Jan 2 2018, 4:00 PM

Jan 1 2018

ygy added a comment to D13460: [NEW] misc/thefuck: App that corrects your previous console command.

I get what you are saying about this and I chose to take the "noflavors" road since the app will not be used as a module. However, I find that once I switched from concurrent to noflavors, Python 2.7 (instead of 3.6) version of all the dependencies will be used during a poudriere testport. Do you have any clues about this?

Jan 1 2018, 9:15 PM

Dec 28 2017

ygy added a comment to D13460: [NEW] misc/thefuck: App that corrects your previous console command.

Ping, need review on the noflavors confusion.

Dec 28 2017, 12:15 PM

Dec 19 2017

ygy requested review of D13460: [NEW] misc/thefuck: App that corrects your previous console command.
Dec 19 2017, 8:17 AM
ygy removed a reviewer for D13460: [NEW] misc/thefuck: App that corrects your previous console command: yuri.
Dec 19 2017, 8:17 AM
ygy added a comment to D13460: [NEW] misc/thefuck: App that corrects your previous console command.

@adamw I prefer treating it as a utility which people will not care about which languages it uses, and just omitting the python prefix in the port name.

Dec 19 2017, 8:16 AM

Dec 18 2017

ygy retitled D13460: [NEW] misc/thefuck: App that corrects your previous console command from [NEW] misc/thefuck: Magnificent app which corrects your previous console command to [NEW] misc/thefuck: App that corrects your previous console command.
Dec 18 2017, 2:23 AM

Dec 16 2017

ygy planned changes to D13460: [NEW] misc/thefuck: App that corrects your previous console command.
Dec 16 2017, 6:37 AM

Dec 14 2017

ygy added inline comments to D13460: [NEW] misc/thefuck: App that corrects your previous console command.
Dec 14 2017, 12:30 PM
ygy updated the diff for D13460: [NEW] misc/thefuck: App that corrects your previous console command.

Update as the reviewers requested.

Dec 14 2017, 3:06 AM
ygy added a comment to D13460: [NEW] misc/thefuck: App that corrects your previous console command.
In D13460#281614, @yuri wrote:

The word magnificent essentially expresses somebody's opinion. IMO, it shouldn't be used in package descriptions, because other people might have different opinions. It should stick to facts. :)

Dec 14 2017, 3:05 AM
ygy added a comment to D13460: [NEW] misc/thefuck: App that corrects your previous console command.

Take a look at https://www.freshports.org/python. There are tons of non-module ports in the python category. I think it's completely appropriate to include it there too.

Dec 14 2017, 3:02 AM

Dec 13 2017

ygy planned changes to D13460: [NEW] misc/thefuck: App that corrects your previous console command.
Dec 13 2017, 5:55 AM
ygy added a comment to D13460: [NEW] misc/thefuck: App that corrects your previous console command.

Ah, they all should be RUN_DEPENDS then...

Dec 13 2017, 3:35 AM
ygy updated the diff for D13460: [NEW] misc/thefuck: App that corrects your previous console command.

Switched to use RUN_DEPENDS and rearranged the dependency list.

Dec 13 2017, 3:32 AM

Dec 12 2017

ygy created D13460: [NEW] misc/thefuck: App that corrects your previous console command.
Dec 12 2017, 7:11 AM

Dec 10 2017

ygy committed rP455881: - Update devel/py-decorator to 4.1.2.
- Update devel/py-decorator to 4.1.2
Dec 10 2017, 3:58 AM
ygy closed D13425: devel/py-decorator: Update to 4.1.2, take maintainership.
Dec 10 2017, 3:58 AM
ygy committed rP455880: devel/py-pyte: Update to 0.7.0.
devel/py-pyte: Update to 0.7.0
Dec 10 2017, 3:40 AM
ygy added a comment to D13425: devel/py-decorator: Update to 4.1.2, take maintainership.

Looks good, go for it! In your commit message, use "Differential Revision" instead of "Differential_Revision" (no underscore).

Dec 10 2017, 3:21 AM
ygy added a comment to D13425: devel/py-decorator: Update to 4.1.2, take maintainership.

Looks good, go for it! In your commit message, use "Differential Revision" instead of "Differential_Revision" (no underscore).

Dec 10 2017, 3:21 AM

Dec 8 2017

ygy created D13425: devel/py-decorator: Update to 4.1.2, take maintainership.
Dec 8 2017, 5:01 PM