Not a ports committer, but it looks good to me!

In D19799#424790, @bcr wrote:

Who's gonna commit this?

Thanks @bcr and @crees, closing https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232956 now.

I will go ahead and commit it.

LGTM.

@woodsb02 Hi, I forgot to mention that this is submitted by maintainer. I will address this in the commit message. Thank you!

In D16208#344063, @loader wrote:

In D16208#343830, @ygy wrote:

@delphij @loader One question: Looking at the diff of built website before and after this change (https://github.com/yzgyyang/freebsd-doc-web-deploy/commit/dec5f088af404cbdd5dca78bbd21f4acedf56576#diff-effdc1d6d041099f8126e5625ae4f8f3R2), it seems that the last person that changed contents in releases/12.0R/ became me as well (A diff from releases/12.0R/: https://www.diffchecker.com/iWeGDYXR).

Is this expected?

Yes.

<a id="idp59150920"> is defined in /usr/local/share/xsl/docbook-ns/xhtml/titlepage.xsl line 1031

1010  <xsl:template match="d:title" mode="titlepage.mode">
1011    <xsl:variable name="id">
1012      <xsl:choose>
1013        <!-- if title is in an *info wrapper, get the grandparent -->
1014        <xsl:when test="contains(local-name(..), 'info')">
1015          <xsl:call-template name="object.id">
1016            <xsl:with-param name="object" select="../.."/>
1017          </xsl:call-template>
1018        </xsl:when>
1019        <xsl:otherwise>
1020          <xsl:call-template name="object.id">
1021            <xsl:with-param name="object" select=".."/>
1022          </xsl:call-template>
1023        </xsl:otherwise>
1024      </xsl:choose>
1025    </xsl:variable>
1026
1027    <h1>
1028      <xsl:apply-templates select="." mode="common.html.attributes"/>
1029      <xsl:choose>
1030        <xsl:when test="$generate.id.attributes = 0">
1031          <a id="{$id}"/>
1032        </xsl:when>
1033        <xsl:otherwise>
1034        </xsl:otherwise>
1035      </xsl:choose>

the value of idp59150920 was generated by generate-id():
/usr/local/share/xsl/docbook-ns/common/common.xsl

457  <xsl:template name="object.id">
458    <xsl:param name="object" select="."/>
459    <xsl:choose>
460      <xsl:when test="$object/@id">
461        <xsl:value-of select="$object/@id"/>
462      </xsl:when>
463      <xsl:when test="$object/@xml:id">
464        <xsl:value-of select="$object/@xml:id"/>
465      </xsl:when>
466      <xsl:when test="$generate.consistent.ids != 0">
467        <!-- Make $object the current node -->
468        <xsl:for-each select="$object">
469          <xsl:text>id-</xsl:text>
470          <xsl:number level="multiple" count="*"/>
471        </xsl:for-each>
472      </xsl:when>
473      <xsl:otherwise>
474        <xsl:value-of select="generate-id($object)"/>
475      </xsl:otherwise>
476    </xsl:choose>
477  </xsl:template>

Last modified on 2018-07-10 16:41:45 -0400 by Guangyuan Yang.
The parameters passed to xsltproc was generated by the last commit from Git,
It seems the ${SRCS} was empty ...
https://svnweb.freebsd.org/doc/head/share/mk/doc.docbook.mk?revision=51528&view=markup#l95

95      # If using git, use git log.  The revision won't work with the generated links,
96      # because it is a hash, and git log doesn't know about git svn find-rev.
97      .if exists(${DOC_PREFIX}/.git) && exists(${GIT})
98      LATESTREVISION!=cd ${.CURDIR} && ${GIT} log -1 --pretty=format:'\
99              --stringparam latestrevision.timestamp "%ci" \
100             --stringparam latestrevision.committer "%cn" \
101             --stringparam latestrevision.number "%h"' ${SRCS}

@delphij @loader One question: Looking at the diff of built website before and after this change (https://github.com/yzgyyang/freebsd-doc-web-deploy/commit/dec5f088af404cbdd5dca78bbd21f4acedf56576#diff-effdc1d6d041099f8126e5625ae4f8f3R2), it seems that the last person that changed contents in releases/12.0R/ became me as well (A diff from releases/12.0R/: https://www.diffchecker.com/iWeGDYXR).