eric_metricspace.net (Eric McCorkle)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2015, 11:25 PM (106 w, 6 d)

Recent Activity

Fri, Nov 17

eric_metricspace.net updated the diff for D12698: Add EFI KMS and keybuf integration.

Rebased to HEAD

Fri, Nov 17, 3:32 AM
eric_metricspace.net updated the diff for D12692: Add boot crypto framework.

Rebased to HEAD.

Fri, Nov 17, 2:31 AM

Oct 23 2017

eric_metricspace.net added a comment to D12732: Revert efipart to use EFI_HANDLEs for partitions.

OK, I know how to deal with the partition info from disks. I'm going to add a field to the pdinfo_list which contains the partition type, and I'll pluck it out of the devpaths when we register the partitions. The partition relationships can be obtained from the pdinfo list already.

Oct 23 2017, 11:36 PM
eric_metricspace.net added inline comments to D12732: Revert efipart to use EFI_HANDLEs for partitions.
Oct 23 2017, 11:01 PM
eric_metricspace.net added a comment to D12690: Add GELI partition types.

Turns out this one is nowhere near complete. Need to add more stuff.

Oct 23 2017, 1:14 AM
eric_metricspace.net added a comment to D10512: GELI support for EFI loader.

This one breaks up much easier, since it's mostly new code. Be aware, however, that the changes will introduce dead code until the GELI driver itself goes in.

Hi Eric. I would like to merge in this work as is into TrueOS if it still works. Are there any merges besides the 4 commits from 10-17-17 that are needed for us to merge as is? Is there a separate commit for the "GELI driver"?

Oct 23 2017, 12:50 AM

Oct 19 2017

eric_metricspace.net added a dependent revision for D12732: Revert efipart to use EFI_HANDLEs for partitions: D10512: GELI support for EFI loader.
Oct 19 2017, 9:47 PM
eric_metricspace.net added a dependency for D10512: GELI support for EFI loader: D12732: Revert efipart to use EFI_HANDLEs for partitions.
Oct 19 2017, 9:47 PM
eric_metricspace.net created D12732: Revert efipart to use EFI_HANDLEs for partitions.
Oct 19 2017, 9:47 PM

Oct 17 2017

eric_metricspace.net removed a dependency for D12690: Add GELI partition types: D12698: Add EFI KMS and keybuf integration.
Oct 17 2017, 12:51 PM
eric_metricspace.net removed a dependent revision for D12698: Add EFI KMS and keybuf integration: D12690: Add GELI partition types.
Oct 17 2017, 12:51 PM
eric_metricspace.net added dependent revisions for D12698: Add EFI KMS and keybuf integration: D12690: Add GELI partition types, D10512: GELI support for EFI loader.
Oct 17 2017, 12:49 PM
eric_metricspace.net added a dependency for D10512: GELI support for EFI loader: D12698: Add EFI KMS and keybuf integration.
Oct 17 2017, 12:49 PM
eric_metricspace.net added a dependency for D12690: Add GELI partition types: D12698: Add EFI KMS and keybuf integration.
Oct 17 2017, 12:49 PM
eric_metricspace.net created D12698: Add EFI KMS and keybuf integration.
Oct 17 2017, 12:49 PM
eric_metricspace.net added a dependency for D10512: GELI support for EFI loader: D12692: Add boot crypto framework.
Oct 17 2017, 12:47 AM
eric_metricspace.net added a dependent revision for D12692: Add boot crypto framework: D10512: GELI support for EFI loader.
Oct 17 2017, 12:47 AM
eric_metricspace.net created D12692: Add boot crypto framework.
Oct 17 2017, 12:47 AM
eric_metricspace.net added a dependent revision for D12690: Add GELI partition types: D10512: GELI support for EFI loader.
Oct 17 2017, 12:40 AM
eric_metricspace.net added a dependency for D10512: GELI support for EFI loader: D12690: Add GELI partition types.
Oct 17 2017, 12:40 AM
eric_metricspace.net created D12690: Add GELI partition types.
Oct 17 2017, 12:34 AM
eric_metricspace.net added a comment to D10512: GELI support for EFI loader.

This one breaks up much easier, since it's mostly new code. Be aware, however, that the changes will introduce dead code until the GELI driver itself goes in.

Oct 17 2017, 12:07 AM

Oct 16 2017

eric_metricspace.net added a comment to D10512: GELI support for EFI loader.

This one is finally on deck. I am currently running a build/test cycle after merging from HEAD following the commit of boot1_refactor. I don't anticipate breakage, but it's best to be sure. Allan should run his tests once I get through mine, since he found some issues I didn't.

Oct 16 2017, 11:56 AM

Oct 13 2017

eric_metricspace.net added a comment to D12659: [[ my current integration branch, that also has refactor work ]] Unify boot1 with loader.

Is this applied against some branch? I'm getting complaints about sys/boot/ficl.mk not being there

Oct 13 2017, 4:00 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.
In D10447#262876, @imp wrote:

Addressed review comments

Thanks for the updated. I'll pull this into the work I've done (I did that with a previous revision as well)

I'll look closely to see if there's anything else that's a show stopper. My quick spot check just shows niggles that can be handled after the commit and/or cleaned up prior to the commit. I'll get this in front of the boot1/loader changes I'm planning for efi boot manager. Though I'm wondering more and more why we even have boot1.... But that question isn't quite ripe to explore.

  • Looking at the symbols defined / referenced in boot1 there's the full ficl/forth interpreter as well... (I have this code rebased, with some of the removals reinserted).. will need to check further... - [edited: this was due to the refactor I've done, fixed]
Oct 13 2017, 3:13 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

That's how the EFI boot stuff originally functioned. At some point, boot1.efi got added, but in the very beginning, you just installed loader.efi to the ESP.

Oct 13 2017, 11:02 AM

Oct 12 2017

eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Note: this needs to get a test before it's merged, because I did modify the code. But a basic smoke-test ought to do it.

Oct 12 2017, 12:17 AM

Oct 11 2017

eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Addressed review comments

Oct 11 2017, 11:46 PM

Oct 7 2017

eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Do you want me to fix these, or do you want me to just sit tight?

Oct 7 2017, 8:29 PM

Oct 6 2017

eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Merged from current and updated. No conflicts, so I think the tests are still good.

Oct 6 2017, 12:33 PM

Oct 2 2017

eric_metricspace.net added a comment to D12564: Abstract ZFS preferred device detection.

Confirmed this works in QEMU

Oct 2 2017, 10:24 PM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D12564: Abstract ZFS preferred device detection.
Oct 2 2017, 11:33 AM
eric_metricspace.net added a dependent revision for D12564: Abstract ZFS preferred device detection: D10447: Unify boot1 with loader.
Oct 2 2017, 11:33 AM
eric_metricspace.net created D12564: Abstract ZFS preferred device detection.
Oct 2 2017, 11:31 AM

Oct 1 2017

eric_metricspace.net added a comment to D10447: Unify boot1 with loader.
In D10447#260527, @imp wrote:

We can't land this first and then do my stuff. That would break already committed work in boot1's copy of efi_main.c.

This commit is also kinda too big to land all at once still, but I'll pull in as much as I can as I merge the efi_main's together to make the changes more bite-sized and bisectable should there be issues. There's been much grumbling of late about huge commits landing that break things that are impossible to bisect, so I'll have to break this up to ensure I won't be fielding complaints like that.

Oct 1 2017, 10:35 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.
In D10447#260523, @imp wrote:

I'll take another look at it this week. I have on my plate unifying the efi_main routines that we have in the tree and I have for my uefi boot manager work since they are somewhat similar. Once that's complete, I think the biggest obstacle to getting this into the tree will be behind us since that's the biggest source of conflicts at the moment.

Oct 1 2017, 10:13 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Also, just deployed to my laptop (multi-disk ZFS pool), and obviously it works.

Oct 1 2017, 10:09 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Fixed issues with setting image_handle->DeviceHandle incorrectly. Correct behavior confirmed on all my QEMU tests.

Oct 1 2017, 9:59 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Finally got time to do QEMU tests on this. Found some issues with setting the DeviceHandle on the loaded image. I fixed it for UFS detection. I also seem to have introduced a regression in ZFS preferred device detection, which I'm working to fix.

Oct 1 2017, 9:22 PM

Sep 29 2017

eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Merged from HEAD, corrected a trivial merge conflict

Sep 29 2017, 1:27 AM

Sep 19 2017

eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Also, someone please do a check for stray debug printfs. I am notoriously bad at spotting those.

Sep 19 2017, 2:50 AM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Fixed issues with preferred device detection. This includes detailed analysis of the code via debug messages to make sure it's doing the right thing. Preferred devices should now be correctly detected.

Sep 19 2017, 2:49 AM

Sep 12 2017

eric_metricspace.net added a comment to D10931: boot1 generate-fat: generate all templates at once.

I'm unsure as to what needs to happen now. Do I need to do anything to my patches yet?

Sep 12 2017, 11:24 PM

Sep 10 2017

eric_metricspace.net accepted D10931: boot1 generate-fat: generate all templates at once.
Sep 10 2017, 2:57 AM
eric_metricspace.net added a comment to D10931: boot1 generate-fat: generate all templates at once.

If I'm not mistaken, this should work as a precursor to my GELI patch series. I will apply this, then attempt a build with boot1_refactor also applied. That should tell us whether it does the job.

Sep 10 2017, 2:02 AM

Sep 9 2017

eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Overhauled preferred device detection

Sep 9 2017, 9:38 PM
eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Sep 9 2017, 2:52 AM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.
In D10447#252525, @imp wrote:

I forwarded ported this, but we're missing functionality that's been added in the past year.
See https://reviews.freebsd.org/D12161 for my forward port.
Functionality added in the year that's not in this forward port (or this current review):
o fallback to any device, that's not present.

Sep 9 2017, 2:46 AM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.
Sep 9 2017, 2:24 AM

Aug 13 2017

eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Aug 13 2017, 1:39 PM

Aug 4 2017

eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Aug 4 2017, 9:48 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Rebased to HEAD after committing portions of it as independent patches.

Aug 4 2017, 9:18 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Okay, I've broken this one up into a number of smaller ones. I will wait for the last of them to go in, then I'll rebase and we can go from there.

Aug 4 2017, 11:18 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D11862: Move EFI fmtdev functionality to libefi.
Aug 4 2017, 11:16 AM
eric_metricspace.net added a dependent revision for D11862: Move EFI fmtdev functionality to libefi: D10447: Unify boot1 with loader.
Aug 4 2017, 11:16 AM
eric_metricspace.net created D11862: Move EFI fmtdev functionality to libefi.
Aug 4 2017, 11:10 AM
eric_metricspace.net added a dependent revision for D11852: Add definitions and utilities for EFI drivers: D10447: Unify boot1 with loader.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D11852: Add definitions and utilities for EFI drivers.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependent revision for D11855: Move EFI ZFS functions to libefi: D10447: Unify boot1 with loader.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D11855: Move EFI ZFS functions to libefi.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D11858: Add EFI utility functions to libefi.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependent revision for D11858: Add EFI utility functions to libefi: D10447: Unify boot1 with loader.
Aug 4 2017, 12:41 AM
eric_metricspace.net created D11858: Add EFI utility functions to libefi.
Aug 4 2017, 12:41 AM

Aug 3 2017

eric_metricspace.net created D11855: Move EFI ZFS functions to libefi.
Aug 3 2017, 8:40 PM
eric_metricspace.net added a comment to D11844: Add stpcpy and stpncpy to libstand.

I am not a committer. Feel free to put it in.

Aug 3 2017, 6:08 PM
eric_metricspace.net created D11852: Add definitions and utilities for EFI drivers.
Aug 3 2017, 5:35 PM
eric_metricspace.net created D11844: Add stpcpy and stpncpy to libstand.
Aug 3 2017, 2:34 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

I will pull out some components of the patch and make some smaller ones.

Aug 3 2017, 2:16 PM

Aug 2 2017

eric_metricspace.net updated the diff for D10512: GELI support for EFI loader.

Rebased to HEAD

Aug 2 2017, 7:16 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Rebased to HEAD

Aug 2 2017, 7:15 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.
In D10447#245058, @imp wrote:

This review is a little out of date and is much more ambitious than what I've just done in https://reviews.freebsd.org/D11820 . which also sets down this path, but not as completely. I fear that will make this a little harder, but maybe not by too much.

Aug 2 2017, 7:14 PM

Jul 13 2017

eric_metricspace.net added a comment to D9680: Increase EFI MSDOSFS image size to 512Kib.
In D9680#239393, @imp wrote:

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

Jul 13 2017, 12:26 PM

Jul 12 2017

eric_metricspace.net added a comment to D10512: GELI support for EFI loader.

Rebased to head, addressed reviewer comments

Jul 12 2017, 10:14 AM
eric_metricspace.net updated the diff for D10512: GELI support for EFI loader.
Jul 12 2017, 10:13 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D9680: Increase EFI MSDOSFS image size to 512Kib.
Jul 12 2017, 10:02 AM
eric_metricspace.net added a dependent revision for D9680: Increase EFI MSDOSFS image size to 512Kib: D10447: Unify boot1 with loader.
Jul 12 2017, 10:02 AM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Rebased to master

Jul 12 2017, 10:00 AM

Jul 1 2017

eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Jul 1 2017, 10:20 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Remove extra bcache init

Jul 1 2017, 10:20 PM
eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Jul 1 2017, 10:15 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Also note that the increase dosfs size needs to go in first, or else it will break the build.

Jul 1 2017, 9:11 PM
eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Jul 1 2017, 9:09 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Address style and whitespace issues

Jul 1 2017, 9:09 PM
eric_metricspace.net accepted D9680: Increase EFI MSDOSFS image size to 512Kib.

As long as the max size is increased, it should work with my downstream changes.

Jul 1 2017, 8:40 PM
eric_metricspace.net added inline comments to D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.
Jul 1 2017, 6:51 PM
eric_metricspace.net updated the diff for D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.

Addressed style comments

Jul 1 2017, 6:51 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

If you can address the feedback that is here, and remove the whitespace changes, I think this is ready to land.

Jul 1 2017, 6:32 PM
eric_metricspace.net added a comment to D8575: Verified execution (veriexec) fingerprint loader.

If I understand this correctly, this is a system based on symmetric-key message authentication codes which allows specific files to be assigned specific a specific MAC, which is then checked when those files are loaded.

Jul 1 2017, 5:44 PM

Jun 29 2017

eric_metricspace.net updated the diff for D10512: GELI support for EFI loader.

Rebase to HEAD

Jun 29 2017, 12:42 AM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Rebase to HEAD

Jun 29 2017, 12:39 AM
eric_metricspace.net updated the diff for D9680: Increase EFI MSDOSFS image size to 512Kib.

Rebase to HEAD

Jun 29 2017, 12:36 AM
eric_metricspace.net updated the diff for D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.

Rebased to HEAD

Jun 29 2017, 12:34 AM

May 12 2017

eric_metricspace.net updated the diff for D10512: GELI support for EFI loader.

Resolved issues with booting, tested with successful boot on QEMU. This should work now, but still needs to be tested on real hardware.

May 12 2017, 12:00 AM

May 1 2017

eric_metricspace.net added inline comments to D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.
May 1 2017, 3:04 PM
eric_metricspace.net created D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.
May 1 2017, 2:44 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Use currdev environment variable, and libstand's basic file API.

May 1 2017, 1:13 AM

Apr 26 2017

eric_metricspace.net created D10512: GELI support for EFI loader.
Apr 26 2017, 5:26 PM

Apr 24 2017

eric_metricspace.net updated the diff for D10486: Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE.
Apr 24 2017, 11:25 PM
eric_metricspace.net updated the diff for D10487: Bug 218861 - libelf elf_update fails when adding sections.
Apr 24 2017, 11:23 PM
eric_metricspace.net updated the diff for D10487: Bug 218861 - libelf elf_update fails when adding sections.
Apr 24 2017, 11:23 PM