eric_metricspace.net (Eric McCorkle)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2015, 11:25 PM (97 w, 5 d)

Recent Activity

Tue, Sep 19

eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Also, someone please do a check for stray debug printfs. I am notoriously bad at spotting those.

Tue, Sep 19, 2:50 AM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Fixed issues with preferred device detection. This includes detailed analysis of the code via debug messages to make sure it's doing the right thing. Preferred devices should now be correctly detected.

Tue, Sep 19, 2:49 AM

Tue, Sep 12

eric_metricspace.net added a comment to D10931: boot1 generate-fat: generate all templates at once.

I'm unsure as to what needs to happen now. Do I need to do anything to my patches yet?

Tue, Sep 12, 11:24 PM

Sun, Sep 10

eric_metricspace.net accepted D10931: boot1 generate-fat: generate all templates at once.
Sun, Sep 10, 2:57 AM
eric_metricspace.net added a comment to D10931: boot1 generate-fat: generate all templates at once.

If I'm not mistaken, this should work as a precursor to my GELI patch series. I will apply this, then attempt a build with boot1_refactor also applied. That should tell us whether it does the job.

Sun, Sep 10, 2:02 AM

Sat, Sep 9

eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Overhauled preferred device detection

Sat, Sep 9, 9:38 PM
eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Sat, Sep 9, 2:52 AM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.
In D10447#252525, @imp wrote:

I forwarded ported this, but we're missing functionality that's been added in the past year.
See https://reviews.freebsd.org/D12161 for my forward port.
Functionality added in the year that's not in this forward port (or this current review):
o fallback to any device, that's not present.

Sat, Sep 9, 2:46 AM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.
Sat, Sep 9, 2:24 AM

Aug 13 2017

eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Aug 13 2017, 1:39 PM

Aug 4 2017

eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Aug 4 2017, 9:48 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Rebased to HEAD after committing portions of it as independent patches.

Aug 4 2017, 9:18 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Okay, I've broken this one up into a number of smaller ones. I will wait for the last of them to go in, then I'll rebase and we can go from there.

Aug 4 2017, 11:18 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D11862: Move EFI fmtdev functionality to libefi.
Aug 4 2017, 11:16 AM
eric_metricspace.net added a dependent revision for D11862: Move EFI fmtdev functionality to libefi: D10447: Unify boot1 with loader.
Aug 4 2017, 11:16 AM
eric_metricspace.net created D11862: Move EFI fmtdev functionality to libefi.
Aug 4 2017, 11:10 AM
eric_metricspace.net added a dependent revision for D11852: Add definitions and utilities for EFI drivers: D10447: Unify boot1 with loader.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D11852: Add definitions and utilities for EFI drivers.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependent revision for D11855: Move EFI ZFS functions to libefi: D10447: Unify boot1 with loader.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D11855: Move EFI ZFS functions to libefi.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D11858: Add EFI utility functions to libefi.
Aug 4 2017, 12:41 AM
eric_metricspace.net added a dependent revision for D11858: Add EFI utility functions to libefi: D10447: Unify boot1 with loader.
Aug 4 2017, 12:41 AM
eric_metricspace.net created D11858: Add EFI utility functions to libefi.
Aug 4 2017, 12:41 AM

Aug 3 2017

eric_metricspace.net created D11855: Move EFI ZFS functions to libefi.
Aug 3 2017, 8:40 PM
eric_metricspace.net added a comment to D11844: Add stpcpy and stpncpy to libstand.

I am not a committer. Feel free to put it in.

Aug 3 2017, 6:08 PM
eric_metricspace.net created D11852: Add definitions and utilities for EFI drivers.
Aug 3 2017, 5:35 PM
eric_metricspace.net created D11844: Add stpcpy and stpncpy to libstand.
Aug 3 2017, 2:34 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

I will pull out some components of the patch and make some smaller ones.

Aug 3 2017, 2:16 PM

Aug 2 2017

eric_metricspace.net updated the diff for D10512: GELI support for EFI loader.

Rebased to HEAD

Aug 2 2017, 7:16 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Rebased to HEAD

Aug 2 2017, 7:15 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.
In D10447#245058, @imp wrote:

This review is a little out of date and is much more ambitious than what I've just done in https://reviews.freebsd.org/D11820 . which also sets down this path, but not as completely. I fear that will make this a little harder, but maybe not by too much.

Aug 2 2017, 7:14 PM

Jul 13 2017

eric_metricspace.net added a comment to D9680: Increase EFI MSDOSFS image size to 512Kib.
In D9680#239393, @imp wrote:

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

Jul 13 2017, 12:26 PM

Jul 12 2017

eric_metricspace.net added a comment to D10512: GELI support for EFI loader.

Rebased to head, addressed reviewer comments

Jul 12 2017, 10:14 AM
eric_metricspace.net updated the diff for D10512: GELI support for EFI loader.
Jul 12 2017, 10:13 AM
eric_metricspace.net added a dependency for D10447: Unify boot1 with loader: D9680: Increase EFI MSDOSFS image size to 512Kib.
Jul 12 2017, 10:02 AM
eric_metricspace.net added a dependent revision for D9680: Increase EFI MSDOSFS image size to 512Kib: D10447: Unify boot1 with loader.
Jul 12 2017, 10:02 AM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Rebased to master

Jul 12 2017, 10:00 AM

Jul 1 2017

eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Jul 1 2017, 10:20 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Remove extra bcache init

Jul 1 2017, 10:20 PM
eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Jul 1 2017, 10:15 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Also note that the increase dosfs size needs to go in first, or else it will break the build.

Jul 1 2017, 9:11 PM
eric_metricspace.net added inline comments to D10447: Unify boot1 with loader.
Jul 1 2017, 9:09 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Address style and whitespace issues

Jul 1 2017, 9:09 PM
eric_metricspace.net accepted D9680: Increase EFI MSDOSFS image size to 512Kib.

As long as the max size is increased, it should work with my downstream changes.

Jul 1 2017, 8:40 PM
eric_metricspace.net added inline comments to D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.
Jul 1 2017, 6:51 PM
eric_metricspace.net updated the diff for D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.

Addressed style comments

Jul 1 2017, 6:51 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

If you can address the feedback that is here, and remove the whitespace changes, I think this is ready to land.

Jul 1 2017, 6:32 PM
eric_metricspace.net added a comment to D8575: Verified execution (veriexec) fingerprint loader.

If I understand this correctly, this is a system based on symmetric-key message authentication codes which allows specific files to be assigned specific a specific MAC, which is then checked when those files are loaded.

Jul 1 2017, 5:44 PM

Jun 29 2017

eric_metricspace.net updated the diff for D10512: GELI support for EFI loader.

Rebase to HEAD

Jun 29 2017, 12:42 AM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Rebase to HEAD

Jun 29 2017, 12:39 AM
eric_metricspace.net updated the diff for D9680: Increase EFI MSDOSFS image size to 512Kib.

Rebase to HEAD

Jun 29 2017, 12:36 AM
eric_metricspace.net updated the diff for D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.

Rebased to HEAD

Jun 29 2017, 12:34 AM

May 12 2017

eric_metricspace.net updated the diff for D10512: GELI support for EFI loader.

Resolved issues with booting, tested with successful boot on QEMU. This should work now, but still needs to be tested on real hardware.

May 12 2017, 12:00 AM

May 1 2017

eric_metricspace.net added inline comments to D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.
May 1 2017, 3:04 PM
eric_metricspace.net created D10559: Bug 219000 - Integer underflow in efipart_realstrategy when I/O starts after end of disk.
May 1 2017, 2:44 PM
eric_metricspace.net updated the diff for D10447: Unify boot1 with loader.

Use currdev environment variable, and libstand's basic file API.

May 1 2017, 1:13 AM

Apr 26 2017

eric_metricspace.net created D10512: GELI support for EFI loader.
Apr 26 2017, 5:26 PM

Apr 24 2017

eric_metricspace.net updated the diff for D10486: Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE.
Apr 24 2017, 11:25 PM
eric_metricspace.net updated the diff for D10487: Bug 218861 - libelf elf_update fails when adding sections.
Apr 24 2017, 11:23 PM
eric_metricspace.net updated the diff for D10487: Bug 218861 - libelf elf_update fails when adding sections.
Apr 24 2017, 11:23 PM
eric_metricspace.net created D10487: Bug 218861 - libelf elf_update fails when adding sections.
Apr 24 2017, 11:21 PM
eric_metricspace.net created D10486: Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE.
Apr 24 2017, 11:15 PM
eric_metricspace.net added a comment to D10447: Unify boot1 with loader.

Actually, there is a bug hiding out somewhere in this that causes ZFS volumes not to be detected.

Apr 24 2017, 5:51 PM

Apr 22 2017

eric_metricspace.net added inline comments to D10410: EFI_SIMPLE_FILE_SYSTEM driver.
Apr 22 2017, 1:15 AM

Apr 21 2017

eric_metricspace.net abandoned D7589: EFI boot1 and loader Refactoring.
Apr 21 2017, 2:58 PM
eric_metricspace.net created D10447: Unify boot1 with loader.
Apr 21 2017, 2:57 PM

Apr 17 2017

eric_metricspace.net abandoned D9679: Add API functions and interfaces for EFI refactoring.
Apr 17 2017, 12:34 AM
eric_metricspace.net abandoned D9909: Add getdesc interface to struct devsw.
Apr 17 2017, 12:33 AM
eric_metricspace.net abandoned D9687: Add string16 API.
Apr 17 2017, 12:33 AM
eric_metricspace.net created D10410: EFI_SIMPLE_FILE_SYSTEM driver.
Apr 17 2017, 12:31 AM

Apr 1 2017

eric_metricspace.net updated the diff for D9679: Add API functions and interfaces for EFI refactoring.

Remove unnecessary changes to handles.c

Apr 1 2017, 12:17 PM
eric_metricspace.net added a comment to D9679: Add API functions and interfaces for EFI refactoring.

Actually, efi_register_handle and efi_handle_remove_dev can be deleted from this patch. They were an artifact of when I tried to add hot-plugging support to the EFI loader (it doesn't work because bcache doesn't support it)

Apr 1 2017, 11:38 AM
eric_metricspace.net updated the diff for D9679: Add API functions and interfaces for EFI refactoring.

Removed getdesc function for ZFS (this was moved into the getdesc patch)

Apr 1 2017, 11:16 AM
eric_metricspace.net updated the diff for D9687: Add string16 API.
Apr 1 2017, 3:51 AM

Mar 31 2017

eric_metricspace.net updated the diff for D9575: Boot-time Key Intake Metadata.

Integrate allanjude's pull request

Mar 31 2017, 11:37 AM
eric_metricspace.net updated the diff for D9575: Boot-time Key Intake Metadata.

Rebased after alanjude's patch adding explicit_bzero to boot loaders

Mar 31 2017, 1:44 AM

Mar 6 2017

eric_metricspace.net updated the diff for D9575: Boot-time Key Intake Metadata.

Add changes by Allan Jude, adding support to boot2

Mar 6 2017, 6:23 PM
eric_metricspace.net added inline comments to D9909: Add getdesc interface to struct devsw.
Mar 6 2017, 6:18 PM
eric_metricspace.net retitled D9909: Add getdesc interface to struct devsw from to Add getdesc interface to struct devsw.
Mar 6 2017, 6:16 PM

Mar 1 2017

eric_metricspace.net added a comment to D9798: Add explicit_bzero() to libstand.

Good change for my pending keybuf work

Mar 1 2017, 3:03 PM

Feb 20 2017

eric_metricspace.net updated the diff for D9575: Boot-time Key Intake Metadata.
Feb 20 2017, 11:03 PM
eric_metricspace.net added a comment to D9687: Add string16 API.

I like the interface in lib/libefi/libefi.c

Feb 20 2017, 7:51 PM
eric_metricspace.net added a comment to D9687: Add string16 API.
In D9687#200246, @imp wrote:

All the string functions suffer from the same problem we have with the original string functions you replaced: they don't properly implement character conversions. Please see the efivar stuff I did in -current to see what you need to do there. And you should put the functions I wrote there into libstand. While these functions work well enough for ASCIIish things, they fail for anything more complex. If we're going to rework things, let's do it correctly and reuse what was done correctly for efivar (who, to be fair, stole and reworked the code from Marcel's earlier efi on ia64 work).

Feb 20 2017, 4:59 PM
eric_metricspace.net retitled D9687: Add string16 API from to Add string16 API.
Feb 20 2017, 2:06 PM
eric_metricspace.net updated the diff for D9679: Add API functions and interfaces for EFI refactoring.

Add some more utility functions

Feb 20 2017, 2:00 PM
eric_metricspace.net retitled D9680: Increase EFI MSDOSFS image size to 512Kib from to Increase EFI MSDOSFS image size to 512Kib.
Feb 20 2017, 12:12 AM
eric_metricspace.net added reviewers for D9679: Add API functions and interfaces for EFI refactoring: manu, emaste, imp.
Feb 20 2017, 12:05 AM
eric_metricspace.net added reviewers for D9679: Add API functions and interfaces for EFI refactoring: allanjude, tsoome, cpm.
Feb 20 2017, 12:04 AM
eric_metricspace.net retitled D9679: Add API functions and interfaces for EFI refactoring from to Add API functions and interfaces for EFI refactoring.
Feb 20 2017, 12:04 AM

Feb 19 2017

eric_metricspace.net added inline comments to D9575: Boot-time Key Intake Metadata.
Feb 19 2017, 11:51 PM
eric_metricspace.net added inline comments to D9575: Boot-time Key Intake Metadata.
Feb 19 2017, 9:28 PM
eric_metricspace.net updated the diff for D9575: Boot-time Key Intake Metadata.
Feb 19 2017, 9:28 PM
eric_metricspace.net added a comment to D7589: EFI boot1 and loader Refactoring.

Update on this patch: I'm going to attempt to break it up into some smaller changesets to make it more manageable.

Feb 19 2017, 1:03 PM
eric_metricspace.net added inline comments to D9575: Boot-time Key Intake Metadata.
Feb 19 2017, 12:55 PM

Feb 18 2017

eric_metricspace.net added a comment to D9575: Boot-time Key Intake Metadata.
In D9575#199104, @cem wrote:

This diff lacks context. Please use arc or diff with -U999999.

Feb 18 2017, 5:08 PM
eric_metricspace.net added inline comments to D9575: Boot-time Key Intake Metadata.
Feb 18 2017, 4:57 PM
eric_metricspace.net updated the diff for D9575: Boot-time Key Intake Metadata.
Feb 18 2017, 4:54 PM

Feb 16 2017

eric_metricspace.net added a comment to D9575: Boot-time Key Intake Metadata.
In D9575#199104, @cem wrote:
Feb 16 2017, 8:21 PM

Feb 15 2017

eric_metricspace.net updated the diff for D9575: Boot-time Key Intake Metadata.
Feb 15 2017, 4:12 PM

Feb 14 2017

eric_metricspace.net updated the diff for D9575: Boot-time Key Intake Metadata.

Moved MODINFOMD_KEYBUF definition to sys/linker.h

Feb 14 2017, 6:11 PM