Page MenuHomeFreeBSD

[[ my current integration branch, that also has refactor work ]] Unify boot1 with loader
AbandonedPublic

Authored by imp on Oct 13 2017, 3:23 PM.
Tags
None
Referenced Files
F157056744: D12659.id33956.diff
Mon, May 18, 4:38 AM
F156994845: D12659.id33972.diff
Sun, May 17, 8:59 PM
F156970265: D12659.id.diff
Sun, May 17, 5:22 PM
Unknown Object (File)
Fri, May 15, 1:23 PM
Unknown Object (File)
Fri, May 15, 1:22 PM
Unknown Object (File)
Mon, May 11, 10:20 AM
Unknown Object (File)
Mon, May 11, 3:37 AM
Unknown Object (File)
Mon, May 11, 3:37 AM

Details

Reviewers
None
Summary

Refactor boot1 to use the same I/O code as /boot/loader uses. Refactor
to use the common efi_main.c.

Submitted by: Eric McCorkle

Move orphaned man pages into new man directory from common. This helps keep cleaer that common is just for the MI files for /boot/loader programs.

Sponsored by: Netflix

Rename top level Makefile.ficl to ficl.mk.

Move common/Makefile.inc to sys/boot/loader.mk.

Makefile.inc has a specific meaning in the tree, and
common/Makefile.inc doesn't quite fit into that. Rename it to
loader.mk and it will be a place to collect common things to all
/boot/loader programs there.

Sponsored by: Netflix

tweak style

create defs.mk for common definitions

Move all the ficl common code into ficl.mk

There's a number of copies of basically identical code to enable
building forth in /boot/loader. Move it all into ficl.mk.

LOADER_foo_SUPPORTED

Explicitly inlcude SYSDIR in the include path -- need machine path too?

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12041
Build 12350: arc lint + arc unit

Event Timeline

Is this applied against some branch? I'm getting complaints about sys/boot/ficl.mk not being there

Is this applied against some branch? I'm getting complaints about sys/boot/ficl.mk not being there

The patch is against -current as of earlier today...

In D12659#262923, @imp wrote:

Is this applied against some branch? I'm getting complaints about sys/boot/ficl.mk not being there

The patch is against -current as of earlier today...

Looking at the raw diff shows something is amiss. I'll just update this with the one change.