Page MenuHomeFreeBSD

sysutils/grub2: revive GRUB port
Needs RevisionPublic

Authored by eric_metricspace.net on Sep 7 2019, 1:11 AM.

Details

Reviewers
lwhsu
Summary

This patch updates the GRUB port to a recent release, restores functionality, and adds more build options.

This is not yet ready to be committed, but it can be reviewed/tested.

Test Plan

This has been tested with EFI. There are issues (namely, it does not properly pass the information for the kernel to initialize the EFI frame buffer), but it is capable of booting. The PC version can be tested with a legacy BIOS setup. The QEMU setup can be tested by someone who knows how. The Coreboot setup cannot presently be tested easily.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

eric_metricspace.net edited the summary of this revision. (Show Details)Sep 7 2019, 1:27 AM
linimon retitled this revision from Refurbish GRUB port to sysutils/grub2: revive GRUB port.Sep 7 2019, 7:13 PM

I noticed there was a recent release, so I updated

sysutils/grub2/files/patch-grub-core-osdep-unix-getroot.c
7

These are probably unnecessary

sysutils/grub2/files/patch-po-POTFILES.in
7

This can be dropped, as it seems to have been fixed in the latest version.

sysutils/grub2/files/patch-util-getroot.c
7

These are probably unnecessary

sysutils/grub2/files/patch-util-grub-install.c
20

This set of changes seems to be a noop

lwhsu requested changes to this revision.Sep 14 2019, 1:34 PM
lwhsu added a subscriber: lwhsu.

Will you do further testing for your comments in the patches?

sysutils/grub2/Makefile
6

PORTREVISION can be reset (removed) when PORTVERSION bumped.

18

These lines can be just deleted.

This revision now requires changes to proceed.Sep 14 2019, 1:34 PM