Page MenuHomeFreeBSD

sysutils/grub2: revive GRUB port
Needs ReviewPublic

Authored by eric_metricspace.net on Sep 7 2019, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 28, 1:50 AM
Unknown Object (File)
Feb 22 2024, 6:31 AM
Unknown Object (File)
Jan 29 2024, 11:54 PM
Unknown Object (File)
Jan 23 2024, 10:51 PM
Unknown Object (File)
Jan 10 2024, 11:15 PM
Unknown Object (File)
Dec 20 2023, 1:41 AM
Unknown Object (File)
Dec 15 2023, 5:08 AM
Unknown Object (File)
Dec 9 2023, 9:13 AM

Details

Reviewers
lwhsu
Summary

This patch updates the GRUB port to a recent release, restores functionality, and adds more build options.

This is not yet ready to be committed, but it can be reviewed/tested.

Test Plan

This has been tested with EFI. It currently does not pass in the EFI map to the kernel, but it can boot with a working frame buffer. The PC version can be tested with a legacy BIOS setup. The QEMU setup can be tested by someone who knows how. The Coreboot setup cannot presently be tested easily.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

linimon retitled this revision from Refurbish GRUB port to sysutils/grub2: revive GRUB port.Sep 7 2019, 7:13 PM

I noticed there was a recent release, so I updated

sysutils/grub2/files/patch-grub-core-osdep-unix-getroot.c
7

These are probably unnecessary

sysutils/grub2/files/patch-po-POTFILES.in
7

This can be dropped, as it seems to have been fixed in the latest version.

sysutils/grub2/files/patch-util-getroot.c
7

These are probably unnecessary

sysutils/grub2/files/patch-util-grub-install.c
20

This set of changes seems to be a noop

lwhsu requested changes to this revision.Sep 14 2019, 1:34 PM
lwhsu added a subscriber: lwhsu.

Will you do further testing for your comments in the patches?

sysutils/grub2/Makefile
6

PORTREVISION can be reset (removed) when PORTVERSION bumped.

18

These lines can be just deleted.

This revision now requires changes to proceed.Sep 14 2019, 1:34 PM

This still has the same issues that led to removal of it in the first place. Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234508 for the previous attempt. Ability to build it with newer GCC versions is sort of a prerequisite to readd it to the tree. gcc7 is EOL and has been DEPRECATED now.

Switched to gcc9, tested successfully with EFI.

eric_metricspace.net edited the test plan for this revision. (Show Details)

Added ability to pass in EFI framebuffer info, so efifb works.

Remaining work to be done: pass in EFI map, pass in GELI keys to keybuf, try compiling with clang.