Page MenuHomeFreeBSD

Abstract ZFS preferred device detection
ClosedPublic

Authored by eric_metricspace.net on Oct 2 2017, 11:31 AM.

Details

Summary

This is a part of https://reviews.freebsd.org/D10447, and a precursor to that patch.

This abstracts the way that preferred ZFS devices are detected, paving the way for the boot1 refactor.

Test Plan

As of creation, this needs to be tested. The original change did introduce an error, so it needs to be tested with ZFS to ensure that separating it from D10447 didn't introduce new ones.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Confirmed this works in QEMU

This revision was automatically updated to reflect the committed changes.
imp added a comment.Oct 6 2017, 12:27 PM

These looked good. I've committed it. efi_devpath_is_prefix is a bit of a duplication, but a useful one. It's also not yet used, but I assume further patches will use it.