Page MenuHomeFreeBSD
Differential D10486

Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE
ClosedPublic
Actions

Authored by eric_metricspace.net on Apr 24 2017, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 8:52 PM
Unknown Object (File)
Thu, Nov 27, 11:22 PM
Unknown Object (File)
Thu, Nov 27, 9:33 AM
Unknown Object (File)
Thu, Nov 20, 4:44 PM
Unknown Object (File)
Thu, Nov 20, 4:43 PM
Unknown Object (File)
Thu, Nov 20, 4:43 PM
Unknown Object (File)
Thu, Nov 20, 4:42 PM
Unknown Object (File)
Thu, Nov 20, 4:35 PM
View All Files
Subscribers
cem
imp
Contributor Reviews (src)

Details

Reviewers
emaste
dim
cem
kaiw
Commits
rS337045: libelf: reload section headers after update with ELF_C_WRITE
Summary

The libelf library in base doesn't reload section headers after clearing them when performing an elf_update with ELF_C_WRITE. This is because it fails to clear a flag indicating that the section headers have been loaded.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

eric_metricspace.net created this revision.Apr 24 2017, 11:15 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptApr 24 2017, 11:15 PM
allanjude added reviewers: emaste, dim.Apr 24 2017, 11:19 PM
cem added a subscriber: cem.Apr 24 2017, 11:21 PM

Please upload a patch with context (-U99999) (or use arc).

eric_metricspace.net updated this revision to Diff 27707.Apr 24 2017, 11:25 PM
cem accepted this revision.Apr 24 2017, 11:27 PM
This revision is now accepted and ready to land.Apr 24 2017, 11:27 PM
emaste added a reviewer: kaiw.Apr 25 2017, 12:53 AM
emaste mentioned this in D10487: Bug 218861 - libelf elf_update fails when adding sections.May 28 2017, 8:26 PM
cem added a comment.Nov 17 2017, 7:44 PM

@emaste , @kaiw , any objection to committing this change?

emaste added a comment.Nov 17 2017, 8:15 PM
In D10486#273287, @cem wrote:

@emaste , @kaiw , any objection to committing this change?

I have no objection, although I'd really like kaiw@ to comment

emaste added a comment.Aug 1 2018, 1:51 PM

I pinged @kaiw by email requesting a look at this change.

eric_metricspace.net added a comment.Aug 1 2018, 1:55 PM

Background on this (and the other related change): I ran into both issues implementing signelf. They caused anomalous bugs, and I tracked them down and fixed them. So they're definitely issues, and the fixes definitely work.

emaste added a comment.Aug 1 2018, 2:07 PM

Other issue in D10487

Closed by commit rS337045: libelf: reload section headers after update with ELF_C_WRITE (authored by emaste). · Explain WhyAug 1 2018, 3:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
contrib/
elftoolchain/
libelf/
1 line

Diff 46133

View Options

head/contrib/elftoolchain/libelf/elf_update.c

Loading...