Page MenuHomeFreeBSD

kaiw (Kai Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 18 2016, 5:57 PM (178 w, 1 d)

Recent Activity

Oct 18 2018

kaiw accepted D17596: objcopy: restore behaviour required by GCC's build.

I applied the new patch and all the test cases passed!

Oct 18 2018, 8:35 PM
kaiw added a comment to D17596: objcopy: restore behaviour required by GCC's build.

I've emailed you a modfied patch.

Oct 18 2018, 7:00 PM
kaiw requested changes to D17596: objcopy: restore behaviour required by GCC's build.

Ed, patch looks good. Just need a small change. When symbol table does not exist in the output, we need to check
and skip relocation sections for dynamic symbols. Otherwise strip will segfault when called on dynamic linked executables
that's already stripped.

Oct 18 2018, 6:56 PM

Oct 13 2018

kaiw accepted D17519: elfcopy: delete filter_reloc, it is broken and unnecessary.

Patch is OK. I've run the test suite with this change and it only breaks a few meaningless test cases. I can investigate more later.

Oct 13 2018, 3:41 AM

Dec 29 2016

kaiw added a comment to D8920: libdwarf: Add DW_AT_specification handling to dwarf_attrval_*.

Patch looks good to me. thanks!

Dec 29 2016, 3:31 AM

Dec 7 2016

kaiw accepted D8707: readelf(1) -S: Include zero index and match binutils' no-name.

Patch looks good to me!

Dec 7 2016, 5:41 PM

Oct 26 2016

kaiw added a comment to D8334: strings: fix exit status if a file before the last one fails.

patch looks good to me

Oct 26 2016, 7:13 PM

Aug 30 2016

kaiw accepted D7632: elfcopy: use elftc_timestamp, to support SOURCE_DATE_EPOCH.

Patch looks good to me!

Aug 30 2016, 9:55 PM
kaiw accepted D7631: libelftc: add elftc_timestamp to handle SOURCE_DATE_EPOCH.

accept revision (only a minor change in the manual page needed, as stated in the comment)

Aug 30 2016, 9:53 PM
kaiw added a comment to D7631: libelftc: add elftc_timestamp to handle SOURCE_DATE_EPOCH.

The manual page is missing a ".El" between .Xr strtoll 3 . and .Sh SEE ALSO
Otherwise the patch looks quite good! Thanks!

Aug 30 2016, 9:51 PM

May 25 2016

kaiw accepted D6560: readelf: report all relocation types in rel/rela for MIPS N64.

accept patch

May 25 2016, 6:07 PM
kaiw added a comment to D6560: readelf: report all relocation types in rel/rela for MIPS N64.

The patch looks good to me. (although I didn't test it with a MIPS N64 object)

May 25 2016, 6:07 PM

May 18 2016

kaiw accepted D6426: libdwarf: validate relocation offsets.

Patch looks good. Please commit!

May 18 2016, 6:05 PM