readelf(1) -S: Include zero index and match binutils' no-name
ClosedPublic
Actions

Authored by cem on Dec 4 2016, 2:39 AM.

Details

Reviewers

emaste
kaiw

Commits

rS309679: readelf(1) -S: Include zero index and match binutils' no-name

Summary

Include the SHN_UNDEF (zero) index special section in extended-attribute
ELF files, like GNU binutils' readelf.

Additionally, print "<no-name>" for sections without names, like GNU
binutils.

Test Plan

This is the last change needed to elftoolchain to match binutils behavior for
the coredump_phnum test case.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem updated this revision to Diff 22696.Dec 4 2016, 2:39 AM

cem retitled this revision from to readelf(1) -S: Include zero index and match binutils' no-name.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added a reviewer: emaste.

cem added inline comments.Dec 4 2016, 2:42 AM

contrib/elftoolchain/readelf/readelf.c
6560 ↗	(On Diff #22696)	For parity with binutils.
6566 ↗	(On Diff #22696)	(Only skip sections if there was actually an error — it's valid for ELF files to have a SHN_UNDEX index section.)

emaste added a reviewer: kaiw.Dec 5 2016, 9:17 PM

Patch looks good to me!

This revision is now accepted and ready to land.Dec 7 2016, 5:41 PM

Closed by commit rS309679: readelf(1) -S: Include zero index and match binutils' no-name (authored by cem). · Explain WhyDec 7 2016, 6:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

readelf/

readelf.c

7 lines

Diff 22746

View Options

head/contrib/elftoolchain/readelf/readelf.c

readelf(1) -S: Include zero index and match binutils' no-nameClosedPublicActions