Page MenuHomeFreeBSD

Improve computation of {BC,LL}OBJS.
ClosedPublic

Authored by jonathan on Oct 17 2017, 4:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 6 2024, 3:16 AM
Unknown Object (File)
Dec 24 2023, 11:31 AM
Unknown Object (File)
Dec 22 2023, 11:25 PM
Unknown Object (File)
Dec 10 2023, 8:18 PM
Unknown Object (File)
Nov 15 2023, 9:50 AM
Unknown Object (File)
Oct 18 2023, 11:24 PM
Unknown Object (File)
Oct 13 2023, 8:42 PM
Unknown Object (File)
Oct 13 2023, 8:09 PM
Subscribers

Details

Summary

Now that OBJS has grown an OBJS_SRCS_FILTER variable, use this variable
in the computation of BCOBJS and LLOBJS too. Also move BCOBJS and LLOBJS
computation to be next to the OBJS computation: this should both make
the parallel structure clearer and serve to remind people changing OBJS
that parallel changes are required in BCOBJS and LLOBJS.

A side effect of this change is that BCOBJS and LLOBJS will be available
even when LLVM_LINK has not been defined, but that seems like a positive
change: there's no reason we can't ask "what bitcode files would you
generate" just because we can't link those files together into a
complete bitcode representation of a binary or library.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12086
Build 12388: arc lint + arc unit

Event Timeline

  • Prefer += to = when computing {BC,LL}OBJS.

Ok so apart from moving the definitions, the key improvement is suppressing .bco etc. for .asm ?

This revision is now accepted and ready to land.Oct 17 2017, 6:47 PM
In D12701#263694, @sjg wrote:

Ok so apart from moving the definitions, the key improvement is suppressing .bco etc. for .asm ?

Yup, that's right.

This revision was automatically updated to reflect the committed changes.